[jira] [Commented] (SPARK-14768) Remove expectedType arg for PySpark Param

2016-04-21 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252465#comment-15252465
 ] 

Apache Spark commented on SPARK-14768:
--

User 'jasoncl' has created a pull request for this issue:
https://github.com/apache/spark/pull/12581

> Remove expectedType arg for PySpark Param
> -
>
> Key: SPARK-14768
> URL: https://issues.apache.org/jira/browse/SPARK-14768
> Project: Spark
>  Issue Type: Improvement
>  Components: ML, PySpark
>Reporter: Joseph K. Bradley
>Priority: Minor
>
> We could go ahead and removed the expectedType in 2.0. The only reason to 
> keep it is to avoid breaking 3rd party implementations of PipelineStages in 
> Python which happen to be using the expectedType arg.  I doubt there are many 
> such implementations.
> Keeping that argument has led to problems with mixing the expectedType and 
> typeConverter args, as in [https://github.com/apache/spark/pull/12480]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-14768) Remove expectedType arg for PySpark Param

2016-04-21 Thread Jason C Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252280#comment-15252280
 ] 

Jason C Lee commented on SPARK-14768:
-

Seems straightforward enough. I am working on the PR

> Remove expectedType arg for PySpark Param
> -
>
> Key: SPARK-14768
> URL: https://issues.apache.org/jira/browse/SPARK-14768
> Project: Spark
>  Issue Type: Improvement
>  Components: ML, PySpark
>Reporter: Joseph K. Bradley
>Priority: Minor
>
> We could go ahead and removed the expectedType in 2.0. The only reason to 
> keep it is to avoid breaking 3rd party implementations of PipelineStages in 
> Python which happen to be using the expectedType arg.  I doubt there are many 
> such implementations.
> Keeping that argument has led to problems with mixing the expectedType and 
> typeConverter args, as in [https://github.com/apache/spark/pull/12480]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org