[jira] [Commented] (SPARK-1493) Apache RAT excludes don't work with file path (instead of file name)
[ https://issues.apache.org/jira/browse/SPARK-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935437#comment-14935437 ] Sandhya Sundaresan commented on SPARK-1493: --- Erik's proposal would certainly help us in the Trafodion project. We have a high level directory sturcture on which we'd like to run RAT. We have several subdirectories and want to include only a subset of files in each of those directories. Using filename patterns without /path would make the exclusions imprecise. There may be the same file it 2 different subdirectories and both would get excluded which we don't really intend to do.We want to exclude specific files in specific directories with a regexp. Unfortunately it isn't working. > Apache RAT excludes don't work with file path (instead of file name) > > > Key: SPARK-1493 > URL: https://issues.apache.org/jira/browse/SPARK-1493 > Project: Spark > Issue Type: Bug > Components: Project Infra >Reporter: Patrick Wendell > Labels: starter > > Right now the way we do RAT checks, it doesn't work if you try to exclude: > /path/to/file.ext > you have to just exclude > file.ext -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-1493) Apache RAT excludes don't work with file path (instead of file name)
[ https://issues.apache.org/jira/browse/SPARK-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038921#comment-14038921 ] Erik Erlandson commented on SPARK-1493: --- I submitted a proposal patch for RAT-161, which allows one to request path-spanning patterns by including a leading '/' If '--dir' argument is /path/to/repo, and contents of '-E' file includes: /subpath/to/.*ext then the pattern induced is: /path/to/repo + /subpath/to/.*ex t -- /path/to/repo/subpath/to/.*ext Apache RAT excludes don't work with file path (instead of file name) Key: SPARK-1493 URL: https://issues.apache.org/jira/browse/SPARK-1493 Project: Spark Issue Type: Bug Components: Project Infra Reporter: Patrick Wendell Labels: starter Right now the way we do RAT checks, it doesn't work if you try to exclude: /path/to/file.ext you have to just exclude file.ext -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SPARK-1493) Apache RAT excludes don't work with file path (instead of file name)
[ https://issues.apache.org/jira/browse/SPARK-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025895#comment-14025895 ] Erik Erlandson commented on SPARK-1493: --- RAT itself appears to preclude exclusion using a /path/to/file.ext regex because it traverses the directory tree and applies its exclusion filter only to individual file names. The filter never sees an entire path path/to/file.ext, only path, to, and file.ext https://github.com/apache/rat/blob/incubator-site-import/rat/rat-core/src/main/java/org/apache/rat/DirectoryWalker.java#L127 Either RAT needs a new filtering feature that can see an entire path, or the report it generates has to be filtered post-hoc. Apache RAT excludes don't work with file path (instead of file name) Key: SPARK-1493 URL: https://issues.apache.org/jira/browse/SPARK-1493 Project: Spark Issue Type: Bug Components: Project Infra Reporter: Patrick Wendell Labels: starter Fix For: 1.1.0 Right now the way we do RAT checks, it doesn't work if you try to exclude: /path/to/file.ext you have to just exclude file.ext -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SPARK-1493) Apache RAT excludes don't work with file path (instead of file name)
[ https://issues.apache.org/jira/browse/SPARK-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025954#comment-14025954 ] Patrick Wendell commented on SPARK-1493: Thanks for looking into this Erik. It seems like maybe there isn't a good way to do unless we want to implement filtering post-hoc (and it might be tricky to support e.g. globbing in that case). Apache RAT excludes don't work with file path (instead of file name) Key: SPARK-1493 URL: https://issues.apache.org/jira/browse/SPARK-1493 Project: Spark Issue Type: Bug Components: Project Infra Reporter: Patrick Wendell Labels: starter Right now the way we do RAT checks, it doesn't work if you try to exclude: /path/to/file.ext you have to just exclude file.ext -- This message was sent by Atlassian JIRA (v6.2#6252)
