[jira] [Commented] (SPARK-15684) Not mask startsWith and endsWith in R
[ https://issues.apache.org/jira/browse/SPARK-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313130#comment-15313130 ] Apache Spark commented on SPARK-15684: -- User 'wangmiao1981' has created a pull request for this issue: https://github.com/apache/spark/pull/13476 > Not mask startsWith and endsWith in R > - > > Key: SPARK-15684 > URL: https://issues.apache.org/jira/browse/SPARK-15684 > Project: Spark > Issue Type: Improvement >Reporter: Miao Wang > > In R 3.3.0, it has startsWith and endsWith. We should not mask this two > methods in Spark. Actually, Spark R has startsWith and endsWith working for > column. But making them work for both column and string is not easy. I create > this JIRA for discussions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15684) Not mask startsWith and endsWith in R
[ https://issues.apache.org/jira/browse/SPARK-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311019#comment-15311019 ] Miao Wang commented on SPARK-15684: --- Yanbo suggested a method offline. I will give a try. > Not mask startsWith and endsWith in R > - > > Key: SPARK-15684 > URL: https://issues.apache.org/jira/browse/SPARK-15684 > Project: Spark > Issue Type: Improvement >Reporter: Miao Wang >Priority: Minor > > In R 3.3.0, it has startsWith and endsWith. We should not mask this two > methods in Spark. Actually, Spark R has startsWith and endsWith working for > column. But making them work for both column and string is not easy. I create > this JIRA for discussions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15684) Not mask startsWith and endsWith in R
[ https://issues.apache.org/jira/browse/SPARK-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310566#comment-15310566 ] Shivaram Venkataraman commented on SPARK-15684: --- We just need to match the signature to the one in https://stat.ethz.ch/R-manual/R-devel/library/base/html/startsWith.html - It looks like the one in base R is `startsWith(x, prefix)` > Not mask startsWith and endsWith in R > - > > Key: SPARK-15684 > URL: https://issues.apache.org/jira/browse/SPARK-15684 > Project: Spark > Issue Type: Improvement >Reporter: Miao Wang >Priority: Minor > > In R 3.3.0, it has startsWith and endsWith. We should not mask this two > methods in Spark. Actually, Spark R has startsWith and endsWith working for > column. But making them work for both column and string is not easy. I create > this JIRA for discussions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15684) Not mask startsWith and endsWith in R
[ https://issues.apache.org/jira/browse/SPARK-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309989#comment-15309989 ] Yanbo Liang commented on SPARK-15684: - [~wm624] Yes, this one is similar with read.csv and write.csv. You can refer the comments at https://github.com/apache/spark/pull/11457, although that was not merged. We should match the arguments of ```startsWith``` and not mask the native one. ```startsWith``` is a S3 method and the native one has different signature with SparkR. > Not mask startsWith and endsWith in R > - > > Key: SPARK-15684 > URL: https://issues.apache.org/jira/browse/SPARK-15684 > Project: Spark > Issue Type: Improvement >Reporter: Miao Wang >Priority: Minor > > In R 3.3.0, it has startsWith and endsWith. We should not mask this two > methods in Spark. Actually, Spark R has startsWith and endsWith working for > column. But making them work for both column and string is not easy. I create > this JIRA for discussions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15684) Not mask startsWith and endsWith in R
[ https://issues.apache.org/jira/browse/SPARK-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308940#comment-15308940 ] Miao Wang commented on SPARK-15684: --- [~yanboliang] Per our discussion, this one is similar to implement read_csv in Spark R and there is no nice solution for this type of issues. Can you comment on this jira? Thanks! > Not mask startsWith and endsWith in R > - > > Key: SPARK-15684 > URL: https://issues.apache.org/jira/browse/SPARK-15684 > Project: Spark > Issue Type: Improvement >Reporter: Miao Wang >Priority: Minor > > In R 3.3.0, it has startsWith and endsWith. We should not mask this two > methods in Spark. Actually, Spark R has startsWith and endsWith working for > column. But making them work for both column and string is not easy. I create > this JIRA for discussions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
