[jira] [Commented] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330696#comment-15330696
]
Apache Spark commented on SPARK-15741:
--
User 'BryanCutler' has created a pull request for this issue:
https://github.com/apache/spark/pull/13672
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> Several places in PySpark ML have Params._setDefault with a seed param equal
> to {{None}}. This is unnecessary as it will translate to a {{0}} even though
> the param has a fixed value based by on the hashed classname by default.
> Currently, the ALS doc test output depends on this happening and would be
> more clear and stable if it was explicitly set to {{0}}. These should be
> cleaned up for stability and consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313376#comment-15313376
]
Bryan Cutler commented on SPARK-15741:
--
>From what I gathered, explicitly setting a seed to {{None}} in python will
>translate to Scala with a value of {{0L}}, and the default value set in the
>{{HasSeed}} shared param for Python and Scala is a non-random hash value based
>off the class name. If you want a random seed, you need to explicitly set it.
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> Calling Params._setDefault with a param equal to {{None}} will be ignored
> internally silently. There are several cases where this is done with the
> {{seed}} param, making it seem like it might do something. These cases
> should be removed for the sake of consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
