[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401701#comment-15401701
]
Apache Spark commented on SPARK-16756:
--
User 'dongjoon-hyun' has created a pull request for this issue:
https://github.com/apache/spark/pull/14435
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396341#comment-15396341
]
Reynold Xin commented on SPARK-16756:
-
That makes sense.
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396340#comment-15396340
]
Dongjoon Hyun commented on SPARK-16756:
---
If there is anything you have in mind, please give me advice.
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396337#comment-15396337
]
Dongjoon Hyun commented on SPARK-16756:
---
Until now, there are no flags. I'm trying to not use any other information,
slightly different from SQLBuilder.
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396331#comment-15396331
]
Reynold Xin commented on SPARK-16756:
-
This makes sense. Are there flags we might want to pass into sql generation?
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-16756) Add `sql` function to LogicalPlan and `NonSQLPlan` trait
[
https://issues.apache.org/jira/browse/SPARK-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396321#comment-15396321
]
Dongjoon Hyun commented on SPARK-16756:
---
Hi, [~rxin].
So far, I've been working in this direction. I'll make a PR after completing
full SQL generation.
Since this is a design choice, could you give me some opinion on this direction?
> Add `sql` function to LogicalPlan and `NonSQLPlan` trait
>
>
> Key: SPARK-16756
> URL: https://issues.apache.org/jira/browse/SPARK-16756
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
>Reporter: Dongjoon Hyun
>
> Like `Expression`, this issue adds `sql` function for `LogicalPlan` and
> `NonSQLPlan` trait. The method will be `abstract` method. All logical plan
> should implement that or use trait `NonSQLPlan` explicitly.
> {code}
> /**
> * Returns SQL representation of this plan. For the plans extending
> [[NonSQLPlan]],
> * this method may return an arbitrary user facing string.
> */
> def sql: String
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
