[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949284#comment-15949284 ] Denis Bolshakov commented on SPARK-20127: - [~srowen] thanks for driving me. A lot of motivation! > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.1.0 >Reporter: Denis Bolshakov >Assignee: Denis Bolshakov >Priority: Minor > Fix For: 2.2.0 > > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945107#comment-15945107 ] Apache Spark commented on SPARK-20127: -- User 'dbolshak' has created a pull request for this issue: https://github.com/apache/spark/pull/17458 > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.1.0 >Reporter: Denis Bolshakov >Priority: Minor > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945058#comment-15945058 ] Sean Owen commented on SPARK-20127: --- We use pull requests to suggest changes, but before you do, I think most of those changes have not been made so far in the code on purpose. > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.1.0 >Reporter: Denis Bolshakov >Priority: Minor > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945051#comment-15945051 ] Denis Bolshakov commented on SPARK-20127: - I applied you first comments (just by reverting changes). Full patch could be found here https://github.com/dbolshak/spark/tree/SPARK-20127 > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.1.0 >Reporter: Denis Bolshakov >Priority: Minor > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945014#comment-15945014 ] Denis Bolshakov commented on SPARK-20127: - You can review changes shortly here https://github.com/dbolshak/spark/commit/8a31173b436eb7d39f2423eccda7932239f8d5b6 Nothing else right now. > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.1.0 >Reporter: Denis Bolshakov >Priority: Minor > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945002#comment-15945002 ] Denis Bolshakov commented on SPARK-20127: - Hello [~srowen], thanks for quick feedback. Could you please assign issue to me? )) I understand your point I've tried to exclude changes related to code style or dispute changes. I believe there are no changes that could have performance impact. Kind regards, Denis > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.3.0 >Reporter: Denis Bolshakov > Labels: newbiee > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20127) Minor code cleanup
[ https://issues.apache.org/jira/browse/SPARK-20127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944984#comment-15944984 ] Sean Owen commented on SPARK-20127: --- I am a fan of improving code style and static inspection. However we have generally declined to do big-bang modifications to the code base where the change is purely a question of style. Otherwise I would have done this a long time ago :) Before starting, have a look and see if any are correctness or significant performance issues, or small changes that would resolve a consistency problem. Mention them here first. > Minor code cleanup > -- > > Key: SPARK-20127 > URL: https://issues.apache.org/jira/browse/SPARK-20127 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.3.0 >Reporter: Denis Bolshakov > Labels: newbiee > > Intellij IDEA shows a bunch of messages while inspecting source code. > So fixing the most explicit ones gives the following: > - improving source code quality > - involving to contributing process -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
