[jira] [Commented] (SPARK-21388) GBT inherit from HasStepSize & LInearSVC/Binarizer from HasThreshold

2017-07-14 Thread Nick Pentreath (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087216#comment-16087216
 ] 

Nick Pentreath commented on SPARK-21388:


What is the benefit of doing this?

> GBT inherit from HasStepSize & LInearSVC/Binarizer from HasThreshold
> 
>
> Key: SPARK-21388
> URL: https://issues.apache.org/jira/browse/SPARK-21388
> Project: Spark
>  Issue Type: Improvement
>  Components: ML, PySpark
>Affects Versions: 2.2.1
>Reporter: zhengruifeng
>
> make GBTs inherit from {{HasStepSize}} and LInearSVC/Binarizer inherit from 
> {{HasThreshold}}
> The desc for param {{StepSize}} of GBTs in Pydoc is wrong, so I also override 
> it in the python side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-21388) GBT inherit from HasStepSize & LInearSVC/Binarizer from HasThreshold

2017-07-12 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083974#comment-16083974
 ] 

Apache Spark commented on SPARK-21388:
--

User 'zhengruifeng' has created a pull request for this issue:
https://github.com/apache/spark/pull/18612

> GBT inherit from HasStepSize & LInearSVC/Binarizer from HasThreshold
> 
>
> Key: SPARK-21388
> URL: https://issues.apache.org/jira/browse/SPARK-21388
> Project: Spark
>  Issue Type: Improvement
>  Components: ML, PySpark
>Affects Versions: 2.2.1
>Reporter: zhengruifeng
>
> make GBTs inherit from {{HasStepSize}} and LInearSVC/Binarizer inherit from 
> {{HasThreshold}}
> The desc for param {{StepSize}} of GBTs in Pydoc is wrong, so I also override 
> it in the python side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org