[jira] [Commented] (SPARK-23284) Document several get API of ColumnVector's behavior when accessing null slot
[ https://issues.apache.org/jira/browse/SPARK-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349353#comment-16349353 ] Sameer Agarwal commented on SPARK-23284: Thanks, given the other open blockers, we should have enough time to get this in before RC3. > Document several get API of ColumnVector's behavior when accessing null slot > > > Key: SPARK-23284 > URL: https://issues.apache.org/jira/browse/SPARK-23284 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.3.0 >Reporter: Liang-Chi Hsieh >Priority: Major > > We should clearly document the behavior of some ColumnVector get APIs such as > getBinary, getStruct, getArray, etc., when accessing a null slot. Those APIs > should return null if the slot is null. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23284) Document several get API of ColumnVector's behavior when accessing null slot
[ https://issues.apache.org/jira/browse/SPARK-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348145#comment-16348145 ] Wenchen Fan commented on SPARK-23284: - Since this defines the "return null" behavior for `ColumnVector` implementations, it's good to get this in before 2.3 release. But technically Spark won't call `ColumnVector.getXXX` if that slot is null, so it's OK to leave it to 2.4. Thus I'm not going to mark this as a blocker. cc [~sameerag] > Document several get API of ColumnVector's behavior when accessing null slot > > > Key: SPARK-23284 > URL: https://issues.apache.org/jira/browse/SPARK-23284 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.3.0 >Reporter: Liang-Chi Hsieh >Priority: Major > > We should clearly document the behavior of some ColumnVector get APIs such as > getBinary, getStruct, getArray, etc., when accessing a null slot. Those APIs > should return null if the slot is null. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23284) Document several get API of ColumnVector's behavior when accessing null slot
[ https://issues.apache.org/jira/browse/SPARK-23284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346896#comment-16346896 ] Apache Spark commented on SPARK-23284: -- User 'viirya' has created a pull request for this issue: https://github.com/apache/spark/pull/20455 > Document several get API of ColumnVector's behavior when accessing null slot > > > Key: SPARK-23284 > URL: https://issues.apache.org/jira/browse/SPARK-23284 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.4.0 >Reporter: Liang-Chi Hsieh >Priority: Major > > We should clearly document the behavior of some ColumnVector get APIs such as > getBinary, getStruct, getArray, etc., when accessing a null slot. Those APIs > should return null if the slot is null. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
