[jira] [Commented] (SPARK-25999) make-distribution.sh failure with --r and -Phadoop-provided
[
https://issues.apache.org/jira/browse/SPARK-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715272#comment-16715272
]
ASF GitHub Bot commented on SPARK-25999:
srowen closed pull request #22997: SPARK-25999: make-distribution.sh failure
with --r and -Phadoop-provided
URL: https://github.com/apache/spark/pull/22997
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/R/rjarsdep/pom.xml b/R/rjarsdep/pom.xml
new file mode 100644
index 0..a9c88a10b1d94
--- /dev/null
+++ b/R/rjarsdep/pom.xml
@@ -0,0 +1,89 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+org.apache.spark
+spark-parent_2.11
+2.3.3-SNAPSHOT
+../../pom.xml
+
+
+ r-jars-dep
+ Spark Project Dependency for R
+ http://spark.apache.org/
+ pom
+
+
+rjarsdep
+none
+package
+
+
+
+
+
+ org.spark-project.spark
+ unused
+ 1.0.0
+ provided
+
+
+ org.apache.spark
+ spark-core_${scala.binary.version}
+ ${project.version}
+
+
+ org.apache.spark
+ spark-mllib_${scala.binary.version}
+ ${project.version}
+
+
+ org.apache.spark
+ spark-streaming_${scala.binary.version}
+ ${project.version}
+
+
+ org.apache.spark
+ spark-graphx_${scala.binary.version}
+ ${project.version}
+
+
+ org.apache.spark
+ spark-sql_${scala.binary.version}
+ ${project.version}
+
+
+ org.apache.spark
+ spark-repl_${scala.binary.version}
+ ${project.version}
+
+
+
+
+ com.google.guava
+ guava
+ ${hadoop.deps.scope}
+
+
+
diff --git a/dev/make-distribution.sh b/dev/make-distribution.sh
index 84f4ae9a64ff8..7348b5b3847f5 100755
--- a/dev/make-distribution.sh
+++ b/dev/make-distribution.sh
@@ -241,6 +241,10 @@ fi
# Make R package - this is used for both CRAN release and packing R layout
into distribution
if [ "$MAKE_R" == "true" ]; then
+ echo "Make sure Spark jars folder contains all hadoop dependencies"
+ SPARK_JARS_DIR="$SPARK_HOME/assembly/target/scala-${SCALA_VERSION}/jars"
+ cp -n ${SPARK_HOME}/R/rjarsdep/target/scala-${SCALA_VERSION}/jars/*
$SPARK_JARS_DIR
+
echo "Building R source package"
R_PACKAGE_VERSION=`grep Version "$SPARK_HOME/R/pkg/DESCRIPTION" | awk
'{print $NF}'`
pushd "$SPARK_HOME/R" > /dev/null
diff --git a/pom.xml b/pom.xml
index a08b7fda33387..0eaf79c1d7b3c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2797,6 +2797,9 @@
sparkr
+
+R/rjarsdep
+
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make-distribution.sh failure with --r and -Phadoop-provided
> ---
>
> Key: SPARK-25999
> URL: https://issues.apache.org/jira/browse/SPARK-25999
> Project: Spark
> Issue Type: Bug
> Components: Build
>Affects Versions: 2.3.2, 2.4.0
>Reporter: shanyu zhao
>Priority: Major
> Attachments: SPARK-25999.patch
>
>
> It is not possible to build a distribution that doesn't contain hadoop
> dependencies but include SparkR. This is because R/check_cran.sh builds R
> document which depends on hadoop dependencies in
> assembly/target/scala-xxx/jars folder.
> To reproduce:
> MAVEN_BUILD_OPTS="-Dmaven.javadoc.skip=true -Pyarn -Phadoop-2.7 -Phive
> -Psparkr -Phadoop-provided"
> ./dev/make-distribution.sh --tgz --r $MAVEN_BUILD_OPTS
>
> Error:
> * creating vignettes ... ERROR
> ...
> Error: A JNI error has occurred, please check your installation and try again
> Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/Logger
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-25999) make-distribution.sh failure with --r and -Phadoop-provided
[ https://issues.apache.org/jira/browse/SPARK-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682129#comment-16682129 ] Apache Spark commented on SPARK-25999: -- User 'shanyu' has created a pull request for this issue: https://github.com/apache/spark/pull/22997 > make-distribution.sh failure with --r and -Phadoop-provided > --- > > Key: SPARK-25999 > URL: https://issues.apache.org/jira/browse/SPARK-25999 > Project: Spark > Issue Type: Bug > Components: Build >Affects Versions: 2.3.2, 2.4.0 >Reporter: shanyu zhao >Priority: Major > Attachments: SPARK-25999.patch > > > It is not possible to build a distribution that doesn't contain hadoop > dependencies but include SparkR. This is because R/check_cran.sh builds R > document which depends on hadoop dependencies in > assembly/target/scala-xxx/jars folder. > To reproduce: > MAVEN_BUILD_OPTS="-Dmaven.javadoc.skip=true -Pyarn -Phadoop-2.7 -Phive > -Psparkr -Phadoop-provided" > ./dev/make-distribution.sh --tgz --r $MAVEN_BUILD_OPTS > > Error: > * creating vignettes ... ERROR > ... > Error: A JNI error has occurred, please check your installation and try again > Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/Logger -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-25999) make-distribution.sh failure with --r and -Phadoop-provided
[ https://issues.apache.org/jira/browse/SPARK-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682126#comment-16682126 ] Apache Spark commented on SPARK-25999: -- User 'shanyu' has created a pull request for this issue: https://github.com/apache/spark/pull/22997 > make-distribution.sh failure with --r and -Phadoop-provided > --- > > Key: SPARK-25999 > URL: https://issues.apache.org/jira/browse/SPARK-25999 > Project: Spark > Issue Type: Bug > Components: Build >Affects Versions: 2.3.2, 2.4.0 >Reporter: shanyu zhao >Priority: Major > Attachments: SPARK-25999.patch > > > It is not possible to build a distribution that doesn't contain hadoop > dependencies but include SparkR. This is because R/check_cran.sh builds R > document which depends on hadoop dependencies in > assembly/target/scala-xxx/jars folder. > To reproduce: > MAVEN_BUILD_OPTS="-Dmaven.javadoc.skip=true -Pyarn -Phadoop-2.7 -Phive > -Psparkr -Phadoop-provided" > ./dev/make-distribution.sh --tgz --r $MAVEN_BUILD_OPTS > > Error: > * creating vignettes ... ERROR > ... > Error: A JNI error has occurred, please check your installation and try again > Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/Logger -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-25999) make-distribution.sh failure with --r and -Phadoop-provided
[ https://issues.apache.org/jira/browse/SPARK-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682122#comment-16682122 ] Yuming Wang commented on SPARK-25999: - Please create pull request at: https://github.com/apache/spark/pulls > make-distribution.sh failure with --r and -Phadoop-provided > --- > > Key: SPARK-25999 > URL: https://issues.apache.org/jira/browse/SPARK-25999 > Project: Spark > Issue Type: Bug > Components: Build >Affects Versions: 2.3.2, 2.4.0 >Reporter: shanyu zhao >Priority: Major > Attachments: SPARK-25999.patch > > > It is not possible to build a distribution that doesn't contain hadoop > dependencies but include SparkR. This is because R/check_cran.sh builds R > document which depends on hadoop dependencies in > assembly/target/scala-xxx/jars folder. > To reproduce: > MAVEN_BUILD_OPTS="-Dmaven.javadoc.skip=true -Pyarn -Phadoop-2.7 -Phive > -Psparkr -Phadoop-provided" > ./dev/make-distribution.sh --tgz --r $MAVEN_BUILD_OPTS > > Error: > * creating vignettes ... ERROR > ... > Error: A JNI error has occurred, please check your installation and try again > Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/Logger -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-25999) make-distribution.sh failure with --r and -Phadoop-provided
[ https://issues.apache.org/jira/browse/SPARK-25999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682089#comment-16682089 ] shanyu zhao commented on SPARK-25999: - patch attached. Basically it creates an optional project that brings all dependencies to R/rjarsdep/target folder, and copy the missing jars to assembly/target folder before building R. > make-distribution.sh failure with --r and -Phadoop-provided > --- > > Key: SPARK-25999 > URL: https://issues.apache.org/jira/browse/SPARK-25999 > Project: Spark > Issue Type: Bug > Components: Build >Affects Versions: 2.3.2, 2.4.0 >Reporter: shanyu zhao >Priority: Major > Attachments: SPARK-25999.patch > > > It is not possible to build a distribution that doesn't contain hadoop > dependencies but include SparkR. This is because R/check_cran.sh builds R > document which depends on hadoop dependencies in > assembly/target/scala-xxx/jars folder. > To reproduce: > MAVEN_BUILD_OPTS="-Dmaven.javadoc.skip=true -Pyarn -Phadoop-2.7 -Phive > -Psparkr -Phadoop-provided" > ./dev/make-distribution.sh --tgz --r $MAVEN_BUILD_OPTS > > Error: > * creating vignettes ... ERROR > ... > Error: A JNI error has occurred, please check your installation and try again > Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/Logger -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
