[jira] [Commented] (SPARK-2685) Update ExternalAppendOnlyMap to avoid buffer.remove()

[Apache Spark (JIRA)]

[ 
https://issues.apache.org/jira/browse/SPARK-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085493#comment-14085493
 ] 

Apache Spark commented on SPARK-2685:
-

User 'mateiz' has created a pull request for this issue:
https://github.com/apache/spark/pull/1773

 Update ExternalAppendOnlyMap to avoid buffer.remove()
 -

 Key: SPARK-2685
 URL: https://issues.apache.org/jira/browse/SPARK-2685
 Project: Spark
  Issue Type: Sub-task
  Components: Spark Core
Reporter: Matei Zaharia
Assignee: Matei Zaharia

 This shifts the whole right side of the array back, which can be expensive. 
 It would be better to just swap the last element into the position we want to 
 remove at, then decrease the size of the array.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-2685) Update ExternalAppendOnlyMap to avoid buffer.remove()

[Mridul Muralidharan (JIRA)]

[ 
https://issues.apache.org/jira/browse/SPARK-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074186#comment-14074186
 ] 

Mridul Muralidharan commented on SPARK-2685:


We moved to using java.util.LinkedList for this

 Update ExternalAppendOnlyMap to avoid buffer.remove()
 -

 Key: SPARK-2685
 URL: https://issues.apache.org/jira/browse/SPARK-2685
 Project: Spark
  Issue Type: Sub-task
  Components: Spark Core
Reporter: Matei Zaharia

 This shifts the whole right side of the array back, which can be expensive. 
 It would be better to just swap the last element into the position we want to 
 remove at, then decrease the size of the array.



--
This message was sent by Atlassian JIRA
(v6.2#6252)