[jira] [Commented] (SPARK-26977) Warn against subclassing scala.App doesn't work
[
https://issues.apache.org/jira/browse/SPARK-26977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775783#comment-16775783
]
Manu Zhang commented on SPARK-26977:
I'd love to
> Warn against subclassing scala.App doesn't work
> ---
>
> Key: SPARK-26977
> URL: https://issues.apache.org/jira/browse/SPARK-26977
> Project: Spark
> Issue Type: Bug
> Components: Spark Submit
>Affects Versions: 2.4.0
>Reporter: Manu Zhang
>Priority: Minor
>
> As per discussion in
> [PR#3497|https://github.com/apache/spark/pull/3497#discussion_r258412735],
> the warn against subclassing scala.App doesn't work. For example,
> {code:scala}
> object Test extends scala.App {
>// spark code
> }
> {code}
> Scala will compile {{object Test}} into two Java classes, {{Test}} passed in
> by user and {{Test$}} subclassing {{scala.App}}. Currect code checks against
> {{Test}} and thus there will be no warn when user's application subclassing
> {{scala.App}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-26977) Warn against subclassing scala.App doesn't work
[
https://issues.apache.org/jira/browse/SPARK-26977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775776#comment-16775776
]
Sean Owen commented on SPARK-26977:
---
Sure, would you like to make a pull request?
> Warn against subclassing scala.App doesn't work
> ---
>
> Key: SPARK-26977
> URL: https://issues.apache.org/jira/browse/SPARK-26977
> Project: Spark
> Issue Type: Bug
> Components: Spark Submit
>Affects Versions: 2.4.0
>Reporter: Manu Zhang
>Priority: Minor
>
> As per discussion in
> [PR#3497|https://github.com/apache/spark/pull/3497#discussion_r258412735],
> the warn against subclassing scala.App doesn't work. For example,
> {code:scala}
> object Test extends scala.App {
>// spark code
> }
> {code}
> Scala will compile {{object Test}} into two Java classes, {{Test}} passed in
> by user and {{Test$}} subclassing {{scala.App}}. Currect code checks against
> {{Test}} and thus there will be no warn when user's application subclassing
> {{scala.App}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
