[jira] [Commented] (SPARK-28035) Test JoinSuite."equi-join is hash-join" is incompatible with its title.

2019-06-13 Thread Jiatao Tao (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-28035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862928#comment-16862928
 ] 

Jiatao Tao commented on SPARK-28035:


this test "multiple-key equi-join is hash-join" also the same situation.

> Test JoinSuite."equi-join is hash-join" is incompatible with its title.
> ---
>
> Key: SPARK-28035
> URL: https://issues.apache.org/jira/browse/SPARK-28035
> Project: Spark
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 2.4.3
>Reporter: Jiatao Tao
>Priority: Trivial
> Attachments: image-2019-06-13-10-32-06-759.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-28035) Test JoinSuite."equi-join is hash-join" is incompatible with its title.

2019-06-13 Thread Jiatao Tao (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-28035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862927#comment-16862927
 ] 

Jiatao Tao commented on SPARK-28035:


The title means hash-join, but when I debug, found it is a merge join.

 

And cannot get the idea that this test do, why only asserting the size? 

 

If this is a problem, I would like to modify this test, hope to hear your 
opinion, thanks.

!image-2019-06-13-10-32-06-759.png!

> Test JoinSuite."equi-join is hash-join" is incompatible with its title.
> ---
>
> Key: SPARK-28035
> URL: https://issues.apache.org/jira/browse/SPARK-28035
> Project: Spark
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 2.4.3
>Reporter: Jiatao Tao
>Priority: Trivial
> Attachments: image-2019-06-13-10-32-06-759.png
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org