[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964626#comment-16964626 ] Terry Kim commented on SPARK-29630: --- In the above example, the EXISTS clause becomes a `condition` of `Filter`. The current implementation is not exhaustive enough - e.g., it doesn't traverse Expression node, etc. I will create a PR to address this. > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Sub-task > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964157#comment-16964157 ] Terry Kim commented on SPARK-29630: --- Yes, I will take a look. > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Sub-task > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963858#comment-16963858 ] Wenchen Fan commented on SPARK-29630: - Yea this should be disallowed. We store view as text, so it's not allowed to have temp views appear in the view SQL text. I think it's a bug in the checking logic of `CREATE VIEW`: it doesn't go through subqueries. [~imback82] do you have time to look into it? > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Sub-task > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961797#comment-16961797 ] Aman Omer commented on SPARK-29630: --- cc [~srowen] [~LI,Xiao] [~cloud_fan] > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Sub-task > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961785#comment-16961785 ] Takeshi Yamamuro commented on SPARK-29630: -- Ah, I see. I'll recheck later. > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-29630) Not allowed to create a permanent view by referencing a temporary view in EXISTS
[ https://issues.apache.org/jira/browse/SPARK-29630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961765#comment-16961765 ] Aman Omer commented on SPARK-29630: --- [~maropu] I think when we project some constant in subquery, Spark will not link subquery's table/view. Hence table _v8_temp_ is not dependent on _temp_table_. Please check the output for following query. $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT * FROM temp_table); > Not allowed to create a permanent view by referencing a temporary view in > EXISTS > > > Key: SPARK-29630 > URL: https://issues.apache.org/jira/browse/SPARK-29630 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 3.0.0 >Reporter: Takeshi Yamamuro >Priority: Major > > {code} > // In the master, the query below fails > $ CREATE VIEW v7_temp AS SELECT t1.id, t2.a FROM base_table t1, (SELECT * > FROM temp_table) t2; > org.apache.spark.sql.AnalysisException > Not allowed to create a permanent view `v7_temp` by referencing a temporary > view `temp_table`; > // In the master, the query below passed, but this should fail > $ CREATE VIEW v8_temp AS SELECT * FROM base_table WHERE EXISTS (SELECT 1 FROM > temp_table); > Passed > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org