[jira] [Commented] (SPARK-30201) HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT
[ https://issues.apache.org/jira/browse/SPARK-30201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208468#comment-17208468 ] Dongjoon Hyun commented on SPARK-30201: --- This lands at `branch-2.4` via https://github.com/apache/spark/pull/29948 > HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT > > > Key: SPARK-30201 > URL: https://issues.apache.org/jira/browse/SPARK-30201 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 2.0.2, 2.1.3, 2.2.3, 2.3.4, 2.4.7, 3.0.0 >Reporter: ulysses you >Assignee: ulysses you >Priority: Critical > Labels: correctness > Fix For: 2.4.8, 3.0.0 > > > Now spark use `ObjectInspectorCopyOption.JAVA` as oi option which will > convert any string to UTF-8 string. When write non UTF-8 code data, then > `EFBFBD` will appear. > We should use `ObjectInspectorCopyOption.DEFAULT` to support pass the bytes. > Here is the way to reproduce: > 1. make a file contains 16 radix 'AABBCC' which is not the UTF-8 code. > 2. create table test1 (c string) location '$file_path'; > 3. select hex(c) from test1; // AABBCC > 4. craete table test2 (c string) as select c from test1; > 5. select hex(c) from test2; // EFBFBDEFBFBDEFBFBD -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-30201) HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT
[ https://issues.apache.org/jira/browse/SPARK-30201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208414#comment-17208414 ] Dongjoon Hyun commented on SPARK-30201: --- I labeled this issue as `correctness` because the query result is wrong. > HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT > > > Key: SPARK-30201 > URL: https://issues.apache.org/jira/browse/SPARK-30201 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 3.0.0 >Reporter: ulysses you >Assignee: ulysses you >Priority: Critical > Labels: correctness > Fix For: 3.0.0 > > > Now spark use `ObjectInspectorCopyOption.JAVA` as oi option which will > convert any string to UTF-8 string. When write non UTF-8 code data, then > `EFBFBD` will appear. > We should use `ObjectInspectorCopyOption.DEFAULT` to support pass the bytes. > Here is the way to reproduce: > 1. make a file contains 16 radix 'AABBCC' which is not the UTF-8 code. > 2. create table test1 (c string) location '$file_path'; > 3. select hex(c) from test1; // AABBCC > 4. craete table test2 (c string) as select c from test1; > 5. select hex(c) from test2; // EFBFBDEFBFBDEFBFBD -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-30201) HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT
[ https://issues.apache.org/jira/browse/SPARK-30201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208389#comment-17208389 ] Anurag Mantripragada commented on SPARK-30201: -- [~cloud_fan], [~ulysses], [~dongjoon] - I verified this issue is present in branch-2.4. Test failure below: {{[info] == Results ==}} {{[info] !== Correct Answer - 1 == == Spark Answer - 1 ==}} {{[info] !struct<> struct}} {{[info] ![AABBCC] [EFBFBDEFBFBDEFBFBD] (QueryTest.scala:163)}} {{[info] org.scalatest.exceptions.TestFailedException:}} I created a PR to backport it to branch 2.4. It was a clean cherry-pick, could you please take a look? Thanks [https://github.com/apache/spark/pull/29948] > HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT > > > Key: SPARK-30201 > URL: https://issues.apache.org/jira/browse/SPARK-30201 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 3.0.0 >Reporter: ulysses you >Assignee: ulysses you >Priority: Critical > Fix For: 3.0.0 > > > Now spark use `ObjectInspectorCopyOption.JAVA` as oi option which will > convert any string to UTF-8 string. When write non UTF-8 code data, then > `EFBFBD` will appear. > We should use `ObjectInspectorCopyOption.DEFAULT` to support pass the bytes. > Here is the way to reproduce: > 1. make a file contains 16 radix 'AABBCC' which is not the UTF-8 code. > 2. create table test1 (c string) location '$file_path'; > 3. select hex(c) from test1; // AABBCC > 4. craete table test2 (c string) as select c from test1; > 5. select hex(c) from test2; // EFBFBDEFBFBDEFBFBD -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-30201) HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT
[ https://issues.apache.org/jira/browse/SPARK-30201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208385#comment-17208385 ] Apache Spark commented on SPARK-30201: -- User 'anuragmantri' has created a pull request for this issue: https://github.com/apache/spark/pull/29948 > HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT > > > Key: SPARK-30201 > URL: https://issues.apache.org/jira/browse/SPARK-30201 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 3.0.0 >Reporter: ulysses you >Assignee: ulysses you >Priority: Critical > Fix For: 3.0.0 > > > Now spark use `ObjectInspectorCopyOption.JAVA` as oi option which will > convert any string to UTF-8 string. When write non UTF-8 code data, then > `EFBFBD` will appear. > We should use `ObjectInspectorCopyOption.DEFAULT` to support pass the bytes. > Here is the way to reproduce: > 1. make a file contains 16 radix 'AABBCC' which is not the UTF-8 code. > 2. create table test1 (c string) location '$file_path'; > 3. select hex(c) from test1; // AABBCC > 4. craete table test2 (c string) as select c from test1; > 5. select hex(c) from test2; // EFBFBDEFBFBDEFBFBD -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-30201) HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT
[ https://issues.apache.org/jira/browse/SPARK-30201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208268#comment-17208268 ] Dongjoon Hyun commented on SPARK-30201: --- Hi, [~ulysses] and [~cloud_fan]. Is this only critical on 3.0.0? > HiveOutputWriter standardOI should use ObjectInspectorCopyOption.DEFAULT > > > Key: SPARK-30201 > URL: https://issues.apache.org/jira/browse/SPARK-30201 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 3.0.0 >Reporter: ulysses you >Assignee: ulysses you >Priority: Critical > Fix For: 3.0.0 > > > Now spark use `ObjectInspectorCopyOption.JAVA` as oi option which will > convert any string to UTF-8 string. When write non UTF-8 code data, then > `EFBFBD` will appear. > We should use `ObjectInspectorCopyOption.DEFAULT` to support pass the bytes. > Here is the way to reproduce: > 1. make a file contains 16 radix 'AABBCC' which is not the UTF-8 code. > 2. create table test1 (c string) location '$file_path'; > 3. select hex(c) from test1; // AABBCC > 4. craete table test2 (c string) as select c from test1; > 5. select hex(c) from test2; // EFBFBDEFBFBDEFBFBD -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org