[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730387#comment-15730387
]
Apache Spark commented on SPARK-3359:
-
User 'michalsenkyr' has created a pull request for this issue:
https://github.com/apache/spark/pull/16201
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730338#comment-15730338
]
Michal Šenkýř commented on SPARK-3359:
--
The build passed. I can put it into a PR if you'd like.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730311#comment-15730311
]
Michal Šenkýř commented on SPARK-3359:
--
Yes, I did do a grep on `[error]`. I am trying to build the docs now with those
`>` replaced by `>` to see if it completes.
I believe it would be worth it to fix. As a newcomer to the Spark community, I
had no idea it was Java 8 related.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730294#comment-15730294
]
Hyukjin Kwon commented on SPARK-3359:
-
I believe you ran {{jekyll build}} and {{grep error}}. If you see the logs, it
says actually only 6(ish) errors about < and > IIRC.
I was not submiting a PR because it might be too minor (including java lint
break).
I can fix both in a single minor PR if it seems worth.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730279#comment-15730279
]
Michal Šenkýř commented on SPARK-3359:
--
Exactly how it's stated in the readme:
cd docs
jekyll build
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730264#comment-15730264
]
Hyukjin Kwon commented on SPARK-3359:
-
Yup, I noticed roughtly 6 errors intdocued in a PR related with {{<}} and
{{>}}. Other errors do not break the build.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730258#comment-15730258
]
Sean Owen commented on SPARK-3359:
--
How are you building?
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
> Fix For: 2.1.1
>
> Attachments: errors.txt
>
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696373#comment-15696373
]
Apache Spark commented on SPARK-3359:
-
User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/16013
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Assignee: Hyukjin Kwon
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692147#comment-15692147
]
Apache Spark commented on SPARK-3359:
-
User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/15999
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680887#comment-15680887
]
Sean Owen commented on SPARK-3359:
--
Current state: lots of PRs over time have removed most errors/warnings, but
still some remain. Getting closer.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679611#comment-15679611
]
Apache Spark commented on SPARK-3359:
-
User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/15939
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673792#comment-15673792
]
Hyukjin Kwon commented on SPARK-3359:
-
Hi [~srowen], It seems I met this issue while trying to build Java API
documentation which I eventually made it with a lower version. I just wonder if
it might be better to note this in
https://github.com/apache/spark/tree/master/docs to prevent the duplicated
efforts I made.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379259#comment-15379259
]
Apache Spark commented on SPARK-3359:
-
User 'srowen' has created a pull request for this issue:
https://github.com/apache/spark/pull/14221
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290934#comment-14290934
]
Apache Spark commented on SPARK-3359:
-
User 'srowen' has created a pull request for this issue:
https://github.com/apache/spark/pull/4193
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181503#comment-14181503
]
Sean Owen commented on SPARK-3359:
--
I inquired about these with the plugin project:
https://github.com/typesafehub/genjavadoc/issues/43
https://github.com/typesafehub/genjavadoc/issues/44
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181494#comment-14181494
]
Apache Spark commented on SPARK-3359:
-
User 'srowen' has created a pull request for this issue:
https://github.com/apache/spark/pull/2909
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181227#comment-14181227
]
Sean Owen commented on SPARK-3359:
--
[~holdenk_amp]'s PR https://github.com/apache/spark/pull/2893 indeed fixes the
immediate problem, thank you.
I find that the generated Java source code's generated javadoc still doesn't
parse as valid javadoc in Java 8. Some are directly fixable and I'll send
another PR with those touch-ups.
Some are just differences between scaladoc and javadoc that the plugin doesn't
quite handle:
@example / @note tags -- unrecognized, probably delete-able without much
effect, but seems like something the plugin could just ignore and pass on the
text as-is in generated Java code.
@group tag -- unrecognized, and may have more value to keep?
@param tag on class arguments -- end up as @param tags on the Java class which
are not valid (well they are for generic types). Should ideally end up as
constructor javadoc.
[[link]] syntax for URLs and methods is not the same and the direct translation
to javadoc doesn't work.
I will request some changes in the plugin to maybe pass on these. But bottom
line is this still won't work to make javadoc from Scala source code in Java 8.
Do we need that? maybe find a way to just javadoc the Java source.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180104#comment-14180104
]
holdenk commented on SPARK-3359:
I think I've got a fix for it, I'll send a PR :)
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178583#comment-14178583
]
Sean Owen commented on SPARK-3359:
--
Sure, but it can be fixed right now too. I tried to figure out how to set
plugin properties in SBT and failed, although, I'm sure it's not a bit hard to
someone who knows how it works.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178316#comment-14178316
]
Prashant Sharma commented on SPARK-3359:
I guess this will happen along with scala 2.11 upgrade. Since the old version
does not work with scala 2.11.
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150778#comment-14150778
]
Sean Owen commented on SPARK-3359:
--
Yeah I noticed this. The problem is that {{sbt-unidoc}} uses {{genjavadoc}},
and it looks like it generates invalid Java like the snippet you quote
(top-level classes can't be private). That's almost all of the extra warnings.
It seems to have been fixed in {{genjavadoc}} 0.8:
https://github.com/typesafehub/genjavadoc/blob/v0.8/plugin/src/main/scala/com/typesafe/genjavadoc/AST.scala#L107
I can see how to update the plugin in the Maven build, but not yet in the SBT
build. If someone who gets SBT can explain how to set
{{unidocGenjavadocVersion}} to "0.8" in the {{genjavadocSettings}} that is
inherited in {{project/SparkBuild.scala}}, I bet that would fix it.
https://github.com/sbt/sbt-unidoc/blob/master/src/main/scala/sbtunidoc/Plugin.scala#L22
> `sbt/sbt unidoc` doesn't work with Java 8
> -
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.1.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
