[jira] [Commented] (SPARK-34541) Fixed an issue where data could not be cleaned up when unregisterShuffle

2021-02-26 Thread Apache Spark (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-34541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291567#comment-17291567
 ] 

Apache Spark commented on SPARK-34541:
--

User 'yikf' has created a pull request for this issue:
https://github.com/apache/spark/pull/31664

> Fixed an issue where data could not be cleaned up when unregisterShuffle
> 
>
> Key: SPARK-34541
> URL: https://issues.apache.org/jira/browse/SPARK-34541
> Project: Spark
>  Issue Type: Bug
>  Components: Spark Core
>Affects Versions: 3.0.0
>Reporter: yikf
>Priority: Minor
>
> While we use the old shuffle fetch protocol, we use partitionId as mapId in 
> the ShuffleBlockId construction,but we use `context.taskAttemptId()` as mapId 
> that it is cached in `taskIdMapsForShuffle` when we `getWriter[K, V]`.
> where data could not be cleaned up when unregisterShuffle ,because we remove 
> a shuffle's metadata from the `taskIdMapsForShuffle`'s mapIds, the mapId is 
> `context.taskAttemptId()` instead of partitionId.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-34541) Fixed an issue where data could not be cleaned up when unregisterShuffle

2021-02-26 Thread Apache Spark (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-34541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291565#comment-17291565
 ] 

Apache Spark commented on SPARK-34541:
--

User 'yikf' has created a pull request for this issue:
https://github.com/apache/spark/pull/31664

> Fixed an issue where data could not be cleaned up when unregisterShuffle
> 
>
> Key: SPARK-34541
> URL: https://issues.apache.org/jira/browse/SPARK-34541
> Project: Spark
>  Issue Type: Bug
>  Components: Spark Core
>Affects Versions: 3.0.0
>Reporter: yikf
>Priority: Minor
>
> While we use the old shuffle fetch protocol, we use partitionId as mapId in 
> the ShuffleBlockId construction,but we use `context.taskAttemptId()` as mapId 
> that it is cached in `taskIdMapsForShuffle` when we `getWriter[K, V]`.
> where data could not be cleaned up when unregisterShuffle ,because we remove 
> a shuffle's metadata from the `taskIdMapsForShuffle`'s mapIds, the mapId is 
> `context.taskAttemptId()` instead of partitionId.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-34541) Fixed an issue where data could not be cleaned up when unregisterShuffle

2021-02-25 Thread Apache Spark (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-34541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290934#comment-17290934
 ] 

Apache Spark commented on SPARK-34541:
--

User 'yikf' has created a pull request for this issue:
https://github.com/apache/spark/pull/31648

> Fixed an issue where data could not be cleaned up when unregisterShuffle
> 
>
> Key: SPARK-34541
> URL: https://issues.apache.org/jira/browse/SPARK-34541
> Project: Spark
>  Issue Type: Bug
>  Components: Spark Core
>Affects Versions: 3.0.0
>Reporter: yikf
>Priority: Minor
> Fix For: 3.0.0
>
>
> While we use the old shuffle fetch protocol, we use partitionId as mapId in 
> the ShuffleBlockId construction,but we use `context.taskAttemptId()` as mapId 
> that it is cached in `taskIdMapsForShuffle` when we `getWriter[K, V]`.
> where data could not be cleaned up when unregisterShuffle ,because we remove 
> a shuffle's metadata from the `taskIdMapsForShuffle`'s mapIds, the mapId is 
> `context.taskAttemptId()` instead of partitionId.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org