[jira] [Commented] (SPARK-3574) Shuffle finish time always reported as -1
[ https://issues.apache.org/jira/browse/SPARK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138330#comment-14138330 ] Apache Spark commented on SPARK-3574: - User 'sryza' has created a pull request for this issue: https://github.com/apache/spark/pull/2440 > Shuffle finish time always reported as -1 > - > > Key: SPARK-3574 > URL: https://issues.apache.org/jira/browse/SPARK-3574 > Project: Spark > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Kay Ousterhout > > shuffleFinishTime is always reported as -1. I think the way we fix this > should be to set the shuffleFinishTime in each ShuffleWriteMetrics as the > shuffles finish, but when aggregating the metrics, only report > shuffleFinishTime as something other than -1 when *all* of the shuffles have > completed. > [~sandyr], it looks like this was introduced in your recent patch to > incrementally report metrics. Any chance you can fix this? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3574) Shuffle finish time always reported as -1
[ https://issues.apache.org/jira/browse/SPARK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138247#comment-14138247 ] Kay Ousterhout commented on SPARK-3574: --- Thanks Sandy!! > Shuffle finish time always reported as -1 > - > > Key: SPARK-3574 > URL: https://issues.apache.org/jira/browse/SPARK-3574 > Project: Spark > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Kay Ousterhout > > shuffleFinishTime is always reported as -1. I think the way we fix this > should be to set the shuffleFinishTime in each ShuffleWriteMetrics as the > shuffles finish, but when aggregating the metrics, only report > shuffleFinishTime as something other than -1 when *all* of the shuffles have > completed. > [~sandyr], it looks like this was introduced in your recent patch to > incrementally report metrics. Any chance you can fix this? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-3574) Shuffle finish time always reported as -1
[ https://issues.apache.org/jira/browse/SPARK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138246#comment-14138246 ] Sandy Ryza commented on SPARK-3574: --- On it > Shuffle finish time always reported as -1 > - > > Key: SPARK-3574 > URL: https://issues.apache.org/jira/browse/SPARK-3574 > Project: Spark > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Kay Ousterhout > > shuffleFinishTime is always reported as -1. I think the way we fix this > should be to set the shuffleFinishTime in each ShuffleWriteMetrics as the > shuffles finish, but when aggregating the metrics, only report > shuffleFinishTime as something other than -1 when *all* of the shuffles have > completed. > [~sandyr], it looks like this was introduced in your recent patch to > incrementally report metrics. Any chance you can fix this? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
