[jira] [Commented] (SPARK-36002) Consolidate tests for data-type-based operations of decimal Series
[ https://issues.apache.org/jira/browse/SPARK-36002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375826#comment-17375826 ] Xinrong Meng commented on SPARK-36002: -- Thank you [~yikunkero]! > Consolidate tests for data-type-based operations of decimal Series > -- > > Key: SPARK-36002 > URL: https://issues.apache.org/jira/browse/SPARK-36002 > Project: Spark > Issue Type: Sub-task > Components: PySpark >Affects Versions: 3.2.0 >Reporter: Xinrong Meng >Priority: Major > > Tests for data-type-based operations of decimal Series are in two places: > * python/pyspark/pandas/tests/data_type_ops/test_decimal_ops.py > * python/pyspark/pandas/tests/data_type_ops/test_num_ops.py > We'd better either merge test_decimal_ops into test_num_ops or keep all tests > related to decimal Series to test_decimal_ops. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-36002) Consolidate tests for data-type-based operations of decimal Series
[ https://issues.apache.org/jira/browse/SPARK-36002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374473#comment-17374473 ] Apache Spark commented on SPARK-36002: -- User 'Yikun' has created a pull request for this issue: https://github.com/apache/spark/pull/33206 > Consolidate tests for data-type-based operations of decimal Series > -- > > Key: SPARK-36002 > URL: https://issues.apache.org/jira/browse/SPARK-36002 > Project: Spark > Issue Type: Sub-task > Components: PySpark >Affects Versions: 3.2.0 >Reporter: Xinrong Meng >Priority: Major > > Tests for data-type-based operations of decimal Series are in two places: > * python/pyspark/pandas/tests/data_type_ops/test_decimal_ops.py > * python/pyspark/pandas/tests/data_type_ops/test_num_ops.py > We'd better either merge test_decimal_ops into test_num_ops or keep all tests > related to decimal Series to test_decimal_ops. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-36002) Consolidate tests for data-type-based operations of decimal Series
[ https://issues.apache.org/jira/browse/SPARK-36002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Yikun Jiang commented on SPARK-36002: - [~XinrongM] I think we can merge test_decimal_ops into test_num_ops, I will submit a PR today. > Consolidate tests for data-type-based operations of decimal Series > -- > > Key: SPARK-36002 > URL: https://issues.apache.org/jira/browse/SPARK-36002 > Project: Spark > Issue Type: Sub-task > Components: PySpark >Affects Versions: 3.2.0 >Reporter: Xinrong Meng >Priority: Major > > Tests for data-type-based operations of decimal Series are in two places: > * python/pyspark/pandas/tests/data_type_ops/test_decimal_ops.py > * python/pyspark/pandas/tests/data_type_ops/test_num_ops.py > We'd better either merge test_decimal_ops into test_num_ops or keep all tests > related to decimal Series to test_decimal_ops. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-36002) Consolidate tests for data-type-based operations of decimal Series
[ https://issues.apache.org/jira/browse/SPARK-36002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373839#comment-17373839 ] Xinrong Meng commented on SPARK-36002: -- How do you think about that? [~yikunkero] > Consolidate tests for data-type-based operations of decimal Series > -- > > Key: SPARK-36002 > URL: https://issues.apache.org/jira/browse/SPARK-36002 > Project: Spark > Issue Type: Sub-task > Components: PySpark >Affects Versions: 3.2.0 >Reporter: Xinrong Meng >Priority: Major > > Tests for data-type-based operations of decimal Series are in two places: > * python/pyspark/pandas/tests/data_type_ops/test_decimal_ops.py > * python/pyspark/pandas/tests/data_type_ops/test_num_ops.py > We'd better either merge test_decimal_ops into test_num_ops or keep all tests > related to decimal Series to test_decimal_ops. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
