[jira] [Commented] (SPARK-36578) Minor UnivariateFeatureSelector API doc improvement

2021-08-26 Thread Apache Spark (Jira) 


[ 
https://issues.apache.org/jira/browse/SPARK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405558#comment-17405558
 ] 

Apache Spark commented on SPARK-36578:
--

User 'huaxingao' has created a pull request for this issue:
https://github.com/apache/spark/pull/33855

> Minor UnivariateFeatureSelector API doc improvement
> ---
>
> Key: SPARK-36578
> URL: https://issues.apache.org/jira/browse/SPARK-36578
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Xiangrui Meng
>Assignee: Huaxin Gao
>Priority: Minor
>
> * The ScalaDoc and Python doc of the UnivariateFeatureSelector starts with 
> "The user can set ...". The first sentence is the ScalaDoc should always 
> describe what this class is.
> * `ANOVATest` is not public. We should just say ANOVA F-test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-36578) Minor UnivariateFeatureSelector API doc improvement

2021-08-24 Thread Huaxin Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/SPARK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404108#comment-17404108
 ] 

Huaxin Gao commented on SPARK-36578:


[~mengxr]I will work on this. Thanks for pinging me.

> Minor UnivariateFeatureSelector API doc improvement
> ---
>
> Key: SPARK-36578
> URL: https://issues.apache.org/jira/browse/SPARK-36578
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Xiangrui Meng
>Assignee: Huaxin Gao
>Priority: Minor
>
> * The ScalaDoc and Python doc of the UnivariateFeatureSelector starts with 
> "The user can set ...". The first sentence is the ScalaDoc should always 
> describe what this class is.
> * `ANOVATest` is not public. We should just say ANOVA F-test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-36578) Minor UnivariateFeatureSelector API doc improvement

2021-08-24 Thread Xiangrui Meng (Jira) 


[ 
https://issues.apache.org/jira/browse/SPARK-36578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404095#comment-17404095
 ] 

Xiangrui Meng commented on SPARK-36578:
---

[~huaxingao] I saw some possible improvement to the API doc. It would be great 
if you can address them when you get some time. Not blocking 3.2 release.

> Minor UnivariateFeatureSelector API doc improvement
> ---
>
> Key: SPARK-36578
> URL: https://issues.apache.org/jira/browse/SPARK-36578
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Affects Versions: 3.1.1, 3.2.0
>Reporter: Xiangrui Meng
>Priority: Minor
>
> * The ScalaDoc and Python doc of the UnivariateFeatureSelector starts with 
> "The user can set ...". The first sentence is the ScalaDoc should always 
> describe what this class is.
> * `ANOVATest` is not public. We should just say ANOVA F-test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org