[jira] [Commented] (SPARK-42572) Logic error for StateStore.validateStateRowFormat

2023-02-26 Thread Apache Spark (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-42572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693835#comment-17693835
 ] 

Apache Spark commented on SPARK-42572:
--

User 'WweiL' has created a pull request for this issue:
https://github.com/apache/spark/pull/40187

> Logic error for StateStore.validateStateRowFormat
> -
>
> Key: SPARK-42572
> URL: https://issues.apache.org/jira/browse/SPARK-42572
> Project: Spark
>  Issue Type: Bug
>  Components: Structured Streaming
>Affects Versions: 3.4.0
>Reporter: Wei Liu
>Priority: Major
>
> SPARK-42484 Changed the logic of whether to check state store format in 
> StateStore.validateStateRowFormat. Revert it and add unit test to make sure 
> this won't happen again



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-42572) Logic error for StateStore.validateStateRowFormat

2023-02-26 Thread Wei Liu (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-42572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693834#comment-17693834
 ] 

Wei Liu commented on SPARK-42572:
-

I'm not very sure what's the true process here..

We should still use some changes in #40073 (especially the logging part)

I've create a PR for the fix: [https://github.com/apache/spark/pull/40187]

But I could also revert it and combine the two PRs if that's the correct flow

> Logic error for StateStore.validateStateRowFormat
> -
>
> Key: SPARK-42572
> URL: https://issues.apache.org/jira/browse/SPARK-42572
> Project: Spark
>  Issue Type: Bug
>  Components: Structured Streaming
>Affects Versions: 3.4.0
>Reporter: Wei Liu
>Priority: Major
>
> SPARK-42484 Changed the logic of whether to check state store format in 
> StateStore.validateStateRowFormat. Revert it and add unit test to make sure 
> this won't happen again



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-42572) Logic error for StateStore.validateStateRowFormat

2023-02-26 Thread Hyukjin Kwon (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-42572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693742#comment-17693742
 ] 

Hyukjin Kwon commented on SPARK-42572:
--

[~WweiL] are you saying that we should revert 
https://github.com/apache/spark/pull/40073? It won't need a new jira for that

> Logic error for StateStore.validateStateRowFormat
> -
>
> Key: SPARK-42572
> URL: https://issues.apache.org/jira/browse/SPARK-42572
> Project: Spark
>  Issue Type: Bug
>  Components: Structured Streaming
>Affects Versions: 3.4.0
>Reporter: Wei Liu
>Priority: Major
>
> SPARK-42484 Changed the logic of whether to check state store format in 
> StateStore.validateStateRowFormat. Revert it and add unit test to make sure 
> this won't happen again



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org