[jira] [Commented] (SPARK-44042) SPIP: PySpark Test Framework

2023-06-21 Thread Amanda Liu (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-44042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735747#comment-17735747
 ] 

Amanda Liu commented on SPARK-44042:


[~ste...@apache.org] thank you for the comment! i agree that test output 
messages are critical here. thanks also for the hadoop-api-shim example, that's 
helpful to look at

> SPIP: PySpark Test Framework
> 
>
> Key: SPARK-44042
> URL: https://issues.apache.org/jira/browse/SPARK-44042
> Project: Spark
>  Issue Type: New Feature
>  Components: PySpark
>Affects Versions: 3.5.0
>Reporter: Amanda Liu
>Priority: Major
>
> Currently, there's no official PySpark test framework, but only various 
> open-source repos and blog posts. Many of these open-source resources are 
> very popular, which demonstrates user-demand for PySpark testing 
> capabilities. 
> [spark-testing-base|https://github.com/holdenk/spark-testing-base] has 1.4k 
> stars, and [chispa|https://github.com/MrPowers/chispa] has 532k 
> downloads/month. However, it can be confusing for users to piece together 
> disparate resources to write their own PySpark tests (see [The Elephant in 
> the Room: How to Write PySpark 
> Tests|https://towardsdatascience.com/the-elephant-in-the-room-how-to-write-pyspark-unit-tests-a5073acabc34]).
>  We can streamline and simplify the testing process by incorporating test 
> features, such as a PySpark Test Base class (which allows tests to share 
> Spark sessions) and test util functions (for example, asserting dataframe and 
> schema equality). Please see the full SPIP document attached: 
> [https://docs.google.com/document/d/1OkyBn3JbEHkkQgSQ45Lq82esXjr9rm2Vj7Ih_4zycRc/edit#heading=h.f5f0u2riv07v].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-44042) SPIP: PySpark Test Framework

2023-06-21 Thread Steve Loughran (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-44042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735646#comment-17735646
 ] 

Steve Loughran commented on SPARK-44042:


* you can create an independent git repo for this (ASF self service) and so 
have a different release timetable and get it out to older versions. 
* This does require testing across versions, but separate modules can do that. 
see https://github.com/apache/hadoop-api-shim for an example. Base module has 
tests, separate mvn module to run those tests against a given version
* testing test runners is fun
* anything which can be done to provide meaningful reports, stack traces, *and 
set a good example to users*  is critical. The design goal should be (for all 
test frameworks, IMO), "does the output report on its own provide enough 
information to diagnose and fix the failure" -the way junit  baseline "assert 
failure at line 308" doesn't

> SPIP: PySpark Test Framework
> 
>
> Key: SPARK-44042
> URL: https://issues.apache.org/jira/browse/SPARK-44042
> Project: Spark
>  Issue Type: New Feature
>  Components: PySpark
>Affects Versions: 3.5.0
>Reporter: Amanda Liu
>Priority: Major
>
> Currently, there's no official PySpark test framework, but only various 
> open-source repos and blog posts. Many of these open-source resources are 
> very popular, which demonstrates user-demand for PySpark testing 
> capabilities. 
> [spark-testing-base|https://github.com/holdenk/spark-testing-base] has 1.4k 
> stars, and [chispa|https://github.com/MrPowers/chispa] has 532k 
> downloads/month. However, it can be confusing for users to piece together 
> disparate resources to write their own PySpark tests (see [The Elephant in 
> the Room: How to Write PySpark 
> Tests|https://towardsdatascience.com/the-elephant-in-the-room-how-to-write-pyspark-unit-tests-a5073acabc34]).
>  We can streamline and simplify the testing process by incorporating test 
> features, such as a PySpark Test Base class (which allows tests to share 
> Spark sessions) and test util functions (for example, asserting dataframe and 
> schema equality). Please see the full SPIP document attached: 
> [https://docs.google.com/document/d/1OkyBn3JbEHkkQgSQ45Lq82esXjr9rm2Vj7Ih_4zycRc/edit#heading=h.f5f0u2riv07v].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org