[jira] [Commented] (SPARK-5296) Predicate Pushdown (BaseRelation) to have an interface that will accept more filters

2015-02-16 Thread Cheng Lian (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322550#comment-14322550
 ] 

Cheng Lian commented on SPARK-5296:
---

Nested AND/OR/NOT filters can be processed in a way very similar to the Parquet 
filter push-down code.

 Predicate Pushdown (BaseRelation) to have an interface that will accept more 
 filters
 

 Key: SPARK-5296
 URL: https://issues.apache.org/jira/browse/SPARK-5296
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Reporter: Corey J. Nolet
Assignee: Cheng Lian
Priority: Critical

 Currently, the BaseRelation API allows a FilteredRelation to handle an 
 Array[Filter] which represents filter expressions that are applied as an AND 
 operator.
 We should support OR operations in a BaseRelation as well. I'm not sure what 
 this would look like in terms of API changes, but it almost seems like a 
 FilteredUnionedScan BaseRelation (the name stinks but you get the idea) would 
 be useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5296) Predicate Pushdown (BaseRelation) to have an interface that will accept more filters

2015-02-16 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322556#comment-14322556
 ] 

Apache Spark commented on SPARK-5296:
-

User 'liancheng' has created a pull request for this issue:
https://github.com/apache/spark/pull/4623

 Predicate Pushdown (BaseRelation) to have an interface that will accept more 
 filters
 

 Key: SPARK-5296
 URL: https://issues.apache.org/jira/browse/SPARK-5296
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Reporter: Corey J. Nolet
Assignee: Cheng Lian
Priority: Critical

 Currently, the BaseRelation API allows a FilteredRelation to handle an 
 Array[Filter] which represents filter expressions that are applied as an AND 
 operator.
 We should support OR operations in a BaseRelation as well. I'm not sure what 
 this would look like in terms of API changes, but it almost seems like a 
 FilteredUnionedScan BaseRelation (the name stinks but you get the idea) would 
 be useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5296) Predicate Pushdown (BaseRelation) to have an interface that will accept OR filters

2015-02-13 Thread Michael Armbrust (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320499#comment-14320499
 ] 

Michael Armbrust commented on SPARK-5296:
-

Oh, good point... We should pass down nested ANDs

 Predicate Pushdown (BaseRelation) to have an interface that will accept OR 
 filters
 --

 Key: SPARK-5296
 URL: https://issues.apache.org/jira/browse/SPARK-5296
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Reporter: Corey J. Nolet
Assignee: Cheng Lian
Priority: Critical

 Currently, the BaseRelation API allows a FilteredRelation to handle an 
 Array[Filter] which represents filter expressions that are applied as an AND 
 operator.
 We should support OR operations in a BaseRelation as well. I'm not sure what 
 this would look like in terms of API changes, but it almost seems like a 
 FilteredUnionedScan BaseRelation (the name stinks but you get the idea) would 
 be useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5296) Predicate Pushdown (BaseRelation) to have an interface that will accept OR filters

2015-02-12 Thread Michael Armbrust (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319642#comment-14319642
 ] 

Michael Armbrust commented on SPARK-5296:
-

As I mentioned on the mailing list, I think you are right about passing down a 
tree.  I would only pass down ORs though, as we already split up ANDs and 
filter/pass them down already implicitly.

 Predicate Pushdown (BaseRelation) to have an interface that will accept OR 
 filters
 --

 Key: SPARK-5296
 URL: https://issues.apache.org/jira/browse/SPARK-5296
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Reporter: Corey J. Nolet

 Currently, the BaseRelation API allows a FilteredRelation to handle an 
 Array[Filter] which represents filter expressions that are applied as an AND 
 operator.
 We should support OR operations in a BaseRelation as well. I'm not sure what 
 this would look like in terms of API changes, but it almost seems like a 
 FilteredUnionedScan BaseRelation (the name stinks but you get the idea) would 
 be useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5296) Predicate Pushdown (BaseRelation) to have an interface that will accept OR filters

2015-01-17 Thread Corey J. Nolet (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281621#comment-14281621
 ] 

Corey J. Nolet commented on SPARK-5296:
---

The more I'm thinking about this- It would be nice if there was a tree pushed 
down for the filters instead of an Array. This is a significant change to the 
API so it would still probably be easiest to create a new class 
(PrunedFilteredTreeScan?).

Probably easiest to have AndFilter and OrFilter parent nodes that can be 
arbitrarily nested with the leaf nodes being the filters that are already used 
(hopefully with the addition of the NotEqualsFilter from SPARK-5306).

 Predicate Pushdown (BaseRelation) to have an interface that will accept OR 
 filters
 --

 Key: SPARK-5296
 URL: https://issues.apache.org/jira/browse/SPARK-5296
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Reporter: Corey J. Nolet

 Currently, the BaseRelation API allows a FilteredRelation to handle an 
 Array[Filter] which represents filter expressions that are applied as an AND 
 operator.
 We should support OR operations in a BaseRelation as well. I'm not sure what 
 this would look like in terms of API changes, but it almost seems like a 
 FilteredUnionedScan BaseRelation (the name stinks but you get the idea) would 
 be useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org