[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282310#comment-14282310
]
Sean Owen commented on SPARK-5315:
--
Agree, but someone may be calling this method and wrapping the result. This
change breaks such a program. It may well be worth it but not obvious. There is
not a good answer. Could also just deprecate it to mark the problem and
workaround.
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282358#comment-14282358
]
Apache Spark commented on SPARK-5315:
-
User 'jerryshao' has created a pull request for this issue:
https://github.com/apache/spark/pull/4104
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282287#comment-14282287
]
Sean Owen commented on SPARK-5315:
--
Ah, yeah that looks like a typo for sure. The other overload of this method in
{{JavaDStreamLike}} returns {{JavaDStream}}. Hm, that would change the API
unfortunately, but I wonder if anyone is relying on it? Of course, callers can
just wrap it in {{JavaDStream}} as an easy workaround.
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282320#comment-14282320
]
Sean Owen commented on SPARK-5315:
--
Oh, that's a good point and good news then. We can add the right method then,
and it will simply be an overload. The existing method can be left and
deprecated.
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282299#comment-14282299
]
Saisai Shao commented on SPARK-5315:
Yes, user can wrap with JavaDStream, but I think it is quite tricky and
un-straightforward for users. Also from my understanding, change this API's
signature is meaningful because the previous one is actually not correct.
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5315) reduceByWindow returns Scala DStream not JavaDStream
[
https://issues.apache.org/jira/browse/SPARK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282703#comment-14282703
]
Jeff Nadler commented on SPARK-5315:
Thanks Jerry! I was just about to file this and you're already done.
reduceByWindow returns Scala DStream not JavaDStream
Key: SPARK-5315
URL: https://issues.apache.org/jira/browse/SPARK-5315
Project: Spark
Issue Type: Bug
Components: Streaming
Affects Versions: 1.2.0
Reporter: Saisai Shao
{code}
def reduceByWindow(
reduceFunc: (T, T) = T,
windowDuration: Duration,
slideDuration: Duration
): DStream[T] = {
dstream.reduceByWindow(reduceFunc, windowDuration, slideDuration)
}
{code}
It should return JavaDStream not DStream for java code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
