[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368744#comment-14368744
]
Apache Spark commented on SPARK-6286:
-
User 'jongyoul' has created a pull request for this issue:
https://github.com/apache/spark/pull/5088
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Assignee: Iulian Dragos
>Priority: Minor
> Labels: mesos
> Fix For: 1.4.0, 1.3.1
>
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358964#comment-14358964
]
Apache Spark commented on SPARK-6286:
-
User 'dragos' has created a pull request for this issue:
https://github.com/apache/spark/pull/5000
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358905#comment-14358905
]
Iulian Dragos commented on SPARK-6286:
--
Sure, I'll issue a PR for handling {{TASK_ERROR => TASK_LOST}}
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358799#comment-14358799
]
Sean Owen commented on SPARK-6286:
--
[~dragos] I think it would be reasonable to handle this like {{TASK_LOST}}. I
agree that there is not a reason to expect Mesos will be downgraded, and the
required version is already required by Spark. This is also a little important
to make sure this message is handled as intended and does not cause an
exception. You want to make the simple PR?
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357310#comment-14357310
]
Iulian Dragos commented on SPARK-6286:
--
Good point. It's been [introduced in
0.21.0|http://mesos.apache.org/blog/mesos-0-21-0-released/]. According to
[pom.xml|https://github.com/apache/spark/blob/master/pom.xml#L119], Spark
depends on `0.21.0`, so it seems safe to handle it. Feel free to close if you
think it's going to break something else.
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358180#comment-14358180
]
Jongyoul Lee commented on SPARK-6286:
-
[~srowen] I saw release note and a new protocol {{TASK_ERROR}} which avoids
falling in infinite loop by making wrong task description. And I agree with you
because this is not compatible with older versions of Mesos, and in case of
spark, {{TASK_ERROR}} occurs rarely - personally, none - because
taskSchedulerImpl makes mesosTask mechanically. However, if you need to code
for {{TASK_ERROR}} to prepare future releases - actually no one wants to
downgrade mesos without any reason -, I think there are two options for dealing
with {{TASK_ERROR}. One is to treat it as same as {{TASK_LOST}}, and another
one is killing this spark application itself because this might be a kind of
system error. I think it's enough to choose the first option for now, and we
make this code compatible with older versions.
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357385#comment-14357385
]
Sean Owen commented on SPARK-6286:
--
Probably OK for 1.4.x. Do you know what to do with this case?
[~jongyoul] do you have an opinion? I think you made the update to 0.21.0.
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-6286) Handle TASK_ERROR in TaskState
[
https://issues.apache.org/jira/browse/SPARK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357240#comment-14357240
]
Sean Owen commented on SPARK-6286:
--
I remember looking at this -- it's a Mesos enum right? I wondered if it were a
new-ish value, and handling it would somehow make the code incompatible with
older versions of Mesos, so I didn't want to touch it. But that is not based on
any real knowledge.
If you know of what to do in this state and confirm that it's not a value
specific to only some supported Mesos versions, then I'd go for it and add a
handler.
> Handle TASK_ERROR in TaskState
> --
>
> Key: SPARK-6286
> URL: https://issues.apache.org/jira/browse/SPARK-6286
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
>Reporter: Iulian Dragos
>Priority: Minor
> Labels: mesos
>
> Scala warning:
> {code}
> match may not be exhaustive. It would fail on the following input: TASK_ERROR
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
