[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583143#comment-14583143 ] Yijie Shen commented on SPARK-7938: --- What's the status of this ticket? Do we still need error prone check in build? Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583191#comment-14583191 ] Yijie Shen commented on SPARK-7938: --- Get it. :) Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583147#comment-14583147 ] Reynold Xin commented on SPARK-7938: Yes. Just super swamped prior to Spark Summit. Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564300#comment-14564300 ] Josh Rosen commented on SPARK-7938: --- If possible, we should also integrate this into our SBT build so that these tests are run in pull request builders. If it's not possible to do that yet (e.g. we'd need to wait for someone to write a SBT plugin), then we can just do Maven for now and leave SBT to future work. Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564292#comment-14564292 ] Yijie Shen commented on SPARK-7938: --- I'd love to take this :) Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565836#comment-14565836 ] Yijie Shen commented on SPARK-7938: --- [~joshrosen] I can't integrate error prone into SBT build because it lacks corresponding SBT plugins at present. Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7938) Use errorprone in Spark
[ https://issues.apache.org/jira/browse/SPARK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565835#comment-14565835 ] Apache Spark commented on SPARK-7938: - User 'yijieshen' has created a pull request for this issue: https://github.com/apache/spark/pull/6515 Use errorprone in Spark --- Key: SPARK-7938 URL: https://issues.apache.org/jira/browse/SPARK-7938 Project: Spark Issue Type: Improvement Components: Build Reporter: Reynold Xin Labels: starter We have quite a bit of low level code written in Java (e.g. unsafe module). One nice thing about Java is that we can use better tools for finding common errors, e.g. Google's error prone. This is a ticket to integrate error pone into our Maven build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
