[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339017#comment-14339017 ] Apache Spark commented on SPARK-794: User 'srowen' has created a pull request for this issue: https://github.com/apache/spark/pull/4793 Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Scheduler Affects Versions: 0.9.0 Reporter: Matei Zaharia Labels: backport-needed Fix For: 1.3.0 This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334765#comment-14334765 ] Sean Owen commented on SPARK-794: - [~joshrosen] would it be OK if I tried my hand at backporting into 1.2? further? Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Scheduler Affects Versions: 0.9.0 Reporter: Matei Zaharia Labels: backport-needed Fix For: 1.3.0 This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334020#comment-14334020 ] Brennon York commented on SPARK-794: [~srowen] [~joshrosen] bump on this. Would assume things are stable with the removal of the sleep method, but want to double check. Thinking we can close this ticket out. Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Scheduler Affects Versions: 0.9.0 Reporter: Matei Zaharia Labels: backport-needed Fix For: 1.3.0 This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292303#comment-14292303 ] Brennon York commented on SPARK-794: [~joshrosen] How is this PR holding up? I haven't seen any issues on the dev board. Think we can close this JIRA ticket? Trying to help prune the JIRA tree :) Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Spark Core Affects Versions: 0.9.0 Reporter: Matei Zaharia Labels: backport-needed Fix For: 1.3.0 This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262468#comment-14262468 ] Josh Rosen commented on SPARK-794: -- It looks like this was added by [~mrid...@yahoo-inc.com] all the way back in 2013: https://github.com/apache/spark/commit/d90d2af1036e909f81cf77c85bfe589993c4f9f3#diff-4e188f32951dc989d97fa7577858bc7cR397 Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Spark Core Affects Versions: 0.9.0 Reporter: Matei Zaharia This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14261681#comment-14261681 ] Apache Spark commented on SPARK-794: User 'brennonyork' has created a pull request for this issue: https://github.com/apache/spark/pull/3851 Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Spark Core Affects Versions: 0.9.0 Reporter: Matei Zaharia This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-794) Remove sleep() in ClusterScheduler.stop
[ https://issues.apache.org/jira/browse/SPARK-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212088#comment-14212088 ] Andrew Ash commented on SPARK-794: -- I don't see a {{ClusterScheduler}} class on master -- was that refactored to {{TaskSchedulerImpl}}? There is still a {{Thread.sleep(1000)}} in that class's {{stop()}} though, which may be what this ticket refers to: https://github.com/apache/spark/blob/1df05a40ebf3493b0aff46d18c0f30d2d5256c7b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L399 Remove sleep() in ClusterScheduler.stop --- Key: SPARK-794 URL: https://issues.apache.org/jira/browse/SPARK-794 Project: Spark Issue Type: Bug Components: Spark Core Affects Versions: 0.9.0 Reporter: Matei Zaharia This temporary change made a while back slows down the unit tests quite a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org