[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593365#comment-14593365 ] Apache Spark commented on SPARK-8356: - User 'BenFradet' has created a pull request for this issue: https://github.com/apache/spark/pull/6902 Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593362#comment-14593362 ] Benjamin Fradet commented on SPARK-8356: I'll create a separate JIRA for harmonizing the naming in UDF-related code: [SPARK-8478|https://issues.apache.org/jira/browse/SPARK-8478]. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590491#comment-14590491 ] Benjamin Fradet commented on SPARK-8356: Somewhat related, about being coherent, there is {{PythonUDF}} and {{ScalaUdf}}. Maybe we should straighten this up as well. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590483#comment-14590483 ] Michael Armbrust commented on SPARK-8356: - Hmm, maybe not. [~rxin] any idea why we have {{callUDF}} at all? It seems like an uglier version of {{udf}} that doesn't handle input type coercion. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590513#comment-14590513 ] Benjamin Fradet commented on SPARK-8356: Ok, I'll make sure Udf disappear, should I open another JIRA or can I add it to the PR for this one? Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590505#comment-14590505 ] Michael Armbrust commented on SPARK-8356: - Sure, (and the convention in spark would be to use UDF), but those are internal APIs so I'm less concerned there. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590478#comment-14590478 ] Benjamin Fradet commented on SPARK-8356: [~marmbrus] Are we sure {{callUDF}} is used for calling Java functions? Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590519#comment-14590519 ] Michael Armbrust commented on SPARK-8356: - Its always better to have smaller more focused PRs from a reviewing standpoint, but if the change is small enough you can lump it into this one. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590521#comment-14590521 ] Benjamin Fradet commented on SPARK-8356: Ok, thanks a lot for your pointers. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8356) Reconcile callUDF and callUdf
[ https://issues.apache.org/jira/browse/SPARK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588579#comment-14588579 ] Benjamin Fradet commented on SPARK-8356: I've started working on this issue. Reconcile callUDF and callUdf - Key: SPARK-8356 URL: https://issues.apache.org/jira/browse/SPARK-8356 Project: Spark Issue Type: Sub-task Components: SQL Reporter: Michael Armbrust Priority: Critical Labels: starter Right now we have two functions {{callUDF}} and {{callUdf}}. I think the former is used for calling Java functions (and the documentation is wrong) and the latter is for calling functions by name. Either way this is confusing and we should unify or pick different names. Also, lets make sure the docs are right. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org