[jira] [Commented] (SPARK-8744) StringIndexerModel should have public constructor
[ https://issues.apache.org/jira/browse/SPARK-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617400#comment-14617400 ] Apache Spark commented on SPARK-8744: - User 'holdenk' has created a pull request for this issue: https://github.com/apache/spark/pull/7267 > StringIndexerModel should have public constructor > - > > Key: SPARK-8744 > URL: https://issues.apache.org/jira/browse/SPARK-8744 > Project: Spark > Issue Type: Improvement > Components: ML >Reporter: Joseph K. Bradley >Priority: Trivial > Labels: starter > Original Estimate: 48h > Remaining Estimate: 48h > > It would be helpful to allow users to pass a pre-computed index to create an > indexer, rather than always going through StringIndexer to create the model. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8744) StringIndexerModel should have public constructor
[ https://issues.apache.org/jira/browse/SPARK-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611057#comment-14611057 ] holdenk commented on SPARK-8744: I could do this, I've got another PR with the StringIndexderModel anyways. > StringIndexerModel should have public constructor > - > > Key: SPARK-8744 > URL: https://issues.apache.org/jira/browse/SPARK-8744 > Project: Spark > Issue Type: Improvement > Components: ML >Reporter: Joseph K. Bradley >Priority: Trivial > Labels: starter > Original Estimate: 48h > Remaining Estimate: 48h > > It would be helpful to allow users to pass a pre-computed index to create an > indexer, rather than always going through StringIndexer to create the model. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8744) StringIndexerModel should have public constructor
[ https://issues.apache.org/jira/browse/SPARK-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610722#comment-14610722 ] Joseph K. Bradley commented on SPARK-8744: -- Good point, I'll link a JIRA for that. Also, there needs to be a constructor which does not require a UID, but generates one automatically. > StringIndexerModel should have public constructor > - > > Key: SPARK-8744 > URL: https://issues.apache.org/jira/browse/SPARK-8744 > Project: Spark > Issue Type: Improvement > Components: ML >Reporter: Joseph K. Bradley >Priority: Trivial > Labels: starter > Original Estimate: 48h > Remaining Estimate: 48h > > It would be helpful to allow users to pass a pre-computed index to create an > indexer. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-8744) StringIndexerModel should have public constructor
[ https://issues.apache.org/jira/browse/SPARK-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610558#comment-14610558 ] yuhao yang commented on SPARK-8744: --- Just a reminder: There seems to be more jobs to do than simply change the access modifiers. Since a passed-in labels will have a larger chance to trigger the "unseen label" exception. Perhaps we should address the exception first. > StringIndexerModel should have public constructor > - > > Key: SPARK-8744 > URL: https://issues.apache.org/jira/browse/SPARK-8744 > Project: Spark > Issue Type: Improvement > Components: ML >Reporter: Joseph K. Bradley >Priority: Trivial > Labels: starter > Original Estimate: 48h > Remaining Estimate: 48h > > It would be helpful to allow users to pass a pre-computed index to create an > indexer. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org