[jira] [Commented] (SPARK-9248) Closing curly-braces should always be on their own line

2015-07-30 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-9248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647512#comment-14647512
 ] 

Apache Spark commented on SPARK-9248:
-

User 'yu-iskw' has created a pull request for this issue:
https://github.com/apache/spark/pull/7795

> Closing curly-braces should always be on their own line
> ---
>
> Key: SPARK-9248
> URL: https://issues.apache.org/jira/browse/SPARK-9248
> Project: Spark
>  Issue Type: Sub-task
>  Components: SparkR
>Reporter: Yu Ishikawa
>Priority: Minor
>
> Closing curly-braces should always be on their own line
> For example,
> {noformat}
> inst/tests/test_sparkSQL.R:606:3: style: Closing curly-braces should always 
> be on their own line, unless it's followed by an else.
>   }, error = function(err) {
>   ^
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-9248) Closing curly-braces should always be on their own line

2015-07-24 Thread Yu Ishikawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-9248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640074#comment-14640074
 ] 

Yu Ishikawa commented on SPARK-9248:


Yeah - sorry for not explaining enough. {{dev/lint-r}} doesn't catch the 
warnings about {{\} else \{}} now. There are a few warnings like above.

> Closing curly-braces should always be on their own line
> ---
>
> Key: SPARK-9248
> URL: https://issues.apache.org/jira/browse/SPARK-9248
> Project: Spark
>  Issue Type: Sub-task
>  Components: SparkR
>Reporter: Yu Ishikawa
>Priority: Minor
>
> Closing curly-braces should always be on their own line
> For example,
> {noformat}
> inst/tests/test_sparkSQL.R:606:3: style: Closing curly-braces should always 
> be on their own line, unless it's followed by an else.
>   }, error = function(err) {
>   ^
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-9248) Closing curly-braces should always be on their own line

2015-07-22 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/SPARK-9248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636757#comment-14636757
 ] 

François Garillot commented on SPARK-9248:
--

Spark uses `} else {` style, though.

> Closing curly-braces should always be on their own line
> ---
>
> Key: SPARK-9248
> URL: https://issues.apache.org/jira/browse/SPARK-9248
> Project: Spark
>  Issue Type: Sub-task
>  Components: SparkR
>Reporter: Yu Ishikawa
>Priority: Minor
>
> Closing curly-braces should always be on their own line



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org