[jira] [Commented] (SPARK-9666) ML 1.5 QA: model save/load audit
[ https://issues.apache.org/jira/browse/SPARK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732235#comment-14732235 ] yuhao yang commented on SPARK-9666: --- Sure. Thanks. > ML 1.5 QA: model save/load audit > > > Key: SPARK-9666 > URL: https://issues.apache.org/jira/browse/SPARK-9666 > Project: Spark > Issue Type: Sub-task > Components: MLlib >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > We should check to make sure no changes broke model import/export in > spark.mllib. > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-9666) ML 1.5 QA: model save/load audit
[ https://issues.apache.org/jira/browse/SPARK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731299#comment-14731299 ] Joseph K. Bradley commented on SPARK-9666: -- Thanks for checking. Shall I mark this complete? > ML 1.5 QA: model save/load audit > > > Key: SPARK-9666 > URL: https://issues.apache.org/jira/browse/SPARK-9666 > Project: Spark > Issue Type: Sub-task > Components: MLlib >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > We should check to make sure no changes broke model import/export in > spark.mllib. > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-9666) ML 1.5 QA: model save/load audit
[ https://issues.apache.org/jira/browse/SPARK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721906#comment-14721906 ] yuhao yang commented on SPARK-9666: --- models have no change in 1.5: LogisticRegressionModel LassoModel SVMModel RidgeRegressionModel NaiveBayesModel LinearRegressionModel DecisionTreeModel MatrixFactorizationModel RandomForestModel GradientBoostedTreesModel > ML 1.5 QA: model save/load audit > > > Key: SPARK-9666 > URL: https://issues.apache.org/jira/browse/SPARK-9666 > Project: Spark > Issue Type: Sub-task > Components: MLlib >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > We should check to make sure no changes broke model import/export in > spark.mllib. > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-9666) ML 1.5 QA: model save/load audit
[ https://issues.apache.org/jira/browse/SPARK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701001#comment-14701001 ] yuhao yang commented on SPARK-9666: --- Tested: save in 1.4 and load in 1.5. checking model update. > ML 1.5 QA: model save/load audit > > > Key: SPARK-9666 > URL: https://issues.apache.org/jira/browse/SPARK-9666 > Project: Spark > Issue Type: Sub-task > Components: MLlib >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > We should check to make sure no changes broke model import/export in > spark.mllib. > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org