[jira] [Commented] (SPARK-9928) LogicalLocalTable in ExistingRDD.scala is not referenced by any code else

2015-11-14 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005525#comment-15005525
 ] 

Apache Spark commented on SPARK-9928:
-

User 'gatorsmile' has created a pull request for this issue:
https://github.com/apache/spark/pull/9717

> LogicalLocalTable in ExistingRDD.scala is not referenced by any code else
> -
>
> Key: SPARK-9928
> URL: https://issues.apache.org/jira/browse/SPARK-9928
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 1.4.1
>Reporter: Gen TANG
>Priority: Trivial
>  Labels: sparksql
>
> The case class 
> [LogicalLocalTable|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala#L118]
>  in 
> [ExistingRDD.scala|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala]
>  is not referenced by anywhere else in the source code. It might be a dead 
> code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-9928) LogicalLocalTable in ExistingRDD.scala is not referenced by any code else

2015-08-12 Thread Gen TANG (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694672#comment-14694672
 ] 

Gen TANG commented on SPARK-9928:
-

I think right now spark use 
[LocalRelation|https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala#L45]
 to create the DataFrame from a local collection. 
As 
[LogicalLocalTable|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala#L118]
 is not used, maybe we should delete it?

> LogicalLocalTable in ExistingRDD.scala is not referenced by any code else
> -
>
> Key: SPARK-9928
> URL: https://issues.apache.org/jira/browse/SPARK-9928
> Project: Spark
>  Issue Type: Question
>  Components: SQL
>Affects Versions: 1.4.1
>Reporter: Gen TANG
>Priority: Minor
>  Labels: sparksql
>
> The case class 
> [LogicalLocalTable|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala#L118]
>  in 
> [ExistingRDD.scala|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala]
>  is not referenced by anywhere else in the source code. It might be a dead 
> code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org