[ https://issues.apache.org/jira/browse/SPARK-24862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyukjin Kwon resolved SPARK-24862. ---------------------------------- Resolution: Incomplete > Spark Encoder is not consistent to scala case class semantic for multiple > argument lists > ---------------------------------------------------------------------------------------- > > Key: SPARK-24862 > URL: https://issues.apache.org/jira/browse/SPARK-24862 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 2.2.1 > Reporter: Antonio Murgia > Priority: Major > Labels: bulk-closed > > Spark Encoder is not consistent to scala case class semantic for multiple > argument lists. > For example if I create a case class with multiple constructor argument lists: > {code:java} > case class Multi(x: String)(y: Int){code} > Scala creates a product with arity 1, while if I apply > {code:java} > Encoders.product[Multi].schema.printTreeString{code} > I get > {code:java} > root > |-- x: string (nullable = true) > |-- y: integer (nullable = false){code} > That is not consistent and leads to: > {code:java} > Error while encoding: java.lang.RuntimeException: Couldn't find y on class > it.enel.next.platform.service.events.common.massive.immutable.Multi > staticinvoke(class org.apache.spark.unsafe.types.UTF8String, StringType, > fromString, assertnotnull(assertnotnull(input[0, > it.enel.next.platform.service.events.common.massive.immutable.Multi, > true])).x, true) AS x#0 > assertnotnull(assertnotnull(input[0, > it.enel.next.platform.service.events.common.massive.immutable.Multi, > true])).y AS y#1 > java.lang.RuntimeException: Error while encoding: java.lang.RuntimeException: > Couldn't find y on class > it.enel.next.platform.service.events.common.massive.immutable.Multi > staticinvoke(class org.apache.spark.unsafe.types.UTF8String, StringType, > fromString, assertnotnull(assertnotnull(input[0, > it.enel.next.platform.service.events.common.massive.immutable.Multi, > true])).x, true) AS x#0 > assertnotnull(assertnotnull(input[0, > it.enel.next.platform.service.events.common.massive.immutable.Multi, > true])).y AS y#1 > at > org.apache.spark.sql.catalyst.encoders.ExpressionEncoder.toRow(ExpressionEncoder.scala:290) > at org.apache.spark.sql.SparkSession$$anonfun$2.apply(SparkSession.scala:464) > at org.apache.spark.sql.SparkSession$$anonfun$2.apply(SparkSession.scala:464) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at scala.collection.immutable.List.foreach(List.scala:392) > at scala.collection.TraversableLike$class.map(TraversableLike.scala:234) > at scala.collection.immutable.List.map(List.scala:296) > at org.apache.spark.sql.SparkSession.createDataset(SparkSession.scala:464) > at > it.enel.next.platform.service.events.common.massive.immutable.ParquetQueueSuite$$anonfun$1.apply$mcV$sp(ParquetQueueSuite.scala:48) > at > it.enel.next.platform.service.events.common.massive.immutable.ParquetQueueSuite$$anonfun$1.apply(ParquetQueueSuite.scala:46) > at > it.enel.next.platform.service.events.common.massive.immutable.ParquetQueueSuite$$anonfun$1.apply(ParquetQueueSuite.scala:46) > at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85) > at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104) > at org.scalatest.Transformer.apply(Transformer.scala:22) > at org.scalatest.Transformer.apply(Transformer.scala:20) > at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682) > at org.scalatest.TestSuite$class.withFixture(TestSuite.scala:196) > at org.scalatest.FlatSpec.withFixture(FlatSpec.scala:1685) > at > org.scalatest.FlatSpecLike$class.invokeWithFixture$1(FlatSpecLike.scala:1679) > at > org.scalatest.FlatSpecLike$$anonfun$runTest$1.apply(FlatSpecLike.scala:1692) > at > org.scalatest.FlatSpecLike$$anonfun$runTest$1.apply(FlatSpecLike.scala:1692) > at org.scalatest.SuperEngine.runTestImpl(Engine.scala:289) > at org.scalatest.FlatSpecLike$class.runTest(FlatSpecLike.scala:1692) > at org.scalatest.FlatSpec.runTest(FlatSpec.scala:1685) > at > org.scalatest.FlatSpecLike$$anonfun$runTests$1.apply(FlatSpecLike.scala:1750) > at > org.scalatest.FlatSpecLike$$anonfun$runTests$1.apply(FlatSpecLike.scala:1750) > at > org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:396) > at > org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:384) > at scala.collection.immutable.List.foreach(List.scala:392) > at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:384) > at > org.scalatest.SuperEngine.org$scalatest$SuperEngine$$runTestsInBranch(Engine.scala:373) > at > org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:410) > at > org.scalatest.SuperEngine$$anonfun$traverseSubNodes$1$1.apply(Engine.scala:384) > at scala.collection.immutable.List.foreach(List.scala:392) > at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:384) > at > org.scalatest.SuperEngine.org$scalatest$SuperEngine$$runTestsInBranch(Engine.scala:379) > at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:461) > at org.scalatest.FlatSpecLike$class.runTests(FlatSpecLike.scala:1750) > at org.scalatest.FlatSpec.runTests(FlatSpec.scala:1685) > at org.scalatest.Suite$class.run(Suite.scala:1147) > at > org.scalatest.FlatSpec.org$scalatest$FlatSpecLike$$super$run(FlatSpec.scala:1685) > at org.scalatest.FlatSpecLike$$anonfun$run$1.apply(FlatSpecLike.scala:1795) > at org.scalatest.FlatSpecLike$$anonfun$run$1.apply(FlatSpecLike.scala:1795) > at org.scalatest.SuperEngine.runImpl(Engine.scala:521) > at org.scalatest.FlatSpecLike$class.run(FlatSpecLike.scala:1795) > at > it.enel.next.platform.service.events.common.massive.immutable.LocalParquetQueueSuite.org$scalatest$BeforeAndAfterAll$$super$run(LocalParquetQueueSuite.scala:8) > at > org.scalatest.BeforeAndAfterAll$class.liftedTree1$1(BeforeAndAfterAll.scala:213) > at org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:210) > at > it.enel.next.platform.service.events.common.massive.immutable.LocalParquetQueueSuite.run(LocalParquetQueueSuite.scala:8) > at org.scalatest.tools.SuiteRunner.run(SuiteRunner.scala:45) > at > org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$1.apply(Runner.scala:1340) > at > org.scalatest.tools.Runner$$anonfun$doRunRunRunDaDoRunRun$1.apply(Runner.scala:1334) > at scala.collection.immutable.List.foreach(List.scala:392) > at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:1334) > at > org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1011) > at > org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1010) > at > org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:1500) > at > org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:1010) > at org.scalatest.tools.Runner$.run(Runner.scala:850) > at org.scalatest.tools.Runner.run(Runner.scala) > at > org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.runScalaTest2(ScalaTestRunner.java:138) > at > org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.main(ScalaTestRunner.java:28) > Caused by: java.lang.RuntimeException: Couldn't find y on class > it.enel.next.platform.service.events.common.massive.immutable.Multi > at scala.sys.package$.error(package.scala:27) > at > org.apache.spark.sql.catalyst.expressions.objects.Invoke.method$lzycompute(objects.scala:199) > at > org.apache.spark.sql.catalyst.expressions.objects.Invoke.method(objects.scala:195) > at > org.apache.spark.sql.catalyst.expressions.objects.Invoke.doGenCode(objects.scala:212) > at > org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$genCode$2.apply(Expression.scala:106) > at > org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$genCode$2.apply(Expression.scala:103) > at scala.Option.getOrElse(Option.scala:121) > at > org.apache.spark.sql.catalyst.expressions.Expression.genCode(Expression.scala:103) > at > org.apache.spark.sql.catalyst.expressions.codegen.CodegenContext$$anonfun$generateExpressions$1.apply(CodeGenerator.scala:849) > at > org.apache.spark.sql.catalyst.expressions.codegen.CodegenContext$$anonfun$generateExpressions$1.apply(CodeGenerator.scala:849) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at scala.collection.immutable.List.foreach(List.scala:392) > at scala.collection.TraversableLike$class.map(TraversableLike.scala:234) > at scala.collection.immutable.List.map(List.scala:296) > at > org.apache.spark.sql.catalyst.expressions.codegen.CodegenContext.generateExpressions(CodeGenerator.scala:849) > at > org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjection$.createCode(GenerateUnsafeProjection.scala:309) > at > org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjection$.create(GenerateUnsafeProjection.scala:373) > at > org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjection$.create(GenerateUnsafeProjection.scala:366) > at > org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjection$.create(GenerateUnsafeProjection.scala:32) > at > org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator.generate(CodeGenerator.scala:930) > at > org.apache.spark.sql.catalyst.encoders.ExpressionEncoder.extractProjection$lzycompute(ExpressionEncoder.scala:263) > at > org.apache.spark.sql.catalyst.encoders.ExpressionEncoder.extractProjection(ExpressionEncoder.scala:263) > at > org.apache.spark.sql.catalyst.encoders.ExpressionEncoder.toRow(ExpressionEncoder.scala:287) > ... 62 more{code} > I think the problem can be tackled working on: > org.apache.spark.sql.catalyst.ScalaReflection#getConstructorParameters, > simply dropping the parameters lists after the first. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org