[jira] [Updated] (SPARK-13583) Remove unused imports and add checkstyle rule
[ https://issues.apache.org/jira/browse/SPARK-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Owen updated SPARK-13583: -- Assignee: Dongjoon Hyun > Remove unused imports and add checkstyle rule > - > > Key: SPARK-13583 > URL: https://issues.apache.org/jira/browse/SPARK-13583 > Project: Spark > Issue Type: Task > Components: Spark Core, Streaming >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > Fix For: 2.0.0 > > > After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review > by saving much time. > This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` > rule to `checkstyle.xml` and fixing all existing unused imports. > {code:title=checkstyle.xml|borderStyle=solid} > + > {code} > Unfortunately, `dev/lint-java` is not tested by Jenkins. ( > https://github.com/apache/spark/blob/master/dev/run-tests.py#L546 ) > This will also help Spark contributors to check by themselves before > submitting their PRs. > According to the [~srowen]'s comments, this PR also includes the removal of > unused imports in Scala code. It will be done by manually because of the > following two reasons. > * Scalastyle does not have `UnusedImport` rule yet. > * Scala 2.11.7 has a bug with `-Ywarn-unused-import` option. > (https://issues.scala-lang.org/browse/SI-9616) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-13583) Remove unused imports and add checkstyle rule
[ https://issues.apache.org/jira/browse/SPARK-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun updated SPARK-13583: -- Summary: Remove unused imports and add checkstyle rule (was: Support `UnusedImports` Java checkstyle rule) > Remove unused imports and add checkstyle rule > - > > Key: SPARK-13583 > URL: https://issues.apache.org/jira/browse/SPARK-13583 > Project: Spark > Issue Type: Task > Components: Spark Core, Streaming >Reporter: Dongjoon Hyun >Priority: Minor > > After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review > by saving much time. > This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` > rule to `checkstyle.xml` and fixing all existing unused imports. > {code:title=checkstyle.xml|borderStyle=solid} > + > {code} > Unfortunately, `dev/lint-java` is not tested by Jenkins. ( > https://github.com/apache/spark/blob/master/dev/run-tests.py#L546 ) > This will also help Spark contributors to check by themselves before > submitting their PRs. > According to the [~srowen]'s comments, this PR also includes the removal of > unused imports in Scala code. It will be done by manually because of the > following two reasons. > * Scalastyle does not have `UnusedImport` rule yet. > * Scala 2.11.7 has a bug with `-Ywarn-unused-import` option. > (https://issues.scala-lang.org/browse/SI-9616) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org