[jira] [Updated] (SPARK-13948) MiMa Check should catch if the visibility change to `private`

2016-03-19 Thread Josh Rosen (JIRA)

 [ 
https://issues.apache.org/jira/browse/SPARK-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Rosen updated SPARK-13948:
---
Assignee: (was: Josh Rosen)

>   MiMa Check should catch if the visibility change to `private`
> --
>
> Key: SPARK-13948
> URL: https://issues.apache.org/jira/browse/SPARK-13948
> Project: Spark
>  Issue Type: Bug
>  Components: Build
>Reporter: Dongjoon Hyun
>Priority: Critical
>
> `GenerateMIMAIgnore.scala` makes `.generated-mima-class-excludes` from the 
> current code having `private` class. As a result, it ignores the case : 
> visibility goes from public into private. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Updated] (SPARK-13948) MiMa Check should catch if the visibility change to `private`

2016-03-19 Thread Josh Rosen (JIRA)

 [ 
https://issues.apache.org/jira/browse/SPARK-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Rosen updated SPARK-13948:
---
Summary:MiMa Check should catch if the visibility change to `private`  
(was: MiMa exclusions should not automatically apply to companion objects)

>   MiMa Check should catch if the visibility change to `private`
> --
>
> Key: SPARK-13948
> URL: https://issues.apache.org/jira/browse/SPARK-13948
> Project: Spark
>  Issue Type: Bug
>  Components: Build
>Reporter: Dongjoon Hyun
>Assignee: Josh Rosen
>Priority: Critical
>
> `GenerateMIMAIgnore.scala` makes `.generated-mima-class-excludes` from the 
> current code having `private` class. As a result, it ignores the case : 
> visibility goes from public into private. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Updated] (SPARK-13948) MiMa Check should catch if the visibility change to `private`

2016-03-19 Thread Josh Rosen (JIRA)

 [ 
https://issues.apache.org/jira/browse/SPARK-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Rosen updated SPARK-13948:
---
Component/s: Project Infra

>   MiMa Check should catch if the visibility change to `private`
> --
>
> Key: SPARK-13948
> URL: https://issues.apache.org/jira/browse/SPARK-13948
> Project: Spark
>  Issue Type: Bug
>  Components: Build, Project Infra
>Reporter: Dongjoon Hyun
>Assignee: Josh Rosen
>Priority: Critical
> Fix For: 2.0.0
>
>
> `GenerateMIMAIgnore.scala` makes `.generated-mima-class-excludes` from the 
> current code having `private` class. As a result, it ignores the case : 
> visibility goes from public into private. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org