[jira] [Updated] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiangrui Meng updated SPARK-15741:
--
Assignee: Bryan Cutler
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Assignee: Bryan Cutler
>Priority: Minor
> Fix For: 2.0.0
>
>
> Several places in PySpark ML have Params._setDefault with a seed param equal
> to {{None}}. This is unnecessary as it will translate to a {{0}} even though
> the param has a fixed value based by on the hashed classname by default.
> Currently, the ALS doc test output depends on this happening and would be
> more clear and stable if it was explicitly set to {{0}}. These should be
> cleaned up for stability and consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiangrui Meng updated SPARK-15741:
--
Target Version/s: 2.0.0
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Assignee: Bryan Cutler
>Priority: Minor
> Fix For: 2.0.0
>
>
> Several places in PySpark ML have Params._setDefault with a seed param equal
> to {{None}}. This is unnecessary as it will translate to a {{0}} even though
> the param has a fixed value based by on the hashed classname by default.
> Currently, the ALS doc test output depends on this happening and would be
> more clear and stable if it was explicitly set to {{0}}. These should be
> cleaned up for stability and consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Cutler updated SPARK-15741:
-
Description: Several places in PySpark ML have Params._setDefault with a
seed param equal to {{None}}. This is unnecessary as it will translate to a
{{0}} even though the param has a fixed value based by on the hashed classname
by default. Currently, the ALS doc test output depends on this happening and
would be more clear and stable if it was explicitly set to {{0}}. These should
be cleaned up for stability and consistency. (was: Calling Params._setDefault
with a param equal to {{None}} will be ignored internally silently. There are
several cases where this is done with the {{seed}} param, making it seem like
it might do something. These cases should be removed for the sake of
consistency.)
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> Several places in PySpark ML have Params._setDefault with a seed param equal
> to {{None}}. This is unnecessary as it will translate to a {{0}} even though
> the param has a fixed value based by on the hashed classname by default.
> Currently, the ALS doc test output depends on this happening and would be
> more clear and stable if it was explicitly set to {{0}}. These should be
> cleaned up for stability and consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-15741) PySpark Cleanup of _setDefault with seed=None
[
https://issues.apache.org/jira/browse/SPARK-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Cutler updated SPARK-15741:
-
Issue Type: Improvement (was: Sub-task)
Parent: (was: SPARK-14771)
> PySpark Cleanup of _setDefault with seed=None
> -
>
> Key: SPARK-15741
> URL: https://issues.apache.org/jira/browse/SPARK-15741
> Project: Spark
> Issue Type: Improvement
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> Calling Params._setDefault with a param equal to {{None}} will be ignored
> internally silently. There are several cases where this is done with the
> {{seed}} param, making it seem like it might do something. These cases
> should be removed for the sake of consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
