[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Sean Owen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Owen updated SPARK-16131:
--
Fix Version/s: (was: 2.0.0)
   2.0.1

> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Assignee: Prajwal Tuladhar
>Priority: Minor
> Fix For: 2.0.1
>
>
> Update logger initialization to use Scala preferred way using `lazy` instead 
> of manual null check.
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Shixiong Zhu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shixiong Zhu updated SPARK-16131:
-
Assignee: Prajwal Tuladhar

> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Assignee: Prajwal Tuladhar
>Priority: Minor
> Fix For: 2.0.0
>
>
> Update logger initialization to use Scala preferred way using `lazy` instead 
> of manual null check.
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Prajwal Tuladhar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prajwal Tuladhar updated SPARK-16131:
-
Description: 
Update logger initialization to use Scala preferred way using `lazy` instead of 
manual null check.

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}

  was:
Update

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}


> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Priority: Minor
>
> Update logger initialization to use Scala preferred way using `lazy` instead 
> of manual null check.
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Prajwal Tuladhar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prajwal Tuladhar updated SPARK-16131:
-
Description: 
Update

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}

  was:
The way log instance inside Logger trait is current being initialized doesn't 
seem to be thread safe [1]. Current implementation only guarantees 
initializeLogIfNecessary() is initialized in lazy.

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}


> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Priority: Minor
>
> Update
> [1] 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50
> This can be written as:
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Prajwal Tuladhar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prajwal Tuladhar updated SPARK-16131:
-
Description: 
The way log instance inside Logger trait is current being initialized doesn't 
seem to be thread safe [1]. Current implementation only guarantees 
initializeLogIfNecessary() is initialized in lazy.

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}

  was:
The way log instance inside Logger trait is current being initialized doesn't 
seem to be thread safe [1]. Current implementation only guarantees 
initializeLogIfNecessary() is initialized in lazy + thread safe way. 

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}


> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Priority: Minor
>
> The way log instance inside Logger trait is current being initialized doesn't 
> seem to be thread safe [1]. Current implementation only guarantees 
> initializeLogIfNecessary() is initialized in lazy.
> [1] 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50
> This can be written as:
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Updated] (SPARK-16131) initialize internal logger lazily instead of manual null check

2016-06-22 Thread Prajwal Tuladhar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SPARK-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prajwal Tuladhar updated SPARK-16131:
-
Description: 
The way log instance inside Logger trait is current being initialized doesn't 
seem to be thread safe [1]. Current implementation only guarantees 
initializeLogIfNecessary() is initialized in lazy + thread safe way. 

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50

This can be written as:

{code}
@transient private lazy val log_ : Logger = {
initializeLogIfNecessary(false)
LoggerFactory.getLogger(logName)
  }
{code}

> initialize internal logger lazily instead of manual null check
> --
>
> Key: SPARK-16131
> URL: https://issues.apache.org/jira/browse/SPARK-16131
> Project: Spark
>  Issue Type: Improvement
>  Components: Spark Core
>Reporter: Prajwal Tuladhar
>Priority: Minor
>
> The way log instance inside Logger trait is current being initialized doesn't 
> seem to be thread safe [1]. Current implementation only guarantees 
> initializeLogIfNecessary() is initialized in lazy + thread safe way. 
> [1] 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44-L50
> This can be written as:
> {code}
> @transient private lazy val log_ : Logger = {
> initializeLogIfNecessary(false)
> LoggerFactory.getLogger(logName)
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org