[jira] [Updated] (SPARK-18728) Consider using Algebird's Aggregator instead of org.apache.spark.sql.expressions.Aggregator
[ https://issues.apache.org/jira/browse/SPARK-18728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hyukjin Kwon updated SPARK-18728: - Labels: bulk-closed (was: ) > Consider using Algebird's Aggregator instead of > org.apache.spark.sql.expressions.Aggregator > --- > > Key: SPARK-18728 > URL: https://issues.apache.org/jira/browse/SPARK-18728 > Project: Spark > Issue Type: Improvement >Reporter: Alex Levenson >Priority: Minor > Labels: bulk-closed > > Mansur (https://twitter.com/mansur_ashraf) pointed out this comment in > spark's Aggregator here: > "Based loosely on Aggregator from Algebird: > https://github.com/twitter/algebird"; > https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala#L46 > Which got a few of us wondering, given that this API is still experimental, > would you consider using algebird's Aggregator API directly instead? > The algebird API is not coupled with any implementation details, and > shouldn't have any extra dependencies. > Are there any blockers to doing that? > Thanks! > Alex -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-18728) Consider using Algebird's Aggregator instead of org.apache.spark.sql.expressions.Aggregator
[ https://issues.apache.org/jira/browse/SPARK-18728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Owen updated SPARK-18728: -- Issue Type: Improvement (was: Bug) I think the questions will be: what does it gain? and what is the cost of introducing a dependency just for this class? > Consider using Algebird's Aggregator instead of > org.apache.spark.sql.expressions.Aggregator > --- > > Key: SPARK-18728 > URL: https://issues.apache.org/jira/browse/SPARK-18728 > Project: Spark > Issue Type: Improvement >Reporter: Alex Levenson >Priority: Minor > > Mansur (https://twitter.com/mansur_ashraf) pointed out this comment in > spark's Aggregator here: > "Based loosely on Aggregator from Algebird: > https://github.com/twitter/algebird"; > https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala#L46 > Which got a few of us wondering, given that this API is still experimental, > would you consider using algebird's Aggregator API directly instead? > The algebird API is not coupled with any implementation details, and > shouldn't have any extra dependencies. > Are there any blockers to doing that? > Thanks! > Alex -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org