[jira] [Updated] (SPARK-19899) FPGrowth input column naming
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph K. Bradley updated SPARK-19899: -- Target Version/s: 2.2.0 > FPGrowth input column naming > > > Key: SPARK-19899 > URL: https://issues.apache.org/jira/browse/SPARK-19899 > Project: Spark > Issue Type: Improvement > Components: ML >Affects Versions: 2.2.0 >Reporter: Maciej Szymkiewicz > > Current implementation extends {{HasFeaturesCol}}. Personally I find it > rather unfortunate. Up to this moment we used consistent conventions - if we > mix-in {{HasFeaturesCol}} the {{featuresCol}} should be {{VectorUDT}}. > Using the same {{Param}} for an {{array}} (and possibly for > {{array}} once {{PrefixSpan}} is ported to {{ml}}) will be > confusing for the users. > I would like to suggest adding new {{trait}} (let's say > {{HasTransactionsCol}}) to clearly indicate that the input type differs for > the other {{Estiamtors}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-19899) FPGrowth input column naming
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph K. Bradley updated SPARK-19899: -- Shepherd: Joseph K. Bradley > FPGrowth input column naming > > > Key: SPARK-19899 > URL: https://issues.apache.org/jira/browse/SPARK-19899 > Project: Spark > Issue Type: Improvement > Components: ML >Affects Versions: 2.2.0 >Reporter: Maciej Szymkiewicz > > Current implementation extends {{HasFeaturesCol}}. Personally I find it > rather unfortunate. Up to this moment we used consistent conventions - if we > mix-in {{HasFeaturesCol}} the {{featuresCol}} should be {{VectorUDT}}. > Using the same {{Param}} for an {{array}} (and possibly for > {{array}} once {{PrefixSpan}} is ported to {{ml}}) will be > confusing for the users. > I would like to suggest adding new {{trait}} (let's say > {{HasTransactionsCol}}) to clearly indicate that the input type differs for > the other {{Estiamtors}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-19899) FPGrowth input column naming
[ https://issues.apache.org/jira/browse/SPARK-19899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Szymkiewicz updated SPARK-19899: --- Description: Current implementation extends {{HasFeaturesCol}}. Personally I find it rather unfortunate. Up to this moment we used consistent conventions - if we mix-in {{HasFeaturesCol}} the {{featuresCol}} should be {{VectorUDT}}. Using the same {{Param}} for an {{array}} (and possibly for {{array}} once {{PrefixSpan}} is ported to {{ml}}) will be confusing for the users. I would like to suggest adding new {{trait}} (let's say {{HasTransactionsCol}}) to clearly indicate that the input type differs for the other {{Estiamtors}}. was: Current implementation extends {{HasFeaturesCol}}. Personally I find it rather unfortunate. Up to these moment we used consistent conventions - if we mix-in {{HasFeaturesCol}} the {{featuresCol}} should be {{VectorUDT}}. Using the same {{Param}} for an {{array}} (and possibly for {{array }} once {{PrefixSpan}} is ported to {{ml}}) will be confusing for the users. I would like to suggest adding new {{trait}} (let's say {{HasTransactionsCol}}) to clearly indicate that the input type differs for the other {{Estiamtors}}. > FPGrowth input column naming > > > Key: SPARK-19899 > URL: https://issues.apache.org/jira/browse/SPARK-19899 > Project: Spark > Issue Type: Improvement > Components: ML >Affects Versions: 2.2.0 >Reporter: Maciej Szymkiewicz > > Current implementation extends {{HasFeaturesCol}}. Personally I find it > rather unfortunate. Up to this moment we used consistent conventions - if we > mix-in {{HasFeaturesCol}} the {{featuresCol}} should be {{VectorUDT}}. > Using the same {{Param}} for an {{array}} (and possibly for > {{array }} once {{PrefixSpan}} is ported to {{ml}}) will be > confusing for the users. > I would like to suggest adding new {{trait}} (let's say > {{HasTransactionsCol}}) to clearly indicate that the input type differs for > the other {{Estiamtors}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org