[jira] [Updated] (SPARK-34702) Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars

2021-03-10 Thread Cheng Su (Jira)


 [ 
https://issues.apache.org/jira/browse/SPARK-34702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheng Su updated SPARK-34702:
-
Parent: SPARK-34706
Issue Type: Sub-task  (was: Improvement)

> Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
> 
>
> Key: SPARK-34702
> URL: https://issues.apache.org/jira/browse/SPARK-34702
> Project: Spark
>  Issue Type: Sub-task
>  Components: SQL
>Affects Versions: 3.2.0
>Reporter: Cheng Su
>Priority: Trivial
>
> As a followup from code review in 
> [https://github.com/apache/spark/pull/31736#discussion_r588134104] , for 
> `JoinCodegenSupport.genBuildSideVars`, we only need to generate build side 
> variables with default values for LEFT OUTER and RIGHT OUTER join, but not 
> for other join types (i.e. LEFT SEMI and LEFT ANTI). Create this Jira to 
> followup clean up the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Updated] (SPARK-34702) Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars

2021-03-10 Thread Cheng Su (Jira)


 [ 
https://issues.apache.org/jira/browse/SPARK-34702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheng Su updated SPARK-34702:
-
Issue Type: Improvement  (was: Bug)

> Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
> 
>
> Key: SPARK-34702
> URL: https://issues.apache.org/jira/browse/SPARK-34702
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 3.2.0
>Reporter: Cheng Su
>Priority: Trivial
>
> As a followup from code review in 
> [https://github.com/apache/spark/pull/31736#discussion_r588134104] , for 
> `JoinCodegenSupport.genBuildSideVars`, we only need to generate build side 
> variables with default values for LEFT OUTER and RIGHT OUTER join, but not 
> for other join types (i.e. LEFT SEMI and LEFT ANTI). Create this Jira to 
> followup clean up the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org