[jira] [Updated] (SPARK-6303) Remove unnecessary Average in GeneratedAggregate
[
https://issues.apache.org/jira/browse/SPARK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Owen updated SPARK-6303:
-
Assignee: Liang-Chi Hsieh
> Remove unnecessary Average in GeneratedAggregate
>
>
> Key: SPARK-6303
> URL: https://issues.apache.org/jira/browse/SPARK-6303
> Project: Spark
> Issue Type: Improvement
> Components: SQL
>Reporter: Liang-Chi Hsieh
>Assignee: Liang-Chi Hsieh
>Priority: Minor
> Fix For: 1.4.0
>
>
> Because {{Average}} is a {{PartialAggregate}}, we never get a {{Average}}
> node when reaching {{HashAggregation}} to prepare {{GeneratedAggregate}}.
> That is why in SQLQuerySuite there is already a test for {{avg}} with
> codegen. And it works.
> But we can find a case in {{GeneratedAggregate}} to deal with {{Average}}.
> Based on the above, we actually never execute this case.
> So we can remove this case from {{GeneratedAggregate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-6303) Remove unnecessary Average in GeneratedAggregate
[
https://issues.apache.org/jira/browse/SPARK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang-Chi Hsieh updated SPARK-6303:
---
Description:
Because {{Average}} is a {{PartialAggregate}}, we never get a {{Average}} node
when reaching {{HashAggregation}} to prepare {{GeneratedAggregate}}.
That is why in SQLQuerySuite there is already a test for {{avg}} with codegen.
And it works.
But we can find a case in {{GeneratedAggregate}} to deal with {{Average}}.
Based on the above, we actually never execute this case.
So we can remove this case from {{GeneratedAggregate}}.
was:Currently canBeCodeGened only checks Sum, Count, Max,
CombineSetsAndCount, CollectHashSet. Average should be in the list too.
> Remove unnecessary Average in GeneratedAggregate
>
>
> Key: SPARK-6303
> URL: https://issues.apache.org/jira/browse/SPARK-6303
> Project: Spark
> Issue Type: Improvement
> Components: SQL
>Reporter: Liang-Chi Hsieh
>Priority: Minor
>
> Because {{Average}} is a {{PartialAggregate}}, we never get a {{Average}}
> node when reaching {{HashAggregation}} to prepare {{GeneratedAggregate}}.
> That is why in SQLQuerySuite there is already a test for {{avg}} with
> codegen. And it works.
> But we can find a case in {{GeneratedAggregate}} to deal with {{Average}}.
> Based on the above, we actually never execute this case.
> So we can remove this case from {{GeneratedAggregate}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Updated] (SPARK-6303) Remove unnecessary Average in GeneratedAggregate
[ https://issues.apache.org/jira/browse/SPARK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang-Chi Hsieh updated SPARK-6303: --- Summary: Remove unnecessary Average in GeneratedAggregate (was: Average should be in canBeCodeGened list) > Remove unnecessary Average in GeneratedAggregate > > > Key: SPARK-6303 > URL: https://issues.apache.org/jira/browse/SPARK-6303 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Liang-Chi Hsieh >Priority: Minor > > Currently canBeCodeGened only checks Sum, Count, Max, CombineSetsAndCount, > CollectHashSet. Average should be in the list too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
