[jira] [Resolved] (STORM-2857) Loosen some constraints on validation to support running topologies of older version
[ https://issues.apache.org/jira/browse/STORM-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2857. - Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~ethanli], I merged into master. > Loosen some constraints on validation to support running topologies of older > version > > > Key: STORM-2857 > URL: https://issues.apache.org/jira/browse/STORM-2857 > Project: Apache Storm > Issue Type: Improvement >Reporter: Ethan Li >Assignee: Ethan Li >Priority: Minor > Labels: pull-request-available > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > We want to be able to have topologies of older version (for example 0.10) to > run on 2.x cluster. User might submit topologies with 0.10 configs which > includes "backtype.storm". It will fail the validation process on the nimbus > because the "backtype.storm.XXX" class not found. For now it's really just > about TOPOLOGY_SCHEDULER_STRATEGY config. We might want to loosen the > constraints for @isImplementationOfClass so that if "backtype.storm.XXX" is > not found, we try with "org.apache.storm.XXX and if it passed, we let it pass > the validation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated STORM-2690:
--
Labels: pull-request-available (was: )
> resurrect invocation of ISupervisor.assigned() & make
> Supervisor.launchDaemon() accessible
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1, 1.1.2, 1.0.5
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
> Labels: pull-request-available
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Weathers updated STORM-2690:
-
Affects Version/s: 1.0.5
1.1.2
> resurrect invocation of ISupervisor.assigned() & make
> Supervisor.launchDaemon() accessible
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1, 1.1.2, 1.0.5
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Weathers updated STORM-2690:
-
Description:
As [discussed in
STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
that change subtly broke the storm-mesos integration framework because of the
removal of the invocation of
[{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
So this ticket is tracking the reinstatement of that invocation from the
supervisor core code.
Also, the
[{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
method of the {{Supervisor}} is not public, so we had to use reflection to
allow calling it from the storm-mesos integration. That should be changed too.
was:
As [discussed in
STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
that change subtly broke the storm-mesos integration framework because of the
removal of the invocation of
[{{ISupervisor.assigned()}}https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
So this ticket is tracking the reinstatement of that invocation from the
supervisor core code.
Also, the
[{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
method of the {{Supervisor}} is not public, so we had to use reflection to
allow calling it from the storm-mesos integration. That should be changed too.
> resurrect invocation of ISupervisor.assigned() & make
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Weathers updated STORM-2690:
-
Summary: resurrect invocation of ISupervisor.assigned() & make
Supervisor.launchDaemon() accessible (was: resurrect invocation of
ISupervisor.assigned() & make )
> resurrect invocation of ISupervisor.assigned() & make
> Supervisor.launchDaemon() accessible
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned()
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Weathers updated STORM-2690:
-
Description:
As [discussed in
STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
that change subtly broke the storm-mesos integration framework because of the
removal of the invocation of
[{{ISupervisor.assigned()}}https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
So this ticket is tracking the reinstatement of that invocation from the
supervisor core code.
Also, the
[{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
method of the {{Supervisor}} is not public, so we had to use reflection to
allow calling it from the storm-mesos integration. That should be changed too.
was:
As [discussed in
STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
that change subtly broke the storm-mesos integration framework because of the
removal of the invocation of {{ISupervisor.assigned()}}.
So this ticket is tracking the reinstatement of that invocation from the
supervisor core code.
Also, the launchDaemon method of the Supervisor is not public, so we had to use
reflection to allow calling it from the storm-mesos integration. That should
be changed too.
> resurrect invocation of ISupervisor.assigned()
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make
[
https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik Weathers updated STORM-2690:
-
Summary: resurrect invocation of ISupervisor.assigned() & make (was:
resurrect invocation of ISupervisor.assigned())
> resurrect invocation of ISupervisor.assigned() & make
> --
>
> Key: STORM-2690
> URL: https://issues.apache.org/jira/browse/STORM-2690
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1
>Reporter: Erik Weathers
>Assignee: Erik Weathers
>Priority: Minor
>
> As [discussed in
> STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307],
> that change subtly broke the storm-mesos integration framework because of
> the removal of the invocation of
> [{{ISupervisor.assigned()}}https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the
> supervisor core code.
> Also, the
> [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248]
> method of the {{Supervisor}} is not public, so we had to use reflection to
> allow calling it from the storm-mesos integration. That should be changed
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (STORM-2854) Expose IEventLogger to make event logging pluggable
[ https://issues.apache.org/jira/browse/STORM-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2854. - Resolution: Fixed Fix Version/s: 1.2.0 2.0.0 Merged into master and 1.x branch. > Expose IEventLogger to make event logging pluggable > --- > > Key: STORM-2854 > URL: https://issues.apache.org/jira/browse/STORM-2854 > Project: Apache Storm > Issue Type: Improvement > Components: storm-client >Reporter: Jungtaek Lim >Assignee: Jungtaek Lim > Labels: pull-request-available > Fix For: 2.0.0, 1.2.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > For the first time, "Event Logger" feature is designed to make implementation > pluggable, so that's why IEventLogger exists, but we didn't have actual use > case other than just writing them to the file at that time, so we just > simplified the case. > Now we have use case which also write events to file, but with awareness of > structure of event so that it can be easily parseable from log feeder. We > would want to have custom IEventLogger to represent event as our own format > in this case. > There's another issue as well: EventInfo has `ts` which stores epoch but it's > defined as String, not long. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
