[jira] [Commented] (STORM-3900) Upgrade Cassandra version to avoid depedency on snakeyaml 1.3

2023-08-10 Thread Bipin Prasad (Jira)


[ 
https://issues.apache.org/jira/browse/STORM-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752834#comment-17752834
 ] 

Bipin Prasad commented on STORM-3900:
-

I can look at those this evening (US time)

On Thu, Aug 10, 2023 at 5:55 AM ASF GitHub Bot (Jira) 



> Upgrade Cassandra version to avoid depedency on snakeyaml 1.3
> -
>
> Key: STORM-3900
> URL: https://issues.apache.org/jira/browse/STORM-3900
> Project: Apache Storm
>  Issue Type: Dependency upgrade
>Reporter: Bipin Prasad
>Priority: Major
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Snakeyaml 1.3 has a security vulnerability. Cassandra version is storm has 
> pulls in this version. Upgrade Cassandra to a version that uses snakeyaml 2.0.
> See Storm snakeyaml 2.0 upgrade in PR: 
> https://github.com/apache/storm/pull/3523



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (STORM-3945) Upgrade Zookeeper to 3.9.0 / Curator 5

2023-08-10 Thread Richard Zowalla (Jira)


 [ 
https://issues.apache.org/jira/browse/STORM-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Zowalla closed STORM-3945.
--
Resolution: Fixed

> Upgrade Zookeeper to 3.9.0 / Curator 5
> --
>
> Key: STORM-3945
> URL: https://issues.apache.org/jira/browse/STORM-3945
> Project: Apache Storm
>  Issue Type: Task
>Affects Versions: 2.5.0
>Reporter: Richard Zowalla
>Assignee: Richard Zowalla
>Priority: Major
> Fix For: 2.6.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently used Zookeeper version is EOL. 
> We should upgrade to a more modern version of the 3.x series, i.e. 3.8.x
> Note: This also involves to update Curator to 5.x, which will remove 
> exhibitor support: https://curator.apache.org/breaking-changes.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (STORM-3925) Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-08-10 Thread Richard Zowalla (Jira)


 [ 
https://issues.apache.org/jira/browse/STORM-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Zowalla closed STORM-3925.
--

> Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
> -
>
> Key: STORM-3925
> URL: https://issues.apache.org/jira/browse/STORM-3925
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-core
>Reporter: Bharat Gulati
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The current implementation of WorkerTopologyContext in WorkerState will 
> always lead to empty userResources as no interface exposes a way to allow 
> user to set them.
> {code:java}
>     private Map makeUserResources() {
>         /* TODO: need to invoke a hook provided by the topology, giving it a 
> chance to create user resources.
>          * this would be part of the initialization hook
>          * need to separate workertopologycontext into WorkerContext and 
> WorkerUserContext.
>          * actually just do it via interfaces. just need to make sure to hide 
> setResource from tasks
>          */
>         return new HashMap<>();
>     } {code}
> The intention will be to expose the relevant methods under a separate class 
> which can then allow users to set the resources from WorkerHooks while only 
> providing get access from Tasks (i.e. via TopologyContext)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (STORM-3945) Upgrade Zookeeper to 3.9.0 / Curator 5

2023-08-10 Thread Richard Zowalla (Jira)


 [ 
https://issues.apache.org/jira/browse/STORM-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Zowalla updated STORM-3945:
---
Summary: Upgrade Zookeeper to 3.9.0 / Curator 5  (was: Upgrade Zookeeper to 
3.8.2 / Curator 5)

> Upgrade Zookeeper to 3.9.0 / Curator 5
> --
>
> Key: STORM-3945
> URL: https://issues.apache.org/jira/browse/STORM-3945
> Project: Apache Storm
>  Issue Type: Task
>Affects Versions: 2.5.0
>Reporter: Richard Zowalla
>Assignee: Richard Zowalla
>Priority: Major
> Fix For: 2.6.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently used Zookeeper version is EOL. 
> We should upgrade to a more modern version of the 3.x series, i.e. 3.8.x
> Note: This also involves to update Curator to 5.x, which will remove 
> exhibitor support: https://curator.apache.org/breaking-changes.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (STORM-3800) Fix Resocue leak due to Files.list and Files.walk

2023-08-10 Thread Richard Zowalla (Jira)


 [ 
https://issues.apache.org/jira/browse/STORM-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Zowalla closed STORM-3800.
--
Fix Version/s: 2.6.0
 Assignee: (was: Bipin Prasad)
   Resolution: Fixed

> Fix Resocue leak due to Files.list and Files.walk
> -
>
> Key: STORM-3800
> URL: https://issues.apache.org/jira/browse/STORM-3800
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: lujie
>Priority: Major
> Fix For: 2.6.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Files.list and Files.walk will open dir stream, we should close it.
>  
> see jdk:
> the {[@code|https://github.com/code] try}-with-resources construct should be 
> used to ensure that the
> stream's {[@link|https://github.com/link] Stream#close close} method is 
> invoked after the stream
> operations are completed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (STORM-3925) Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-08-10 Thread Julien Nioche (Jira)


 [ 
https://issues.apache.org/jira/browse/STORM-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julien Nioche resolved STORM-3925.
--
Resolution: Fixed

> Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
> -
>
> Key: STORM-3925
> URL: https://issues.apache.org/jira/browse/STORM-3925
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-core
>Reporter: Bharat Gulati
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The current implementation of WorkerTopologyContext in WorkerState will 
> always lead to empty userResources as no interface exposes a way to allow 
> user to set them.
> {code:java}
>     private Map makeUserResources() {
>         /* TODO: need to invoke a hook provided by the topology, giving it a 
> chance to create user resources.
>          * this would be part of the initialization hook
>          * need to separate workertopologycontext into WorkerContext and 
> WorkerUserContext.
>          * actually just do it via interfaces. just need to make sure to hide 
> setResource from tasks
>          */
>         return new HashMap<>();
>     } {code}
> The intention will be to expose the relevant methods under a separate class 
> which can then allow users to set the resources from WorkerHooks while only 
> providing get access from Tasks (i.e. via TopologyContext)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)