[jira] [Updated] (STORM-3143) Unnecessary inclusion of empty match result in Json
[ https://issues.apache.org/jira/browse/STORM-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated STORM-3143: -- Labels: pull-request-available (was: ) > Unnecessary inclusion of empty match result in Json > --- > > Key: STORM-3143 > URL: https://issues.apache.org/jira/browse/STORM-3143 > Project: Apache Storm > Issue Type: Bug > Components: storm-webapp >Affects Versions: 2.0.0 >Reporter: Zhengdai Hu >Assignee: Zhengdai Hu >Priority: Major > Labels: pull-request-available > Fix For: 2.0.0 > > > `FindNMatches()` didn't correctly filter out empty match result in > `substringSearch()` and hence send back an empty map to user. I don't know if > this the desired behavior but a fix to current behavior will make metrics for > logviewer easier to implement. > An example of current behavior: > {code:json} > { > "fileOffset": 1, > "searchString": "sdf", > "matches": [ > { > "searchString": "sdf", > "fileName": "word-count-1-1530815972/6701/worker.log", > "matches": [], > "port": "6701", > "isDaemon": "no", > "startByteOffset": 0 > } > ] > } > {code} > Desired behavior: > {code:json} > { > "fileOffset": 1, > "searchString": "sdf", > "matches": [] > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (STORM-3143) Unnecessary inclusion of empty match result in Json
[ https://issues.apache.org/jira/browse/STORM-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhengdai Hu updated STORM-3143: --- Summary: Unnecessary inclusion of empty match result in Json (was: Unnecessary inclusion of empty string match result in Json) > Unnecessary inclusion of empty match result in Json > --- > > Key: STORM-3143 > URL: https://issues.apache.org/jira/browse/STORM-3143 > Project: Apache Storm > Issue Type: Bug > Components: storm-webapp >Affects Versions: 2.0.0 >Reporter: Zhengdai Hu >Assignee: Zhengdai Hu >Priority: Major > Fix For: 2.0.0 > > > `FindNMatches()` didn't correctly filter out empty match result in > `substringSearch()` and hence send back an empty map to user. I don't know if > this the desired behavior but a fix to current behavior will make metrics for > logviewer easier to implement. > An example of current behavior: > {code:json} > { > "fileOffset": 1, > "searchString": "sdf", > "matches": [ > { > "searchString": "sdf", > "fileName": "word-count-1-1530815972/6701/worker.log", > "matches": [], > "port": "6701", > "isDaemon": "no", > "startByteOffset": 0 > } > ] > } > {code} > Desired behavior: > {code:json} > { > "fileOffset": 1, > "searchString": "sdf", > "matches": [] > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)