[jira] [Updated] (WW-4301) includeProperties Does Not Work with a List of Lists
[
https://issues.apache.org/jira/browse/WW-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4301:
--
Description:
I found this issue when using server-side processing with JQuery Datatables and
attempting to populate.
Say I have this getter/field on my action:
{code:java}
public ListListString getListOfLists() {
return listOfLists;
}
{code}
My struts.xml is defined as follows:
{code:xml}
action name=GetData method=loadData
class=com.example.web.action.WebAction
result type=json
param name=ignoreHierarchyfalse/param
param
name=includePropertieslistOfLists\[\d+\]\[\d+\]/param
/result
/action
{code}
However, the include patterns that are constructed within JSONUtil are not
accurate. Instead of making the expected pattern that would work:
{noformat}
listOfLists
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
{noformat}
Only the following are created:
{noformat}
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
{noformat}
Because the first listOfLists is not created, the property is excluded in the
results.
This all happens because of line 463 in JSONUtil:
{code:java}
addPattern(results, patternExpr.substring(0,
patternExpr.lastIndexOf(includePatternData.get(ARRAY_BEGIN_STRING).get(type))),
type);
{code}
Since we're going at the last index of the ARRAY_BEGIN_STRING string, it's
skipping the first index. This could be updated to be smarter to build the
include patterns as expected.
was:
I found this issue when using server-side processing with JQuery Datatables and
attempting to populate.
Say I have this getter/field on my action:
public ListListString getListOfLists() {
return listOfLists;
}
My struts.xml is defined as follows:
action name=GetData method=loadData
class=com.example.web.action.WebAction
result type=json
param name=ignoreHierarchyfalse/param
param
name=includePropertieslistOfLists\[\d+\]\[\d+\]/param
/result
/action
However, the include patterns that are constructed within JSONUtil are not
accurate. Instead of making the expected pattern that would work:
listOfLists
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
Only the following are created:
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
Because the first listOfLists is not created, the property is excluded in the
results.
This all happens because of line 463 in JSONUtil:
addPattern(results, patternExpr.substring(0,
patternExpr.lastIndexOf(includePatternData.get(ARRAY_BEGIN_STRING).get(type))),
type);
Since we're going at the last index of the ARRAY_BEGIN_STRING string, it's
skipping the first index. This could be updated to be smarter to build the
include patterns as expected.
includeProperties Does Not Work with a List of Lists
Key: WW-4301
URL: https://issues.apache.org/jira/browse/WW-4301
Project: Struts 2
Issue Type: Bug
Components: Plugin - JSON
Affects Versions: 2.3.16
Reporter: Andrew Bernhagen
Priority: Minor
Labels: json
Fix For: 2.3.x
Original Estimate: 24h
Remaining Estimate: 24h
I found this issue when using server-side processing with JQuery Datatables
and attempting to populate.
Say I have this getter/field on my action:
{code:java}
public ListListString getListOfLists() {
return listOfLists;
}
{code}
My struts.xml is defined as follows:
{code:xml}
action name=GetData method=loadData
class=com.example.web.action.WebAction
result type=json
param name=ignoreHierarchyfalse/param
param
name=includePropertieslistOfLists\[\d+\]\[\d+\]/param
/result
/action
{code}
However, the include patterns that are constructed within JSONUtil are not
accurate. Instead of making the expected pattern that would work:
{noformat}
listOfLists
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
{noformat}
Only the following are created:
{noformat}
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
{noformat}
Because the first listOfLists is not created, the property is excluded in
the results.
This all happens because of line 463 in JSONUtil:
{code:java}
addPattern(results, patternExpr.substring(0,
patternExpr.lastIndexOf(includePatternData.get(ARRAY_BEGIN_STRING).get(type))),
type);
{code}
Since we're going at the last index of the ARRAY_BEGIN_STRING string, it's
skipping the first index. This could be updated to be smarter to build the
include patterns as expected.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (WW-4301) includeProperties Does Not Work with a List of Lists
[
https://issues.apache.org/jira/browse/WW-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4301:
--
Fix Version/s: 2.3.x
includeProperties Does Not Work with a List of Lists
Key: WW-4301
URL: https://issues.apache.org/jira/browse/WW-4301
Project: Struts 2
Issue Type: Bug
Components: Plugin - JSON
Affects Versions: 2.3.16
Reporter: Andrew Bernhagen
Priority: Minor
Labels: json
Fix For: 2.3.x
Original Estimate: 24h
Remaining Estimate: 24h
I found this issue when using server-side processing with JQuery Datatables
and attempting to populate.
Say I have this getter/field on my action:
public ListListString getListOfLists() {
return listOfLists;
}
My struts.xml is defined as follows:
action name=GetData method=loadData
class=com.example.web.action.WebAction
result type=json
param name=ignoreHierarchyfalse/param
param
name=includePropertieslistOfLists\[\d+\]\[\d+\]/param
/result
/action
However, the include patterns that are constructed within JSONUtil are not
accurate. Instead of making the expected pattern that would work:
listOfLists
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
Only the following are created:
listOfLists\[\d+\]
listOfLists\[\d+\]\[\d+\]
Because the first listOfLists is not created, the property is excluded in
the results.
This all happens because of line 463 in JSONUtil:
addPattern(results, patternExpr.substring(0,
patternExpr.lastIndexOf(includePatternData.get(ARRAY_BEGIN_STRING).get(type))),
type);
Since we're going at the last index of the ARRAY_BEGIN_STRING string, it's
skipping the first index. This could be updated to be smarter to build the
include patterns as expected.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (WW-4198) Template form-close-validate.ftl incompatible with URLValidator
[
https://issues.apache.org/jira/browse/WW-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4198.
---
Resolution: Fixed
URLValidator extended, thanks for reporting!
Template form-close-validate.ftl incompatible with URLValidator
---
Key: WW-4198
URL: https://issues.apache.org/jira/browse/WW-4198
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.15, 2.3.15.1
Reporter: Bruno Klava
Assignee: Lukasz Lenart
Fix For: 2.3.17
In Struts 2.3.15 the form-close-validate.ftl template was updated to use the
regex field, but there is no such field in
com.opensymphony.xwork2.validator.annotations.UrlValidator neither a default
value for it in com.opensymphony.xwork2.validator.validators.URLValidator
(like is done in com.opensymphony.xwork2.validator.validators.EmailValidator).
---
{noformat}
HTTP Status 500 - Expression validator.regex is undefined on line 123, column
106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
type Exception report
message Expression validator.regex is undefined on line 123, column 106 in
template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
description The server encountered an internal error that prevented it from
fulfilling this request.
{noformat}
exception
{noformat}
org.apache.jasper.JasperException: Expression validator.regex is undefined on
line 123, column 106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
File: TemplateObject.java
Method: assertNonNull
Line: 125 - freemarker/core/TemplateObject.java:125:-1
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:472)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:96)
org.apache.struts2.dispatcher.ServletDispatcherResult.doExecute(ServletDispatcherResult.java:164)
org.apache.struts2.dispatcher.StrutsResultSupport.execute(StrutsResultSupport.java:186)
com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:371)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:275)
org.apache.struts2.interceptor.debugging.DebuggingInterceptor.intercept(DebuggingInterceptor.java:256)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor.doIntercept(DefaultWorkflowInterceptor.java:167)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:265)
org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:68)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
org.apache.struts2.interceptor.MultiselectInterceptor.intercept(MultiselectInterceptor.java:73)
[jira] [Commented] (WW-4198) Template form-close-validate.ftl incompatible with URLValidator
[
https://issues.apache.org/jira/browse/WW-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933606#comment-13933606
]
ASF subversion and git services commented on WW-4198:
-
Commit aa744b811f9c41b80cc30ad6cf41ccaa75da5323 in struts's branch
refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=aa744b8 ]
WW-4198 Merges changes to develop
Template form-close-validate.ftl incompatible with URLValidator
---
Key: WW-4198
URL: https://issues.apache.org/jira/browse/WW-4198
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.15, 2.3.15.1
Reporter: Bruno Klava
Assignee: Lukasz Lenart
Fix For: 2.3.17
In Struts 2.3.15 the form-close-validate.ftl template was updated to use the
regex field, but there is no such field in
com.opensymphony.xwork2.validator.annotations.UrlValidator neither a default
value for it in com.opensymphony.xwork2.validator.validators.URLValidator
(like is done in com.opensymphony.xwork2.validator.validators.EmailValidator).
---
{noformat}
HTTP Status 500 - Expression validator.regex is undefined on line 123, column
106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
type Exception report
message Expression validator.regex is undefined on line 123, column 106 in
template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
description The server encountered an internal error that prevented it from
fulfilling this request.
{noformat}
exception
{noformat}
org.apache.jasper.JasperException: Expression validator.regex is undefined on
line 123, column 106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
File: TemplateObject.java
Method: assertNonNull
Line: 125 - freemarker/core/TemplateObject.java:125:-1
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:472)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:96)
org.apache.struts2.dispatcher.ServletDispatcherResult.doExecute(ServletDispatcherResult.java:164)
org.apache.struts2.dispatcher.StrutsResultSupport.execute(StrutsResultSupport.java:186)
com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:371)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:275)
org.apache.struts2.interceptor.debugging.DebuggingInterceptor.intercept(DebuggingInterceptor.java:256)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor.doIntercept(DefaultWorkflowInterceptor.java:167)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:265)
org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:68)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191)
[jira] [Commented] (WW-4198) Template form-close-validate.ftl incompatible with URLValidator
[
https://issues.apache.org/jira/browse/WW-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933612#comment-13933612
]
ASF GitHub Bot commented on WW-4198:
Github user lukaszlenart closed the pull request at:
https://github.com/apache/struts/pull/3
Template form-close-validate.ftl incompatible with URLValidator
---
Key: WW-4198
URL: https://issues.apache.org/jira/browse/WW-4198
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.3.15, 2.3.15.1
Reporter: Bruno Klava
Assignee: Lukasz Lenart
Fix For: 2.3.17
In Struts 2.3.15 the form-close-validate.ftl template was updated to use the
regex field, but there is no such field in
com.opensymphony.xwork2.validator.annotations.UrlValidator neither a default
value for it in com.opensymphony.xwork2.validator.validators.URLValidator
(like is done in com.opensymphony.xwork2.validator.validators.EmailValidator).
---
{noformat}
HTTP Status 500 - Expression validator.regex is undefined on line 123, column
106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
type Exception report
message Expression validator.regex is undefined on line 123, column 106 in
template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
description The server encountered an internal error that prevented it from
fulfilling this request.
{noformat}
exception
{noformat}
org.apache.jasper.JasperException: Expression validator.regex is undefined on
line 123, column 106 in template/xhtml/form-close-validate.ftl. - Class:
freemarker.core.TemplateObject
File: TemplateObject.java
Method: assertNonNull
Line: 125 - freemarker/core/TemplateObject.java:125:-1
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:472)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:96)
org.apache.struts2.dispatcher.ServletDispatcherResult.doExecute(ServletDispatcherResult.java:164)
org.apache.struts2.dispatcher.StrutsResultSupport.execute(StrutsResultSupport.java:186)
com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:371)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:275)
org.apache.struts2.interceptor.debugging.DebuggingInterceptor.intercept(DebuggingInterceptor.java:256)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor.doIntercept(DefaultWorkflowInterceptor.java:167)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:265)
org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:68)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:239)
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191)
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:246)
[jira] [Updated] (WW-4228) OGNL Basic: if AllowStaticMethodAccess is set to true, JSP fragments included with jsp:include/ can access Action members, otherwise they can't.
[
https://issues.apache.org/jira/browse/WW-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4228:
--
Fix Version/s: (was: 2.3.17)
2.3.x
OGNL Basic: if AllowStaticMethodAccess is set to true, JSP fragments included
with jsp:include/ can access Action members, otherwise they can't.
--
Key: WW-4228
URL: https://issues.apache.org/jira/browse/WW-4228
Project: Struts 2
Issue Type: Improvement
Components: Documentation
Environment: JBOSS EAP 6.01, Struts 2.3.15.2
Reporter: Andrea Ligios
Priority: Trivial
Labels: include, jsp, ognl
Fix For: 2.3.x
Trying to call an Action's getter from an included JSP, I get null:
{code:title=MyAction.java|borderStyle=solid}
private String message = The message I want to read...;
public String getMessage() {
return message;
}
{code}
{code:title=main.jsp|borderStyle=solid}
%@taglib prefix=s uri=/struts-tags %
html
head/head
body
div I'm a DIV in main.jsp /div
jsp:include page=fragment.jsp /
body
/html
{code}
{code:title=fragment.jsp|borderStyle=solid}
%@taglib prefix=s uri=/struts-tags %
div
I'm a DIV from fragment.jsp
br/
Message from Action: s:property value=message /
/div
{code}
If I set:
{code:title=struts.xml|borderStyle=solid}
constant name=struts.ognl.allowStaticMethodAccess value=true/
{code}
the getter is now reachable.
This applies only to jsp:include ; with s:include, the getter is ALWAYS
reachable.
Seems to be some kind of side effect, maybe it should be verified and added
to the documentation. [Originally posted
here.|http://stackoverflow.com/q/19425754/1654265]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (WW-4267) When devMode is enabled via CustomConfigProvider it is not possible to enable reloading automatically
[ https://issues.apache.org/jira/browse/WW-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart reassigned WW-4267: - Assignee: Lukasz Lenart When devMode is enabled via CustomConfigProvider it is not possible to enable reloading automatically - Key: WW-4267 URL: https://issues.apache.org/jira/browse/WW-4267 Project: Struts 2 Issue Type: Bug Components: XML Configuration Affects Versions: 2.3.16 Reporter: Christoph Nenning Assignee: Lukasz Lenart Priority: Trivial Fix For: 2.3.17 When devMode is enbaled the framework used to enable some other debug options per default, like reloading of config and resources. In 2.3.16 that was changed to be able to have devMode without all of those other options. The reason for that are performance issues with freemarker debug options. A side effect of that is that automatic enablement of reloading does not work anymore when devMode is enabled via a CustomConfigProvider. To fix that default settings in default.properties can be outcommented. That way it does not take effect at runtime but is still present for developers to read the file. These properties are affected: - struts.i18n.reload - struts.configuration.xml.reload - struts.freemarker.templatesCache - struts.freemarker.templatesCache.updateDelay -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4267) When devMode is enabled via CustomConfigProvider it is not possible to enable reloading automatically
[ https://issues.apache.org/jira/browse/WW-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933803#comment-13933803 ] Lukasz Lenart commented on WW-4267: --- Changes are here https://git-wip-us.apache.org/repos/asf?p=struts.git;a=shortlog;h=refs/heads/feature/WW-4267-removes-defaults When devMode is enabled via CustomConfigProvider it is not possible to enable reloading automatically - Key: WW-4267 URL: https://issues.apache.org/jira/browse/WW-4267 Project: Struts 2 Issue Type: Bug Components: XML Configuration Affects Versions: 2.3.16 Reporter: Christoph Nenning Assignee: Lukasz Lenart Priority: Trivial Fix For: 2.3.17 When devMode is enbaled the framework used to enable some other debug options per default, like reloading of config and resources. In 2.3.16 that was changed to be able to have devMode without all of those other options. The reason for that are performance issues with freemarker debug options. A side effect of that is that automatic enablement of reloading does not work anymore when devMode is enabled via a CustomConfigProvider. To fix that default settings in default.properties can be outcommented. That way it does not take effect at runtime but is still present for developers to read the file. These properties are affected: - struts.i18n.reload - struts.configuration.xml.reload - struts.freemarker.templatesCache - struts.freemarker.templatesCache.updateDelay -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4074) Prepare sample OSGi application
[ https://issues.apache.org/jira/browse/WW-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4074: -- Fix Version/s: (was: 2.3.17) 2.3.x Prepare sample OSGi application --- Key: WW-4074 URL: https://issues.apache.org/jira/browse/WW-4074 Project: Struts 2 Issue Type: New Feature Components: Example Applications Reporter: Lukasz Lenart Priority: Trivial Fix For: 2.3.x As the Struts 2 OSGi plugin was upgraded it would be nice to have a sample application, please refer to WW-3958 for more details -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4166) Allow class attribute on Struts tags
[ https://issues.apache.org/jira/browse/WW-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4166: -- Fix Version/s: (was: 2.3.17) 2.3.x Allow class attribute on Struts tags -- Key: WW-4166 URL: https://issues.apache.org/jira/browse/WW-4166 Project: Struts 2 Issue Type: Improvement Components: Other Reporter: Eric Lentz Priority: Trivial Fix For: 2.3.x In building a JSP, and working on web related things outside of the Java environment, there are lots of tags which all receive the class attribute. The Struts developer must _remember_ to call the attribute cssClass instead. Typing muscle memory drives me to half of the time typing class instead, which leads to HTML which reads, 'class=class java.util.HashMap' Why not just allow class like the rest of the HTML world? Why do we need to be different? I have a billion things to remember when web developing, this shouldn't be one of them. We don't even have to to deprecate or obsolete cssClass, just also allow class... please! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4106) ChainingInterceptor has references to Struts
[
https://issues.apache.org/jira/browse/WW-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4106:
--
Fix Version/s: (was: 2.3.17)
2.5
ChainingInterceptor has references to Struts
Key: WW-4106
URL: https://issues.apache.org/jira/browse/WW-4106
Project: Struts 2
Issue Type: Improvement
Components: Core Actions
Affects Versions: 2.3.14.3
Reporter: Lukasz Lenart
Priority: Trivial
Fix For: 2.5
ChainingInterceptor uses constants with struts prefix:
- struts.xwork.chaining.copyErrors
- struts.xwork.chaining.copyFieldErrors
- struts.xwork.chaining.copyMessages
These must be changed to ie. chainingCopyErrors and then translated in
{{BeanSelectionProvider}}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933923#comment-13933923
]
ASF subversion and git services commented on WW-4297:
-
Commit d63deb9750a3d409be30414faaf76f5481a4417d in struts's branch
refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d63deb9 ]
WW-4297 finishes feature: improves hidden tag to properly support xhtml theme
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4297.
---
Resolution: Fixed
Assignee: Lukasz Lenart
Done, patch applied! Thanks!
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Assignee: Lukasz Lenart
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933929#comment-13933929
]
Paul Benedict commented on WW-4297:
---
The commit doesn't hide the row using CSS like the reporter recommended.
Oversight or intended?
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Assignee: Lukasz Lenart
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934010#comment-13934010
]
Lukasz Lenart commented on WW-4297:
---
D... you're right :/
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Assignee: Lukasz Lenart
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Reopened] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart reopened WW-4297:
---
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Assignee: Lukasz Lenart
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-4297) XHTML validations for s:hidden in form
[
https://issues.apache.org/jira/browse/WW-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934034#comment-13934034
]
Lukasz Lenart commented on WW-4297:
---
Thanks [~paul4christ79]! Reverted to original solution.
XHTML validations for s:hidden in form
--
Key: WW-4297
URL: https://issues.apache.org/jira/browse/WW-4297
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.15.3
Environment: Plattform independent
Reporter: Fredrik Andersson
Assignee: Lukasz Lenart
Priority: Minor
Labels: newbie
Fix For: 2.3.17
Original Estimate: 2h
Remaining Estimate: 2h
Hello!
I first posted this in user u...@struts.apache.org, please see:
https://mail-archives.apache.org/mod_mbox/struts-user/201403.mbox/%3cdub129-w3328cf1dd22c328a3f2480b1...@phx.gbl%3E
It looks like this might be a bug since the form do not pass validation at:
http://validator.w3.org/check
The problem is that hidden tags in the form is within the table, but do not
get any tr and td tags.
The struts-users helped me to this work around:
I put a new file hidden.ftl in my resources-folder (I use maven with
eclipse):
resources/template/xhtml/hidden.ftl
The content in hidden.ftl is:
{code:xml}
tr style=display:none;
td
#include /${parameters.templateDir}/simple/hidden.ftl /
/td
/tr
{code}
Then it validates fine!
Best regards
Fredrik
.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (WW-4069) Upgrade DWR plugin to use the latest available version of DWR - 2.0.10
[ https://issues.apache.org/jira/browse/WW-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4069: -- Fix Version/s: (was: 2.3.17) 2.3.x Upgrade DWR plugin to use the latest available version of DWR - 2.0.10 -- Key: WW-4069 URL: https://issues.apache.org/jira/browse/WW-4069 Project: Struts 2 Issue Type: Improvement Components: Plugin - DWR Affects Versions: 2.3.14 Reporter: Lukasz Lenart Priority: Minor Fix For: 2.3.x -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-3901) Review usage of Container and switch to ObjectFactory instead
[ https://issues.apache.org/jira/browse/WW-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-3901: -- Fix Version/s: (was: 2.3.17) 2.3.x Review usage of Container and switch to ObjectFactory instead - Key: WW-3901 URL: https://issues.apache.org/jira/browse/WW-3901 Project: Struts 2 Issue Type: Improvement Components: Value Stack Affects Versions: 2.3.7 Reporter: Lukasz Lenart Assignee: Lukasz Lenart Priority: Minor Fix For: 2.3.x It is better to use ObjectFactory to construct new objects instead using Container - ObjectFactory has many other implementations (Spring, Guice) and Container doesn't. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4276) Implement TimeZoneProvider
[ https://issues.apache.org/jira/browse/WW-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4276: -- Fix Version/s: (was: 2.3.17) 2.3.x Implement TimeZoneProvider -- Key: WW-4276 URL: https://issues.apache.org/jira/browse/WW-4276 Project: Struts 2 Issue Type: Improvement Components: Core Actions Affects Versions: 2.3.16 Reporter: Lukasz Lenart Priority: Minor Fix For: 2.3.x http://markmail.org/message/jzfnmxy3n6lltaus -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-3788) Convert ServletActionContext to be more as ActionContext
[ https://issues.apache.org/jira/browse/WW-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-3788: -- Fix Version/s: (was: 2.3.17) 2.3.x Convert ServletActionContext to be more as ActionContext Key: WW-3788 URL: https://issues.apache.org/jira/browse/WW-3788 Project: Struts 2 Issue Type: Improvement Components: Core Actions Affects Versions: 2.3.1.2 Reporter: Lukasz Lenart Priority: Minor Fix For: 2.3.x ServletActionContext has only static accessors, compering to ActionContext which can be passed as an instance. If this will be converted into an instance available class, then UrlHelper can use it instead of bunch of method's parameters. -- This message was sent by Atlassian JIRA (v6.2#6252)
