[jira] [Commented] (WW-4355) Remove HTML5 deprecated attributes from templates
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14017465#comment-14017465 ] ASF GitHub Bot commented on WW-4355: Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45061200 I'm not sure if this is the best idea, I mean hardcoding styles in tags - they will always take precedence over CSS classes. Remove HTML5 deprecated attributes from templates - Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Remove HTML5 deprecated attributes from templates
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Component/s: Plugin - Tags Remove HTML5 deprecated attributes from templates - Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Remove HTML5 deprecated attributes from templates
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Affects Version/s: 2.3.16.3 Remove HTML5 deprecated attributes from templates - Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Remove HTML5 deprecated attributes from templates
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Fix Version/s: 2.3.18 Remove HTML5 deprecated attributes from templates - Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Remove deprecated HTML attributes from templates
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Summary: Remove deprecated HTML attributes from templates (was: Remove HTML5 deprecated attributes from templates) Remove deprecated HTML attributes from templates Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Replace deprecate HTML attributes with CSS
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Summary: Replace deprecate HTML attributes with CSS (was: Remove deprecated HTML attributes from templates) Replace deprecate HTML attributes with CSS -- Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WW-4355) Replace deprecated HTML attributes with CSS
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4355: -- Summary: Replace deprecated HTML attributes with CSS (was: Replace deprecate HTML attributes with CSS) Replace deprecated HTML attributes with CSS --- Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4355) Replace deprecated HTML attributes with CSS
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018058#comment-14018058 ] ASF GitHub Bot commented on WW-4355: Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45139719 In most cases it doesn't really matter, but yes it isn't a perfect solution. Do you think adding classes to elements and including a CSS file to `simple` theme is better? Then users can decide whether they are going to use default CSS (by using `s:head`), style those elements with custom CSS (elements will have specific classes) or leave theme w/o any style. BTW what is `table.ftl` and where it is used? Replace deprecated HTML attributes with CSS --- Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4355) Replace deprecated HTML attributes with CSS
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018488#comment-14018488 ] ASF GitHub Bot commented on WW-4355: Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182042 It can stay as is for now IMO, we can think about that with S2.5 or S3 - remove hardcoded styles and used CSS classes instead. Then `simple` theme won't provide any styling for those but `xhtml` and other themes can style the elements accordingly. Replace deprecated HTML attributes with CSS --- Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4355) Replace deprecated HTML attributes with CSS
[ https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018490#comment-14018490 ] ASF GitHub Bot commented on WW-4355: Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182314 BTW what is table.ftl and where it is used? First I thought it's used by `debug.ftl` but I've checked that and it's not - so it's some leftover, also there is `table.vm` which means it comes with WW in its early days ;-) Can be thrown away! Replace deprecated HTML attributes with CSS --- Key: WW-4355 URL: https://issues.apache.org/jira/browse/WW-4355 Project: Struts 2 Issue Type: Improvement Components: Plugin - Tags Affects Versions: 2.3.16.3 Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Change HTML5 deprecated attributes to CSS in templates. -- This message was sent by Atlassian JIRA (v6.2#6252)
