[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394116#comment-14394116
]
Lukasz Lenart commented on WW-4462:
---
What do you think about such a fix?
https://github.com/jkuhnert/ognl/commit/2767d66cc9df153f59204861ececb0629986c8ed
Not sure if this will solve your problem but you can always test :)
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394075#comment-14394075
]
Lukasz Lenart commented on WW-4462:
---
https://github.com/jkuhnert/ognl#release-notes---version-309 ?
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WW-4484) Upgrade to FreeMarker 2.3.22
[ https://issues.apache.org/jira/browse/WW-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-4484. --- Resolution: Fixed Assignee: Lukasz Lenart Thanks for reporting! I missed out the new version :) > Upgrade to FreeMarker 2.3.22 > > > Key: WW-4484 > URL: https://issues.apache.org/jira/browse/WW-4484 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.3.20 >Reporter: Daniel Dekany >Assignee: Lukasz Lenart > Fix For: 2.3.23 > > > You are still using 2.3.19 from 3 years ago. There were many improvements > since then. Even if many users don't care about new features, they still > benefit from the more helpful error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WW-4481) Deprecated warning gives no context
[ https://issues.apache.org/jira/browse/WW-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4481: -- Affects Version/s: (was: 2.3.22) 2.3.23 > Deprecated warning gives no context > --- > > Key: WW-4481 > URL: https://issues.apache.org/jira/browse/WW-4481 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.3.23 >Reporter: Jasper Rosenberg >Assignee: Lukasz Lenart >Priority: Critical > Fix For: 2.3.23 > > > I released 2.3.22 and immediately had my log files fill up with this warning: > WARN [SecurityMemberAccess] Support for accessing static methods is > deprecated! Please refactor your application! > I was surprised because I thought I had actually removed all static > references, but I can't find what I missed because this warning has no > context. Can you please add the information about the expression being > evaluated so I can track down the usage? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WW-4484) Upgrade to FreeMarker 2.3.22
[ https://issues.apache.org/jira/browse/WW-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4484: -- Fix Version/s: 2.3.23 > Upgrade to FreeMarker 2.3.22 > > > Key: WW-4484 > URL: https://issues.apache.org/jira/browse/WW-4484 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.3.20 >Reporter: Daniel Dekany > Fix For: 2.3.23 > > > You are still using 2.3.19 from 3 years ago. There were many improvements > since then. Even if many users don't care about new features, they still > benefit from the more helpful error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WW-4484) Upgrade to FreeMarker 2.3.22
[ https://issues.apache.org/jira/browse/WW-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4484: -- Affects Version/s: (was: 2.3.23) (was: 2.3.22) > Upgrade to FreeMarker 2.3.22 > > > Key: WW-4484 > URL: https://issues.apache.org/jira/browse/WW-4484 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.3.20 >Reporter: Daniel Dekany > Fix For: 2.3.23 > > > You are still using 2.3.19 from 3 years ago. There were many improvements > since then. Even if many users don't care about new features, they still > benefit from the more helpful error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
unsubscribe
unsubscribe
[jira] [Created] (WW-4484) Upgrade to FreeMarker 2.3.22
Daniel Dekany created WW-4484: - Summary: Upgrade to FreeMarker 2.3.22 Key: WW-4484 URL: https://issues.apache.org/jira/browse/WW-4484 Project: Struts 2 Issue Type: Improvement Affects Versions: 2.3.20, 2.3.22, 2.3.23 Reporter: Daniel Dekany You are still using 2.3.19 from 3 years ago. There were many improvements since then. Even if many users don't care about new features, they still benefit from the more helpful error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
unsubscribe
unsubscribe
[jira] [Comment Edited] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392968#comment-14392968
]
Jasper Rosenberg edited comment on WW-4462 at 4/2/15 5:15 PM:
--
The problem is that https://issues.apache.org/jira/browse/WW-4451 is not in
3.0.6 (also it appears to not be in the readme notes for 3.0.9, though I think
that is where it was fixed)
was (Author: perfnorm):
The problem is that https://issues.apache.org/jira/browse/WW-4451 is not in
3.0.6
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392968#comment-14392968
]
Jasper Rosenberg commented on WW-4462:
--
The problem is that https://issues.apache.org/jira/browse/WW-4451 is not in
3.0.6
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392702#comment-14392702
]
Lukasz Lenart commented on WW-4462:
---
but S2 is using OGNL version 3.0.6 - so what's the problem?
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392578#comment-14392578
]
Hudson commented on WW-4482:
SUCCESS: Integrated in Struts-JDK6-develop #138 (See
[https://builds.apache.org/job/Struts-JDK6-develop/138/])
WW-4482 Fallbacks to non-collection evaluation for non-collection param
(lukaszlenart: rev 4a08f070f101dbe8a74b7ed53794d645274ee9da)
* xwork-core/src/main/java/com/opensymphony/xwork2/util/TextParseUtil.java
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.3.23
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392529#comment-14392529
]
Jasper Rosenberg commented on WW-4462:
--
Maybe there should be an ognl branch with just the thread safety/hashing fixes
that actually goes out with the next struts2 core release (since everyone need
it), and the patch that is a regression risk (how bean properties are
interpreted) could be temporarily backed out or split off.
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4462) Regression bug in ognl for "is..." property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392524#comment-14392524
]
Jasper Rosenberg commented on WW-4462:
--
Is there anyway this could get fixed for 2.3.23? I really want to upgrade to
the latest ognl (we encountered one of the fixed threading issues in production
again last week), but this is a blocker for me. Thanks for considering it.
> Regression bug in ognl for "is..." property getters
> ---
>
> Key: WW-4462
> URL: https://issues.apache.org/jira/browse/WW-4462
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Labels: ognl
> Fix For: 2.5
>
>
> We have a lot of getters on our actions that look like:
> public boolean getIsTruck() {
> return isTruck;
> }
> That lets us write ftl that looks like:
> <#if isTruck>...
> However, this support was broken in a recent ognl release, I believe by this
> patch:
> https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
> I don't see any reason why this pattern shouldn't be supported, so I'm
> assuming it is a bug.
> This is also keeping us from being able to upgrade to the latest ognl which
> has some critical fixes we were really hoping to take advantage of.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392521#comment-14392521
]
Jasper Rosenberg commented on WW-4482:
--
Awesome, thanks!
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.3.23
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392359#comment-14392359
]
ASF subversion and git services commented on WW-4482:
-
Commit 4a08f070f101dbe8a74b7ed53794d645274ee9da in struts's branch
refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4a08f07 ]
WW-4482 Fallbacks to non-collection evaluation for non-collection param
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Priority: Critical
> Fix For: 2.3.23
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4482.
---
Resolution: Fixed
Assignee: Lukasz Lenart
Done, resolved!
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.3.23
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
