[jira] [Assigned] (WW-4507) Struts 2 XSS vulnerability with
[ https://issues.apache.org/jira/browse/WW-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rene Gielen reassigned WW-4507: --- Assignee: Rene Gielen > Struts 2 XSS vulnerability with > - > > Key: WW-4507 > URL: https://issues.apache.org/jira/browse/WW-4507 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.3.16.3 > Environment: Operating System: Windows 7. Application Server: > JBoss-4.2.1.GA. Java: jdk1.5.0.11. Developloment Framework: Struts > 2.3.16.3. Browser: FireFox 38.0.1 >Reporter: brian neisen >Assignee: Rene Gielen > Labels: struts2, vulnerability, xss > Fix For: 2.3.x > > > WhiteHat Security (whitehatsec.com) has found an xss vulnerability with the > tag. When loading a url in a browser with some param name, in > this case "myinput", and the jsp being loaded has the tag name="myinput" id="myinput">, an alert message is popped open > in the browser- which is WhiteHat's method of showing the vulnerability. > Example url is: > [http://localhost:8080/sample.action?myinput=%fc%80%80%80%80%a2%fc%80%80%80%80%bE%FC%80%80%80%80%BC%FC%80%80%80%81%B7%FC%80%80%80%81%A8%FC%80%80%80%81%B3%FC%80%80%80%81%A3%FC%80%80%80%81%A8%FC%80%80%80%81%A5%FC%80%80%80%81%A3%FC%80%80%80%81%AB%FC%80%80%80%80%BE%fc%80%80%80%80%bCscript%fc%80%80%80%80%bEalert%fc%80%80%80%80%a81%fc%80%80%80%80%a9%fc%80%80%80%80%bC%fc%80%80%80%80%aFscript%fc%80%80%80%80%bE] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4585) Struts2 Rest plugin doesn't handle JSESSIONID with DMI
[
https://issues.apache.org/jira/browse/WW-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101974#comment-15101974
]
Rich P Peters, II commented on WW-4585:
---
Ive done that. Its issue WW-4589. Don't know how to do a Pull Request in the
GitHub yet, will look at that.
> Struts2 Rest plugin doesn't handle JSESSIONID with DMI
> --
>
> Key: WW-4585
> URL: https://issues.apache.org/jira/browse/WW-4585
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - REST
>Affects Versions: 2.3.24
> Environment: tomcat
>Reporter: Rich P Peters, II
>Assignee: Aleksandr Mashchenko
>Priority: Blocker
> Fix For: 2.3.25, 2.5
>
> Attachments: RestActionMapper.java
>
>
> If a url with DMI and with a JSESSIONID is sent to a Struts2 action, a
> failure will result
> see this modified unit test from the plugin unit test:
> {code:java}
> public void testGetJsessionIdSemicolonMappingWithMethod() throws
> Exception {
>
> req.setRequestURI("/myapp/animals/dog/fido!update;jsessionid=29fefpv23do1g");
> req.setServletPath("/animals/dog/fido");
> req.setMethod("GET");
> mapper.setAllowDynamicMethodCalls("true");
> ActionMapping mapping = mapper.getMapping(req, configManager);
> assertEquals("/animals", mapping.getNamespace());
> assertEquals("dog", mapping.getName());
> assertEquals("fido", ((String[]) mapping.getParams().get("id"))[0]);
> assertEquals("update", mapping.getMethod());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WW-4589) Struts2 REST plugin does not compute id and action name correctly
[
https://issues.apache.org/jira/browse/WW-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich P Peters, II updated WW-4589:
--
Description:
When creating a ActionMapper for a rest url with a method name, an incorrect
mapping is created. I haven't been able to determine a fix for this with the
new code, but it works in my code provided for WW-4545. A unit test shows the
issue:
{code:java}
public void testMappingWithMethodAndId() throws Exception {
req.setRequestURI("/myapp/animals/dog/fido/test/some-id!create;jsessionid=29fefpv23do1g");
req.setServletPath("/animals/dog/fido/test/some-id");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("/animals", mapping.getNamespace());
assertEquals("dog/fido/test", mapping.getName());
assertEquals("some-id", ((String[]) mapping.getParams().get("id"))[0]);
assertEquals("create", mapping.getMethod());
}
{code}
here is the unit test result:
{code:java}
junit.framework.ComparisonFailure: null
Expected :dog/fido/test
Actual :dog/fido
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingWithMethodAndId(RestActionMapperTest.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
{code}
Another test that fails in a different way:
{code:java}
public void testMappingForStaticFiles() throws Exception {
req.setRequestURI("/myApp/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image!iframe");
req.setServletPath("/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("", mapping.getNamespace());
assertEquals("custom/menu/Yosemite/Vernal_Fall", mapping.getName());
assertEquals("Vernal_Fall_Image", ((String[])
mapping.getParams().get("id"))[0]);
assertEquals("iframe", mapping.getMethod());
}
{code}
Unit test results:
{code:java}
junit.framework.ComparisonFailure: null
Expected :custom/menu/Yosemite/Vernal_Fall
Actual :custom/menu/Yosemite
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingForStaticFiles(RestActionMapperTest.java:216)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.in
[jira] [Updated] (WW-4589) Struts2 REST plugin does not compute id and action name correctly
[
https://issues.apache.org/jira/browse/WW-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich P Peters, II updated WW-4589:
--
Description:
When creating a ActionMapper for a rest url with a method name, an incorrect
mapping is created. I haven't been able to determine a fix for this with the
new code, but it works in my code provided for WW-4545 against . A unit test
shows the issue:
{code:java}
public void testMappingWithMethodAndId() throws Exception {
req.setRequestURI("/myapp/animals/dog/fido/test/some-id!create;jsessionid=29fefpv23do1g");
req.setServletPath("/animals/dog/fido/test/some-id");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("/animals", mapping.getNamespace());
assertEquals("dog/fido/test", mapping.getName());
assertEquals("some-id", ((String[]) mapping.getParams().get("id"))[0]);
assertEquals("create", mapping.getMethod());
}
{code}
here is the unit test result:
{code:java}
junit.framework.ComparisonFailure: null
Expected :dog/fido/test
Actual :dog/fido
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingWithMethodAndId(RestActionMapperTest.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
{code}
Another test that fails in a different way:
{code:java}
public void testMappingForStaticFiles() throws Exception {
req.setRequestURI("/myApp/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image!iframe");
req.setServletPath("/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("", mapping.getNamespace());
assertEquals("custom/menu/Yosemite/Vernal_Fall", mapping.getName());
assertEquals("Vernal_Fall_Image", ((String[])
mapping.getParams().get("id"))[0]);
assertEquals("iframe", mapping.getMethod());
}
{code}
Unit test results:
{code:java}
junit.framework.ComparisonFailure: null
Expected :custom/menu/Yosemite/Vernal_Fall
Actual :custom/menu/Yosemite
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingForStaticFiles(RestActionMapperTest.java:216)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
a
[jira] [Updated] (WW-4589) Struts2 REST plugin does not compute id and action name correctly
[
https://issues.apache.org/jira/browse/WW-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich P Peters, II updated WW-4589:
--
Description:
When creating a ActionMapper for a rest url with a method name, an incorrect
mapping is created. a unit test shows the issue:
{code:java}
public void testMappingWithMethodAndId() throws Exception {
req.setRequestURI("/myapp/animals/dog/fido/test/some-id!create;jsessionid=29fefpv23do1g");
req.setServletPath("/animals/dog/fido/test/some-id");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("/animals", mapping.getNamespace());
assertEquals("dog/fido/test", mapping.getName());
assertEquals("some-id", ((String[]) mapping.getParams().get("id"))[0]);
assertEquals("create", mapping.getMethod());
}
{code}
here is the unit test result:
{code:java}
junit.framework.ComparisonFailure: null
Expected :dog/fido/test
Actual :dog/fido
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingWithMethodAndId(RestActionMapperTest.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
{code}
Another test that fails in a different way:
{code:java}
public void testMappingForStaticFiles() throws Exception {
req.setRequestURI("/myApp/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image!iframe");
req.setServletPath("/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("", mapping.getNamespace());
assertEquals("custom/menu/Yosemite/Vernal_Fall", mapping.getName());
assertEquals("Vernal_Fall_Image", ((String[])
mapping.getParams().get("id"))[0]);
assertEquals("iframe", mapping.getMethod());
}
{code}
Unit test results:
{code:java}
junit.framework.ComparisonFailure: null
Expected :custom/menu/Yosemite/Vernal_Fall
Actual :custom/menu/Yosemite
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingForStaticFiles(RestActionMapperTest.java:216)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.exe
[jira] [Created] (WW-4589) Struts2 REST plugin does not compute id and action name correctly
Rich P Peters, II created WW-4589:
-
Summary: Struts2 REST plugin does not compute id and action name
correctly
Key: WW-4589
URL: https://issues.apache.org/jira/browse/WW-4589
Project: Struts 2
Issue Type: Bug
Components: Plugin - REST
Environment: tomcat
Reporter: Rich P Peters, II
Fix For: 2.3.25, 2.5
when creating a mapper for a rest url with a method name, an incorrect mapping
is created. a unit test shows the issue:
{code:java}
public void testMappingWithMethodAndId() throws Exception {
req.setRequestURI("/myapp/animals/dog/fido/test/some-id!create;jsessionid=29fefpv23do1g");
req.setServletPath("/animals/dog/fido/test/some-id");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("/animals", mapping.getNamespace());
assertEquals("dog/fido/test", mapping.getName());
assertEquals("some-id", ((String[]) mapping.getParams().get("id"))[0]);
assertEquals("create", mapping.getMethod());
}
{code}
here is the unit test result:
{code:java}
junit.framework.ComparisonFailure: null
Expected :dog/fido/test
Actual :dog/fido
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingWithMethodAndId(RestActionMapperTest.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
{code}
Another test that fails in a different way:
{code:java}
public void testMappingForStaticFiles() throws Exception {
req.setRequestURI("/myApp/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image!iframe");
req.setServletPath("/custom/menu/Yosemite/Vernal_Fall/Vernal_Fall_Image");
req.setMethod("GET");
mapper.setAllowDynamicMethodCalls("true");
ActionMapping mapping = mapper.getMapping(req, configManager);
assertEquals("", mapping.getNamespace());
assertEquals("custom/menu/Yosemite/Vernal_Fall", mapping.getName());
assertEquals("Vernal_Fall_Image", ((String[])
mapping.getParams().get("id"))[0]);
assertEquals("iframe", mapping.getMethod());
}
{code}
Unit test results:
{code:java}
junit.framework.ComparisonFailure: null
Expected :custom/menu/Yosemite/Vernal_Fall
Actual :custom/menu/Yosemite
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.struts2.rest.RestActionMapperTest.testMappingForStaticFiles(RestActionMapperTest.java:216)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
at org.junit.runner.JUnitCore.run(JUnitCore.java:15
[jira] [Commented] (WW-4584) Upgrade Tiles 3 pugin to latest available Tiles 3 version
[ https://issues.apache.org/jira/browse/WW-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101799#comment-15101799 ] ASF GitHub Bot commented on WW-4584: Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171968504 :+1: > Upgrade Tiles 3 pugin to latest available Tiles 3 version > - > > Key: WW-4584 > URL: https://issues.apache.org/jira/browse/WW-4584 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart > Fix For: 2.5 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4584) Upgrade Tiles 3 pugin to latest available Tiles 3 version
[ https://issues.apache.org/jira/browse/WW-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101525#comment-15101525 ] ASF GitHub Bot commented on WW-4584: Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171909190 I think the solution is final, I have added support for Struts' Locale and properly implemented support for it. I also updated `struts-examples`. Enjoy! > Upgrade Tiles 3 pugin to latest available Tiles 3 version > - > > Key: WW-4584 > URL: https://issues.apache.org/jira/browse/WW-4584 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart > Fix For: 2.5 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4585) Struts2 Rest plugin doesn't handle JSESSIONID with DMI
[
https://issues.apache.org/jira/browse/WW-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101413#comment-15101413
]
Aleksandr Mashchenko commented on WW-4585:
--
[~rpii] Yes, open a new issue and explain in it what do you expect to get.
Right now test results show `Expected :dog` but there is no such assert in the
test method you've provided.
If you have a solution base it on master branch, please. If you need this in
2.3.x branch then we can cherry pick it from master. Additionally, instead of
providing patches you can open a Pull Request in the
[GitHub|https://github.com/apache/struts].
> Struts2 Rest plugin doesn't handle JSESSIONID with DMI
> --
>
> Key: WW-4585
> URL: https://issues.apache.org/jira/browse/WW-4585
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - REST
>Affects Versions: 2.3.24
> Environment: tomcat
>Reporter: Rich P Peters, II
>Assignee: Aleksandr Mashchenko
>Priority: Blocker
> Fix For: 2.3.25, 2.5
>
> Attachments: RestActionMapper.java
>
>
> If a url with DMI and with a JSESSIONID is sent to a Struts2 action, a
> failure will result
> see this modified unit test from the plugin unit test:
> {code:java}
> public void testGetJsessionIdSemicolonMappingWithMethod() throws
> Exception {
>
> req.setRequestURI("/myapp/animals/dog/fido!update;jsessionid=29fefpv23do1g");
> req.setServletPath("/animals/dog/fido");
> req.setMethod("GET");
> mapper.setAllowDynamicMethodCalls("true");
> ActionMapping mapping = mapper.getMapping(req, configManager);
> assertEquals("/animals", mapping.getNamespace());
> assertEquals("dog", mapping.getName());
> assertEquals("fido", ((String[]) mapping.getParams().get("id"))[0]);
> assertEquals("update", mapping.getMethod());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
