[jira] [Updated] (WW-4923) JasperReportResult: NPE When Not Using SQL Connection

2018-02-22 Thread Lukasz Lenart (JIRA)

 [ 
https://issues.apache.org/jira/browse/WW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukasz Lenart updated WW-4923:
--
Fix Version/s: 2.5.16

> JasperReportResult: NPE When Not Using SQL Connection
> -
>
> Key: WW-4923
> URL: https://issues.apache.org/jira/browse/WW-4923
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - JasperReports
>Affects Versions: 2.5.14.1
>Reporter: Paul Zepernick
>Priority: Minor
> Fix For: 2.5.16
>
>
> The JasperReportResult throws a NPE in the finally when closing the SQL 
> connection when using a Data Source from the value stack instead of supplying 
> a SQL connection to the report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-4921) NPE in I18nInterceptor$SessionLocaleHandler.read

2018-02-22 Thread Yasser Zamani (JIRA)

[ 
https://issues.apache.org/jira/browse/WW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373258#comment-16373258
 ] 

Yasser Zamani commented on WW-4921:
---

I analysed this issue and to sum up, I saw WW-3442 adds session creation to 
StrutsTestCase but I'm not sure if it's good idea to also follow such policy 
for StrutsJUnit4TestCase (?) because what should we do then when a user wants 
to run it's test with no invocation session (on) ... so I decided to revert 
back it's logic to previous stable logic from WW-4741 while keeping it fixed.

> NPE in I18nInterceptor$SessionLocaleHandler.read
> 
>
> Key: WW-4921
> URL: https://issues.apache.org/jira/browse/WW-4921
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core Interceptors
>Reporter: Michael Hintenaus
>Priority: Major
>  Labels: test
> Fix For: 2.5.16
>
>
> Calling
> {code:java}
> getActionProxy("/index.action").getInvocation().invoke(){code}
> in a TestCase which extends from StrutsJUnit4TestCase will lead to a 
> NullPointerException.
> Overriding getActionProxy like this will help:
> {code:java}
>  @Override
>     protected ActionProxy getActionProxy(final String uri) {
>         final ActionProxy proxy = super.getActionProxy(uri);
>         final ActionContext context = 
> proxy.getInvocation().getInvocationContext();
>         if (context.getSession() == null) {
>             context.setSession(new SessionMap<>(request));            
>         }
>         return proxy;
>     }{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-4921) NPE in I18nInterceptor$SessionLocaleHandler.read

2018-02-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373248#comment-16373248
 ] 

ASF GitHub Bot commented on WW-4921:


yasserzamani opened a new pull request #213: WW-4921 revert I18nInterceptor 
logic from WW-4741 changes…
URL: https://github.com/apache/struts/pull/213
 
 
   … to it's previous stable logic
   
   WW-4741 changes logic which breaks WW-4921. This commit if applied, will 
revert the logic to previous stable state but keeps WW-4741 fixed and also will 
fix WW-4921.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> NPE in I18nInterceptor$SessionLocaleHandler.read
> 
>
> Key: WW-4921
> URL: https://issues.apache.org/jira/browse/WW-4921
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core Interceptors
>Reporter: Michael Hintenaus
>Priority: Major
>  Labels: test
> Fix For: 2.5.16
>
>
> Calling
> {code:java}
> getActionProxy("/index.action").getInvocation().invoke(){code}
> in a TestCase which extends from StrutsJUnit4TestCase will lead to a 
> NullPointerException.
> Overriding getActionProxy like this will help:
> {code:java}
>  @Override
>     protected ActionProxy getActionProxy(final String uri) {
>         final ActionProxy proxy = super.getActionProxy(uri);
>         final ActionContext context = 
> proxy.getInvocation().getInvocationContext();
>         if (context.getSession() == null) {
>             context.setSession(new SessionMap<>(request));            
>         }
>         return proxy;
>     }{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (WW-4923) JasperReportResult: NPE When Not Using SQL Connection

2018-02-22 Thread Paul Zepernick (JIRA)

 [ 
https://issues.apache.org/jira/browse/WW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Zepernick updated WW-4923:
---
Priority: Minor  (was: Major)

> JasperReportResult: NPE When Not Using SQL Connection
> -
>
> Key: WW-4923
> URL: https://issues.apache.org/jira/browse/WW-4923
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - JasperReports
>Affects Versions: 2.5.14.1
>Reporter: Paul Zepernick
>Priority: Minor
>
> The JasperReportResult throws a NPE in the finally when closing the SQL 
> connection when using a Data Source from the value stack instead of supplying 
> a SQL connection to the report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-4923) JasperReportResult: NPE When Not Using SQL Connection

2018-02-22 Thread Paul Zepernick (JIRA)

[ 
https://issues.apache.org/jira/browse/WW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372926#comment-16372926
 ] 

Paul Zepernick commented on WW-4923:


Added pull request on GitHub to resolve the issue.  
https://github.com/apache/struts/pull/212

> JasperReportResult: NPE When Not Using SQL Connection
> -
>
> Key: WW-4923
> URL: https://issues.apache.org/jira/browse/WW-4923
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - JasperReports
>Affects Versions: 2.5.14.1
>Reporter: Paul Zepernick
>Priority: Major
>
> The JasperReportResult throws a NPE in the finally when closing the SQL 
> connection when using a Data Source from the value stack instead of supplying 
> a SQL connection to the report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (WW-4923) JasperReportResult: NPE When Not Using SQL Connection

2018-02-22 Thread Paul Zepernick (JIRA)
Paul Zepernick created WW-4923:
--

 Summary: JasperReportResult: NPE When Not Using SQL Connection
 Key: WW-4923
 URL: https://issues.apache.org/jira/browse/WW-4923
 Project: Struts 2
  Issue Type: Bug
  Components: Plugin - JasperReports
Affects Versions: 2.5.14.1
Reporter: Paul Zepernick


The JasperReportResult throws a NPE in the finally when closing the SQL 
connection when using a Data Source from the value stack instead of supplying a 
SQL connection to the report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)