[jira] [Resolved] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5001. --- Resolution: Fixed > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749200#comment-16749200 ] Hudson commented on WW-5001: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #252 (See [https://builds.apache.org/job/Struts-master-JDK7/252/]) WW-5001 Adds support for struts-conversion.properties files (lukaszlenart: rev fc81832e8afbe9e47f74e4f61b74733ec66892c1) * (edit) core/src/main/resources/struts-default.xml * (add) core/src/test/resources/com/opensymphony/xwork2/conversion/impl/test-struts-conversion.properties * (delete) core/src/test/resources/com/opensymphony/xwork2/conversion/impl/test-xwork-conversion.properties * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultConversionPropertiesProcessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (add) core/src/main/java/org/apache/struts2/conversion/StrutsConversionPropertiesProcessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749173#comment-16749173 ] ASF subversion and git services commented on WW-5001: - Commit fc81832e8afbe9e47f74e4f61b74733ec66892c1 in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=fc81832 ] WW-5001 Adds support for struts-conversion.properties files > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749175#comment-16749175 ] ASF subversion and git services commented on WW-5001: - Commit 3d25d2fb15600780cfb1f3562e221fb7dc1af681 in struts's branch refs/heads/master from Aleksandr Mashchenko [ https://gitbox.apache.org/repos/asf?p=struts.git;h=3d25d2f ] Merge pull request #313 from lukaszlenart/WW-5001 [WW-5001] Adds support for struts-conversion.properties files > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749174#comment-16749174 ] ASF subversion and git services commented on WW-5001: - Commit 3d25d2fb15600780cfb1f3562e221fb7dc1af681 in struts's branch refs/heads/master from Aleksandr Mashchenko [ https://gitbox.apache.org/repos/asf?p=struts.git;h=3d25d2f ] Merge pull request #313 from lukaszlenart/WW-5001 [WW-5001] Adds support for struts-conversion.properties files > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749172#comment-16749172 ] ASF GitHub Bot commented on WW-5001: aleksandr-m commented on pull request #313: [WW-5001] Adds support for struts-conversion.properties files URL: https://github.com/apache/struts/pull/313 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-5005) Struts2 convention plugin lacks Java 11 support
[ https://issues.apache.org/jira/browse/WW-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5005: -- Fix Version/s: 2.6 2.5.21 > Struts2 convention plugin lacks Java 11 support > --- > > Key: WW-5005 > URL: https://issues.apache.org/jira/browse/WW-5005 > Project: Struts 2 > Issue Type: New Feature > Components: Plugin - Convention >Affects Versions: 2.5.20, 2.6 >Reporter: Sebastian Götz >Priority: Major > Fix For: 2.5.21, 2.6 > > > As discussed in the mailing list, the convention plugin is uncapable of > analysing web applications that have classes compiled with class versions > higher than 52. This blocks users that compile their web app projects with > Java 9, 10 or 11. > Excerpt from the mailing list discussion: > I have taken a look at the struts-2-5-x branch in github. There is a global > property in the {{struts-parent}} of that defines the version for ASM: > {{5.2}} > The {{struts-master}} pom of the current github *master branch* has: > {{7.0}} > But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line > 461) of the *master branch* there is still ASM 5 used: > {{public class InfoBuildingVisitor extends ClassVisitor {}} > {{ private Info info;}} > {{ private ClassFinder classFinder;}} > {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} > *{{super(Opcodes.ASM5);}}* > {{ this.classFinder = classFinder;}} > \{{ }}} > So first step would be to change this coupling to ASM's version 7 API and > check how this affects classes compiled with Java 8 or below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-5005) Struts2 convention plugin lacks Java 11 support
[ https://issues.apache.org/jira/browse/WW-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5005: -- Affects Version/s: (was: 2.6) > Struts2 convention plugin lacks Java 11 support > --- > > Key: WW-5005 > URL: https://issues.apache.org/jira/browse/WW-5005 > Project: Struts 2 > Issue Type: New Feature > Components: Plugin - Convention >Affects Versions: 2.5.20 >Reporter: Sebastian Götz >Priority: Major > Fix For: 2.5.21, 2.6 > > > As discussed in the mailing list, the convention plugin is uncapable of > analysing web applications that have classes compiled with class versions > higher than 52. This blocks users that compile their web app projects with > Java 9, 10 or 11. > Excerpt from the mailing list discussion: > I have taken a look at the struts-2-5-x branch in github. There is a global > property in the {{struts-parent}} of that defines the version for ASM: > {{5.2}} > The {{struts-master}} pom of the current github *master branch* has: > {{7.0}} > But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line > 461) of the *master branch* there is still ASM 5 used: > {{public class InfoBuildingVisitor extends ClassVisitor {}} > {{ private Info info;}} > {{ private ClassFinder classFinder;}} > {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} > *{{super(Opcodes.ASM5);}}* > {{ this.classFinder = classFinder;}} > \{{ }}} > So first step would be to change this coupling to ASM's version 7 API and > check how this affects classes compiled with Java 8 or below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-5005) Struts2 convention plugin lacks Java 11 support
[ https://issues.apache.org/jira/browse/WW-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Götz updated WW-5005: --- Description: As discussed in the mailing list, the convention plugin is uncapable of analysing web applications that have classes compiled with class versions higher than 52. This blocks users that compile their web app projects with Java 9, 10 or 11. Excerpt from the mailing list discussion: I have taken a look at the struts-2-5-x branch in github. There is a global property in the {{struts-parent}} of that defines the version for ASM: {{5.2}} The {{struts-master}} pom of the current github *master branch* has: {{7.0}} But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line 461) of the *master branch* there is still ASM 5 used: {{public class InfoBuildingVisitor extends ClassVisitor {}} {{ private Info info;}} {{ private ClassFinder classFinder;}} {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} *{{super(Opcodes.ASM5);}}* {{ this.classFinder = classFinder;}} \{{ }}} So first step would be to change this coupling to ASM's version 7 API and check how this affects classes compiled with Java 8 or below. was: As discussed in the mailing list, the convention plugin is uncapable of analysing web applications that have classes compiled with class versions higher than 52. This blocks users that compile the web app projects with Java 9, 10 or 11. Excerpt from the mailing list discussion: I have taken a look at the struts-2-5-x branch in github. There is a global property in the {{struts-parent}} of that defines the version for ASM: {{5.2}} The {{struts-master}} pom of the current github *master branch* has: {{7.0}} But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line 461) of the *master branch* there is still ASM 5 used: {{public class InfoBuildingVisitor extends ClassVisitor {}} {{ private Info info;}} {{ private ClassFinder classFinder;}} {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} *{{super(Opcodes.ASM5);}}* {{ this.classFinder = classFinder;}} {{ }}} So first step would be to change this coupling to ASM's version 7 API and check how this affects classes compiled with Java 8 or below. > Struts2 convention plugin lacks Java 11 support > --- > > Key: WW-5005 > URL: https://issues.apache.org/jira/browse/WW-5005 > Project: Struts 2 > Issue Type: New Feature > Components: Plugin - Convention >Affects Versions: 2.5.20, 2.6 >Reporter: Sebastian Götz >Priority: Major > > As discussed in the mailing list, the convention plugin is uncapable of > analysing web applications that have classes compiled with class versions > higher than 52. This blocks users that compile their web app projects with > Java 9, 10 or 11. > Excerpt from the mailing list discussion: > I have taken a look at the struts-2-5-x branch in github. There is a global > property in the {{struts-parent}} of that defines the version for ASM: > {{5.2}} > The {{struts-master}} pom of the current github *master branch* has: > {{7.0}} > But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line > 461) of the *master branch* there is still ASM 5 used: > {{public class InfoBuildingVisitor extends ClassVisitor {}} > {{ private Info info;}} > {{ private ClassFinder classFinder;}} > {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} > *{{super(Opcodes.ASM5);}}* > {{ this.classFinder = classFinder;}} > \{{ }}} > So first step would be to change this coupling to ASM's version 7 API and > check how this affects classes compiled with Java 8 or below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5005) Struts2 convention plugin lacks Java 11 support
[ https://issues.apache.org/jira/browse/WW-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748544#comment-16748544 ] Sebastian Götz commented on WW-5005: As we compile with JDK 11 already (class version 55) we get a lot of these exceptions (using 2.5.20): {{ java.lang.IllegalArgumentException}} {{ at org.objectweb.asm.ClassReader.(Unknown Source)}} {{ at org.objectweb.asm.ClassReader.(Unknown Source)}} {{ at org.objectweb.asm.ClassReader.(Unknown Source)}} {{ at org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:461)}} {{ at org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:93)}} {{ at org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:395)}} {{ at org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:377)}} {{ at org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:333)}} {{ at org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:52)}} {{ at com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:206)}} {{ at com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:66)}} {{ at org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)}} {{ at org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:463)}} {{ at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)}} {{ at org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:73)}} {{ at org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:61)}} {{ at eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)}} {{ at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)}} {{ at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)}} {{ at org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:102)}} {{ at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)}} {{ at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5135)}} {{ at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)}} {{ at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)}} {{ at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)}} {{ at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)}} {{ at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)}} {{ at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)}} {{ at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)}} {{ at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)}} {{ at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)}} {{ at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)}} {{ at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)}} {{ at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)}} {{ at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)}} {{ at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)}} {{ at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)}} {{ at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)}} {{ at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)}} {{ at org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)}} {{ at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)}} {{ at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)}} {{ at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)}} {{ at org.apache.catalina.startup.Catalina.start(Catalina.java:695)}} {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)}} {{ at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)}} {{ at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)}} {{ at java.base/java.lang.reflect.Method.invoke(Method.java:566)}} {{ at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)}} {{ at
[jira] [Created] (WW-5005) Struts2 convention plugin lacks Java 11 support
Sebastian Götz created WW-5005: -- Summary: Struts2 convention plugin lacks Java 11 support Key: WW-5005 URL: https://issues.apache.org/jira/browse/WW-5005 Project: Struts 2 Issue Type: New Feature Components: Plugin - Convention Affects Versions: 2.5.20, 2.6 Reporter: Sebastian Götz As discussed in the mailing list, the convention plugin is uncapable of analysing web applications that have classes compiled with class versions higher than 52. This blocks users that compile the web app projects with Java 9, 10 or 11. Excerpt from the mailing list discussion: I have taken a look at the struts-2-5-x branch in github. There is a global property in the {{struts-parent}} of that defines the version for ASM: {{5.2}} The {{struts-master}} pom of the current github *master branch* has: {{7.0}} But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line 461) of the *master branch* there is still ASM 5 used: {{public class InfoBuildingVisitor extends ClassVisitor {}} {{ private Info info;}} {{ private ClassFinder classFinder;}} {{ public InfoBuildingVisitor(ClassFinder classFinder) {}} *{{super(Opcodes.ASM5);}}* {{ this.classFinder = classFinder;}} {{ }}} So first step would be to change this coupling to ASM's version 7 API and check how this affects classes compiled with Java 8 or below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4348) Remove access to static methods
[ https://issues.apache.org/jira/browse/WW-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748526#comment-16748526 ] Lukasz Lenart commented on WW-4348: --- Yeah, but we block access to {{#application}} from outside > Remove access to static methods > --- > > Key: WW-4348 > URL: https://issues.apache.org/jira/browse/WW-4348 > Project: Struts 2 > Issue Type: Improvement > Components: Core Actions >Affects Versions: 2.3.16.3 >Reporter: Lukasz Lenart >Priority: Critical > Fix For: 2.5.x > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[ https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748497#comment-16748497 ] Lukasz Lenart commented on WW-5004: --- I would rather opt to add another flag {{struts.allowStaticFieldAccess}} and set it to {{true}} by default. OGNL shouldn't be changed and checking access to static fields is a good idea. {{OgnlContext.DEFAULT_MEMBER_ACCESS}} is always used to hack a system, with such flag and control mechanism in place this won't be possible anymore. > No more calling of a static variable in Struts 2.8.20 available > --- > > Key: WW-5004 > URL: https://issues.apache.org/jira/browse/WW-5004 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.20 > Environment: Java 7.1 and JSP Websites >Reporter: Deniz Renkligül >Priority: Critical > Labels: build, features, patch, usability > Fix For: 2.5.21, 2.6 > > > After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call > a java static variable in JSP like > {code:java} > > {code} > Please see for more details the release notes of 2.5.20 > [link > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20] > and I tried without success the following description assigned above in the > release version notes 2.5.20 with : > {code:java} > > > {code} > https://issues.apache.org/jira/browse/WW-4984 > > Thanks in advance for your support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)