[jira] [Commented] (WW-5099) Upgrade JFreeChart plugin to the latest version of JFreeChart
[ https://issues.apache.org/jira/browse/WW-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237605#comment-17237605 ] James Hartleroad commented on WW-5099: -- Re-created the patch using the master branch. > Upgrade JFreeChart plugin to the latest version of JFreeChart > - > > Key: WW-5099 > URL: https://issues.apache.org/jira/browse/WW-5099 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - JFreeChart >Reporter: James Hartleroad >Priority: Minor > Fix For: 2.6 > > Attachments: jfreechart_patch.txt > > > Upgrade JFreeChart to the newest version. > Today that is jcommon version 1.0.24 and jfreechart 1.5.1 > Updating jfreechart to 1.5.1 will require a import statement and code changes > due to class name and method name changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (WW-5099) Upgrade JFreeChart plugin to the latest version of JFreeChart
[ https://issues.apache.org/jira/browse/WW-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Hartleroad updated WW-5099: - Attachment: jfreechart_patch.txt > Upgrade JFreeChart plugin to the latest version of JFreeChart > - > > Key: WW-5099 > URL: https://issues.apache.org/jira/browse/WW-5099 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - JFreeChart >Reporter: James Hartleroad >Priority: Minor > Fix For: 2.6 > > Attachments: jfreechart_patch.txt > > > Upgrade JFreeChart to the newest version. > Today that is jcommon version 1.0.24 and jfreechart 1.5.1 > Updating jfreechart to 1.5.1 will require a import statement and code changes > due to class name and method name changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (WW-5099) Upgrade JFreeChart plugin to the latest version of JFreeChart
[ https://issues.apache.org/jira/browse/WW-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Hartleroad updated WW-5099: - Attachment: (was: patchfile_v2.5.x.txt) > Upgrade JFreeChart plugin to the latest version of JFreeChart > - > > Key: WW-5099 > URL: https://issues.apache.org/jira/browse/WW-5099 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - JFreeChart >Reporter: James Hartleroad >Priority: Minor > Fix For: 2.6 > > Attachments: jfreechart_patch.txt > > > Upgrade JFreeChart to the newest version. > Today that is jcommon version 1.0.24 and jfreechart 1.5.1 > Updating jfreechart to 1.5.1 will require a import statement and code changes > due to class name and method name changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (WW-3730) action tag accepts only String arrays as parameters
[
https://issues.apache.org/jira/browse/WW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasser Zamani resolved WW-3730.
---
Assignee: Lukasz Lenart
Resolution: Fixed
PR got merged, thanks!!
> action tag accepts only String arrays as parameters
> ---
>
> Key: WW-3730
> URL: https://issues.apache.org/jira/browse/WW-3730
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
>Reporter: Pavel Kazlou
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 2.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{org.apache.struts2.components.Component}} accepts arbitrary objects as
> parameters:
> {code}
> public Map getParameters() {
> return parameters;
> }
> ...
> public void addParameter(String key, Object value) {
> if (key != null) {
> Map params = getParameters();
> if (value == null) {
> params.remove(key);
> } else {
> params.put(key, value);
> }
> }
> }
> {code}
> But {{org.apache.struts2.components.ActionComponent}} explicitly casts all
> his parameters to {{String[]}}:
> {code}
> protected Map createParametersForContext() {
> Map parentParams = null;
> if (!ignoreContextParams) {
> parentParams = new
> ActionContext(getStack().getContext()).getParameters();
> }
> Map newParams = (parentParams != null)
> ? new HashMap(parentParams)
> : new HashMap();
> if (parameters != null) {
> Map params = new HashMap();
> for (Iterator i = parameters.entrySet().iterator(); i.hasNext();
> ) {
> Map.Entry entry = (Map.Entry) i.next();
> String key = (String) entry.getKey();
> Object val = entry.getValue();
> if (val.getClass().isArray() && String.class ==
> val.getClass().getComponentType()) {
> params.put(key, (String[])val);
> } else {
> params.put(key, new String[]{val.toString()});
> }
> }
> newParams.putAll(params);
> }
> return newParams;
> }
> {code}
> So I can't pass arbitrary objects directly to action using syntax:
> {code}
> value="customObject"/>
> {code}
> without conversion customObject->String->customObject.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-3730) action tag accepts only String arrays as parameters
[
https://issues.apache.org/jira/browse/WW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237429#comment-17237429
]
ASF subversion and git services commented on WW-3730:
-
Commit 1bf0e123374f538c671f3483072bc552ec3e437c in struts's branch
refs/heads/master from Yasser Zamani
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=1bf0e12 ]
Merge pull request #450 from apache/WW-3730-use-params-directly
[WW-3730] Avoids conversion to String[] of passed params
> action tag accepts only String arrays as parameters
> ---
>
> Key: WW-3730
> URL: https://issues.apache.org/jira/browse/WW-3730
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
>Reporter: Pavel Kazlou
>Priority: Major
> Fix For: 2.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{org.apache.struts2.components.Component}} accepts arbitrary objects as
> parameters:
> {code}
> public Map getParameters() {
> return parameters;
> }
> ...
> public void addParameter(String key, Object value) {
> if (key != null) {
> Map params = getParameters();
> if (value == null) {
> params.remove(key);
> } else {
> params.put(key, value);
> }
> }
> }
> {code}
> But {{org.apache.struts2.components.ActionComponent}} explicitly casts all
> his parameters to {{String[]}}:
> {code}
> protected Map createParametersForContext() {
> Map parentParams = null;
> if (!ignoreContextParams) {
> parentParams = new
> ActionContext(getStack().getContext()).getParameters();
> }
> Map newParams = (parentParams != null)
> ? new HashMap(parentParams)
> : new HashMap();
> if (parameters != null) {
> Map params = new HashMap();
> for (Iterator i = parameters.entrySet().iterator(); i.hasNext();
> ) {
> Map.Entry entry = (Map.Entry) i.next();
> String key = (String) entry.getKey();
> Object val = entry.getValue();
> if (val.getClass().isArray() && String.class ==
> val.getClass().getComponentType()) {
> params.put(key, (String[])val);
> } else {
> params.put(key, new String[]{val.toString()});
> }
> }
> newParams.putAll(params);
> }
> return newParams;
> }
> {code}
> So I can't pass arbitrary objects directly to action using syntax:
> {code}
> value="customObject"/>
> {code}
> without conversion customObject->String->customObject.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-3730) action tag accepts only String arrays as parameters
[
https://issues.apache.org/jira/browse/WW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237430#comment-17237430
]
ASF subversion and git services commented on WW-3730:
-
Commit 1bf0e123374f538c671f3483072bc552ec3e437c in struts's branch
refs/heads/master from Yasser Zamani
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=1bf0e12 ]
Merge pull request #450 from apache/WW-3730-use-params-directly
[WW-3730] Avoids conversion to String[] of passed params
> action tag accepts only String arrays as parameters
> ---
>
> Key: WW-3730
> URL: https://issues.apache.org/jira/browse/WW-3730
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
>Reporter: Pavel Kazlou
>Priority: Major
> Fix For: 2.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{org.apache.struts2.components.Component}} accepts arbitrary objects as
> parameters:
> {code}
> public Map getParameters() {
> return parameters;
> }
> ...
> public void addParameter(String key, Object value) {
> if (key != null) {
> Map params = getParameters();
> if (value == null) {
> params.remove(key);
> } else {
> params.put(key, value);
> }
> }
> }
> {code}
> But {{org.apache.struts2.components.ActionComponent}} explicitly casts all
> his parameters to {{String[]}}:
> {code}
> protected Map createParametersForContext() {
> Map parentParams = null;
> if (!ignoreContextParams) {
> parentParams = new
> ActionContext(getStack().getContext()).getParameters();
> }
> Map newParams = (parentParams != null)
> ? new HashMap(parentParams)
> : new HashMap();
> if (parameters != null) {
> Map params = new HashMap();
> for (Iterator i = parameters.entrySet().iterator(); i.hasNext();
> ) {
> Map.Entry entry = (Map.Entry) i.next();
> String key = (String) entry.getKey();
> Object val = entry.getValue();
> if (val.getClass().isArray() && String.class ==
> val.getClass().getComponentType()) {
> params.put(key, (String[])val);
> } else {
> params.put(key, new String[]{val.toString()});
> }
> }
> newParams.putAll(params);
> }
> return newParams;
> }
> {code}
> So I can't pass arbitrary objects directly to action using syntax:
> {code}
> value="customObject"/>
> {code}
> without conversion customObject->String->customObject.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (WW-3730) action tag accepts only String arrays as parameters
[
https://issues.apache.org/jira/browse/WW-3730?focusedWorklogId=515601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515601
]
ASF GitHub Bot logged work on WW-3730:
--
Author: ASF GitHub Bot
Created on: 23/Nov/20 15:21
Start Date: 23/Nov/20 15:21
Worklog Time Spent: 10m
Work Description: yasserzamani merged pull request #450:
URL: https://github.com/apache/struts/pull/450
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 515601)
Time Spent: 1h (was: 50m)
> action tag accepts only String arrays as parameters
> ---
>
> Key: WW-3730
> URL: https://issues.apache.org/jira/browse/WW-3730
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
>Reporter: Pavel Kazlou
>Priority: Major
> Fix For: 2.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{org.apache.struts2.components.Component}} accepts arbitrary objects as
> parameters:
> {code}
> public Map getParameters() {
> return parameters;
> }
> ...
> public void addParameter(String key, Object value) {
> if (key != null) {
> Map params = getParameters();
> if (value == null) {
> params.remove(key);
> } else {
> params.put(key, value);
> }
> }
> }
> {code}
> But {{org.apache.struts2.components.ActionComponent}} explicitly casts all
> his parameters to {{String[]}}:
> {code}
> protected Map createParametersForContext() {
> Map parentParams = null;
> if (!ignoreContextParams) {
> parentParams = new
> ActionContext(getStack().getContext()).getParameters();
> }
> Map newParams = (parentParams != null)
> ? new HashMap(parentParams)
> : new HashMap();
> if (parameters != null) {
> Map params = new HashMap();
> for (Iterator i = parameters.entrySet().iterator(); i.hasNext();
> ) {
> Map.Entry entry = (Map.Entry) i.next();
> String key = (String) entry.getKey();
> Object val = entry.getValue();
> if (val.getClass().isArray() && String.class ==
> val.getClass().getComponentType()) {
> params.put(key, (String[])val);
> } else {
> params.put(key, new String[]{val.toString()});
> }
> }
> newParams.putAll(params);
> }
> return newParams;
> }
> {code}
> So I can't pass arbitrary objects directly to action using syntax:
> {code}
> value="customObject"/>
> {code}
> without conversion customObject->String->customObject.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-3730) action tag accepts only String arrays as parameters
[
https://issues.apache.org/jira/browse/WW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237428#comment-17237428
]
ASF subversion and git services commented on WW-3730:
-
Commit 8996e0ad9733d7b95fc8f163d7df633cbe1221fa in struts's branch
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=8996e0a ]
WW-3730 Avoids conversion to String[] of passed params
> action tag accepts only String arrays as parameters
> ---
>
> Key: WW-3730
> URL: https://issues.apache.org/jira/browse/WW-3730
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.2.3.1, 2.3.1, 2.3.1.1, 2.3.20
>Reporter: Pavel Kazlou
>Priority: Major
> Fix For: 2.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{org.apache.struts2.components.Component}} accepts arbitrary objects as
> parameters:
> {code}
> public Map getParameters() {
> return parameters;
> }
> ...
> public void addParameter(String key, Object value) {
> if (key != null) {
> Map params = getParameters();
> if (value == null) {
> params.remove(key);
> } else {
> params.put(key, value);
> }
> }
> }
> {code}
> But {{org.apache.struts2.components.ActionComponent}} explicitly casts all
> his parameters to {{String[]}}:
> {code}
> protected Map createParametersForContext() {
> Map parentParams = null;
> if (!ignoreContextParams) {
> parentParams = new
> ActionContext(getStack().getContext()).getParameters();
> }
> Map newParams = (parentParams != null)
> ? new HashMap(parentParams)
> : new HashMap();
> if (parameters != null) {
> Map params = new HashMap();
> for (Iterator i = parameters.entrySet().iterator(); i.hasNext();
> ) {
> Map.Entry entry = (Map.Entry) i.next();
> String key = (String) entry.getKey();
> Object val = entry.getValue();
> if (val.getClass().isArray() && String.class ==
> val.getClass().getComponentType()) {
> params.put(key, (String[])val);
> } else {
> params.put(key, new String[]{val.toString()});
> }
> }
> newParams.putAll(params);
> }
> return newParams;
> }
> {code}
> So I can't pass arbitrary objects directly to action using syntax:
> {code}
> value="customObject"/>
> {code}
> without conversion customObject->String->customObject.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
